https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21296 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95624|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 97579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97579&action=edit Bug 21296: suspend hold ignores system preference on intranet This patch modifies the DataTable configuration for the table of holds which displays under the "Holds" tab on the patron's checkout and details pages. A variable is now defined in the JavaScript with the value of the "SuspendHoldsIntranet" system preference. This variable is passed to the DataTable configuration to determine whether the column is visible or not. One of the changes made in this patch moves a <script> block so that it appears before some of the JS includes on the page. This helps keep the string-defining JS together in one block. To test, apply the patch and set the "SuspendHoldsIntranet" system preference to "Allow." - Open the checkout page for a patron with one or more holds. - Under the "Holds" tab, the table of holds should have a "Suspend" column with controls for suspending or resuming holds. - Check that the same is true on the patron detail page. - Set the "SuspendHoldsIntranet" system preference to "Don't allow." - Test the checkout and detail pages again and confirm that the "Suspend" column does not appear. Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.