[Bug 16036] New: Making basket actions buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16036 Bug ID: 16036 Summary: Making basket actions buttons Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: aleishaamohia@hotmail.com QA Contact: testopia@bugs.koha-community.org Styling the actions (View, Add to basket) as font awesome buttons -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16036 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16036 --- Comment #1 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 48916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48916&action=edit Bug 16036: Making basket actions buttons To test: 1) Go to Acqui -> do a vendor search 2) Confirm actions 'View' and 'Add to basket' are now buttons and behave as expected Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16036 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |aleishaamohia@hotmail.com |ity.org | Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16036 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48916|0 |1 is obsolete| | --- Comment #2 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 48923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48923&action=edit Bug 16036: Making basket actions buttons To test: 1) Go to Acqui -> do a vendor search 2) Confirm actions 'View' and 'Add to basket' are now buttons and behave as expected Sponsored-by: Catalyst IT Signed-off-by: Frédéric Demians <f.demians@tamil.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16036 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16036 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15992 CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (Same as bug 15992 comment 6) Aleisha, seems to be the common way to "named" the actions column: % git grep '<th> </th>' **/*.tt|wc 127 339 13098 % git grep '<th>Actions</th>' **/*.tt|wc 15 33 1485 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16036 --- Comment #4 from Aleisha Amohia <aleishaamohia@hotmail.com> --- (In reply to Jonathan Druart from comment #3)
(Same as bug 15992 comment 6) Aleisha, seems to be the common way to "named" the actions column:
% git grep '<th> </th>' **/*.tt|wc 127 339 13098 % git grep '<th>Actions</th>' **/*.tt|wc 15 33 1485
Same reply as bug 15992: I think it tends to be that when the actions have been moved into a drop down menu, the column gets named because each drop down has Actions on it. But when there is no drop down and it is just buttons like this, the column name should be Actions. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16036 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Should not we apply the white-space: nowrap style for the actions td (see bug 16048 comment2)? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16036 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16048 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16036 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16036 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 49012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49012&action=edit Bug 16036 [Follow-up] Making basket actions buttons This trivial follow-up adds an "actions" class to the table cell containing the new buttons. In conjunction with the style update in Bug 16048, this will prevent the buttons from wrapping at narrow browser window widths. To test, apply the patch for Bug 16048 and search for a vendor in Acquisitions which has at least one open basket. Confirm that the "View" and "Add to basket" buttons look correct and do not wrap when you make your browser window narrower. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16036 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48923|0 |1 is obsolete| | --- Comment #7 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 49068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49068&action=edit [SIGNED-OFF] Bug 16036: Making basket actions buttons To test: 1) Go to Acqui -> do a vendor search 2) Confirm actions 'View' and 'Add to basket' are now buttons and behave as expected Sponsored-by: Catalyst IT Signed-off-by: Frédéric Demians <f.demians@tamil.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16036 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16036 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49012|0 |1 is obsolete| | --- Comment #8 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 49069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49069&action=edit [SIGNED-OFF] Bug 16036 [Follow-up] Making basket actions buttons This trivial follow-up adds an "actions" class to the table cell containing the new buttons. In conjunction with the style update in Bug 16048, this will prevent the buttons from wrapping at narrow browser window widths. To test, apply the patch for Bug 16048 and search for a vendor in Acquisitions which has at least one open basket. Confirm that the "View" and "Add to basket" buttons look correct and do not wrap when you make your browser window narrower. Signed-off-by: Aleisha <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16036 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16036 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49068|0 |1 is obsolete| | Attachment #49069|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 49115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49115&action=edit Bug 16036: Making basket actions buttons To test: 1) Go to Acqui -> do a vendor search 2) Confirm actions 'View' and 'Add to basket' are now buttons and behave as expected Sponsored-by: Catalyst IT Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16036 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 49116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49116&action=edit Bug 16036 [Follow-up] Making basket actions buttons This trivial follow-up adds an "actions" class to the table cell containing the new buttons. In conjunction with the style update in Bug 16048, this will prevent the buttons from wrapping at narrow browser window widths. To test, apply the patch for Bug 16048 and search for a vendor in Acquisitions which has at least one open basket. Confirm that the "View" and "Add to basket" buttons look correct and do not wrap when you make your browser window narrower. Signed-off-by: Aleisha <aleishaamohia@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16036 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #11 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org