[Bug 15995] New: Moving libraries actions into a drop-down menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15995 Bug ID: 15995 Summary: Moving libraries actions into a drop-down menu Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: aleishaamohia@hotmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Similar to Bug 15932, Bug 13778, Bug 15830, Bug 15952, Bug 15966, Bug 15988, Bug 15989, Bug 15990, Bug 15991, Bug 15992, Bug 15993 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15995 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15995 --- Comment #1 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 48722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48722&action=edit Bug 15995: Moving libraries actions into a drop-down menu To test: 1) Go to Administration -> Libraries and Groups 2) Confirm that the actions 'Edit' and 'Delete' have been moved into drop-down menus for BOTH tables and buttons behave as expected. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15995 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15995 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48722|0 |1 is obsolete| | --- Comment #2 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 48828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48828&action=edit Bug 15995: Moving libraries actions into a drop-down menu To test: 1) Go to Administration -> Libraries and Groups 2) Confirm that the actions 'Edit' and 'Delete' have been moved into drop-down menus for BOTH tables and buttons behave as expected. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15995 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Comment on attachment 48828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48828 Bug 15995: Moving libraries actions into a drop-down menu Review of attachment 48828: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15995&attachment=48828) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt @@ +306,5 @@
<td>[% category.categorycode %]</td> <td>[% category.codedescription %]</td> <td> + <div class="dropdown"> + <a class="btn btn-mini dropdown-toggle" id="libraryactions[% library.branchcode %]" role="button" data-toggle="dropdown" href="#">
library.branchcode will never be defined on deleting a group of libraries. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15995 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16015 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Note that the deletion of a group of libraries is broken, see bug 16015 for a fix. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15995 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org Status|Signed Off |In Discussion --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Aleisha, putting this in discussion, it seems that we should use the drop-down menu only when we have more than 2 buttons. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15995 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15995 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48828|0 |1 is obsolete| | --- Comment #6 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 48904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48904&action=edit Bug 15995: Making libraries actions buttons To test: 1) Go to Administration -> Libraries and Groups 2) Confirm that the actions 'Edit' and 'Delete' are now buttons for BOTH tables under one column 'Actions' and buttons behave as expected. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15995 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Moving libraries actions |Making libraries actions |into a drop-down menu |buttons -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15995 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|koha-bugs@lists.koha-commun |aleishaamohia@hotmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15995 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 49049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49049&action=edit [SIGNED-OFF] Bug 15995: Making libraries actions buttons To test: 1) Go to Administration -> Libraries and Groups 2) Confirm that the actions 'Edit' and 'Delete' are now buttons for BOTH tables under one column 'Actions' and buttons behave as expected. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15995 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 49050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49050&action=edit Bug 15995 [Follow-up] Making libraries actions buttons This trivial follow-up adds an "actions" class to the table cell containing the new buttons. In conjunction with the style update in Bug 16048, this will prevent the buttons from wrapping at narrow browser window widths. To test, apply the patch for Bug 16048 and go to Administration -> Libraries and Groups. Confirm that the "Edit" and "Delete" buttons do not wrap even at narrow browser window widths. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15995 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48904|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15995 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15995 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49050|0 |1 is obsolete| | --- Comment #9 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 49067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49067&action=edit [SIGNED-OFF] Bug 15995 [Follow-up] Making libraries actions buttons This trivial follow-up adds an "actions" class to the table cell containing the new buttons. In conjunction with the style update in Bug 16048, this will prevent the buttons from wrapping at narrow browser window widths. To test, apply the patch for Bug 16048 and go to Administration -> Libraries and Groups. Confirm that the "Edit" and "Delete" buttons do not wrap even at narrow browser window widths. Signed-off-by: Aleisha <aleishaamohia@hotmail.com> You forgot to add the class to one of the tables, but I have added it -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15995 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15995 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49049|0 |1 is obsolete| | Attachment #49067|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 49117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49117&action=edit Bug 15995: Making libraries actions buttons To test: 1) Go to Administration -> Libraries and Groups 2) Confirm that the actions 'Edit' and 'Delete' are now buttons for BOTH tables under one column 'Actions' and buttons behave as expected. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15995 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 49118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49118&action=edit Bug 15995 [Follow-up] Making libraries actions buttons This trivial follow-up adds an "actions" class to the table cell containing the new buttons. In conjunction with the style update in Bug 16048, this will prevent the buttons from wrapping at narrow browser window widths. To test, apply the patch for Bug 16048 and go to Administration -> Libraries and Groups. Confirm that the "Edit" and "Delete" buttons do not wrap even at narrow browser window widths. Signed-off-by: Aleisha <aleishaamohia@hotmail.com> You forgot to add the class to one of the tables, but I have added it Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15995 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #12 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org