http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7577 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |5346 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7577 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Version|unspecified |master --- Comment #2 from Owen Leonard <oleonard@myacpl.org> 2012-02-22 15:30:17 UTC --- There are some HTML markup issues with the template for suggestion.pl: Because the validator doesn't like when you use a <label> without an input, there is an alternative for displaying information which isn't in a form: <span class="label">. Using that will give you the same visual style and keep the validator happy. I would probably make display of each of those lines conditional on the existence of the data: [% IF ( total ) %]<li> <span class="label">Total</span>[% total %] </li>[% END %] ...but others might disagree. I'm not sure when the absence of data is important data. There's also a problem with the conditional display of the page's structural markup. There is a superfluous section at the bottom of the page source: <div id="doc3" class="yui-t2"> <div id="bd"> <div id="yui-main"> <div class="yui-b"> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7577 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7802|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> 2012-02-22 16:48:53 UTC --- Created attachment 7810 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7810 Bug 7577 Adds a display page for suggestions Hi Owen, Thank you for yours remarks. I think we want to display all information, even when empty. It seems this is the way it works in others koha parts. I perform yours others remarks. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7577 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7810|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 8125 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8125&action=edit [SIGNED-OFF] Bug 7577: Adds a display page for suggestions Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7577 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #5 from Ian Walls <koha.sekjal@gmail.com> --- Largely a template change; the changes to suggestions.pl are only insofar as to add support for the 'show' op, and clean up some of the foreach statements. Marking Passed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7577 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |rel_3_8 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7577 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8152 -- You are receiving this mail because: You are watching all bug changes.