[Bug 5346] New: Linking suggestions & orders
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5346 Summary: Linking suggestions & orders Change sponsored?: Sponsored Product: Koha Version: rel_3_4 Platform: All URL: http://wiki.koha-community.org/wiki/Linking_sugg_order _acq_RFC OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Acquisitions AssignedTo: henridamien@koha-fr.org ReportedBy: paul.poulain@biblibre.com QAContact: koha-bugs@lists.koha-community.org Estimated Hours: 0.0 in Koha 3.2, the suggestions is not completly linked to the related order. The link is only done through the biblionumber. We will add a field to have a fully qualified link. We will be able to add links to jump from suggestion to orders & from orders to suggestion -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5346 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7163 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5346 --- Comment #1 from Paul Poulain <paul.poulain@biblibre.com> 2011-11-05 10:58:15 UTC --- If you want to participate to the upstreaming: * assign the bug to yourself * retrieve the patch(es) on git.biblibre.com * the branch name can be found using git branch -a|grep NNNN Usually, it should be biblibre/customer/ft/MTNNNN For example: remotes/origin/stetienne/ft/MT6522 This patch is in branch number 5507 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5346 claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire.hernandez@biblibre.c | |om Version|rel_3_4 |rel_3_8 AssignedTo|henridamien@koha-fr.org |claire.hernandez@biblibre.c | |om -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5346 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jonathan.druart@biblibre.co | |m -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5346 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|claire.hernandez@biblibre.c |jonathan.druart@biblibre.co |om |m -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5346 --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> 2012-01-18 13:41:10 UTC --- Created attachment 7216 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7216 Bug 5346 Linking suggestions and orders Display suggestion info in acquisition module: basket.pl neworderempty.pl orderreceive.pl parcel.pl To Test: Create a suggestion and accept it. Create a new order from this suggestion Receive this order For each step, check if suggestion info are visible. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5346 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5346 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2012-01-22 21:24:24 UTC --- I ran the tests and noticed that the added suggestion stayed in my database. It's also using a status I have not seen before "STALLED". Can you explain? I think it should delete the suggestion after the tests have been run. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5346 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7216|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2012-01-23 06:53:37 UTC --- Created attachment 7285 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7285 Bug 5346: Linking suggestions and orders. Display suggestion info in acquisition module: basket.pl neworderempty.pl orderreceive.pl parcel.pl To Test: Create a suggestion and accept it. Create a new order from this suggestion Receive this order For each step, check if suggestion info are visible. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Test provides more unit tests, all complete successfully. perl t/db_dependent/Suggestions.t Note: test case should be cleaned up after running tests. Display changes are consistent and information about the suggestion is shown on every important screen now. I created an order from a suggestion and one from an existing record. No problems found. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5346 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2012-01-23 06:53:53 UTC --- Created attachment 7286 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7286 Bug 5346: Small display changes Changing display from: Suggested by Admin, Koha (from suggestion #2) To: Suggested by: Admin, Koha (suggestion #2) Adding some missing parentheses and deleting some additional spaces. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5346 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2012-01-23 06:57:24 UTC --- Jonathan, could you perhaps sign-off on my second patch and fix the unit tests? I don't think status 'STALLED' was implemented and the test case remains in my database after running the tests. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5346 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #7 from Julian Maurice <julian.maurice@biblibre.com> 2012-01-26 11:09:17 UTC --- Katrin, Jonathan asked me to tell you that he's actually not available. He'll come back in two weeks. He also wants to say that the 'stalled' status was already present before his patch, he didn't what it is, so he left it. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5346 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2012-01-26 11:37:14 UTC --- Hi Julian, thx for the answer. I don't know what it is either. :( I think it's not existing in current Koha, so we should make the test use an existing status like 'ASKED'. Perhaps someone else could sign-off on my patch? :) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5346 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7286|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> 2012-02-10 09:25:47 UTC --- Created attachment 7560 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7560 [SIGNED-OFF] Bug 5346: Small display changes -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5346 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5346 --- Comment #10 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-14 22:12:07 UTC --- QA comment: * perlcritic still OK after applying the patches * translatable-template and valid-templates still OK after applying the patches * nothing to say about the code itself * one question though: when i'm on a basket, the link to suggestions is "Suggested by: TEST (suggestion #153)", and when clicking on suggestion #153 link, I don't reach the suggestion itself, just a list of suggestions. Am I doing something wrong or is there a problem somewhere ? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5346 --- Comment #11 from Jonathan Druart <jonathan.druart@biblibre.com> 2012-02-15 11:09:23 UTC --- Paul: Yes there is a problem :) But I can't redirect to the suggestion, the only existing page is the edit suggestion page. I redirect to "suggestion/suggestion.pl?suggestionid=". This page should redirect (in the future) to an other page, displaying a suggestion. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5346 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |koha.sekjal@gmail.com --- Comment #12 from Ian Walls <koha.sekjal@gmail.com> 2012-02-16 18:20:12 UTC --- Main patch implements two new subroutines, with documentation and tests. Introduces those subroutines to scripts, and displays the output if applicable (but not if not). Marking as Passed QA. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5346 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #13 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-17 09:42:34 UTC --- Patch pushed. I hesitated, and fear that we will get some feedback from users about the link to jump to the suggestion that won't reach the suggestion itself. A follow-up to solve this annoyance would be highly welcomed ! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5346 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7577 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5346 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org