[Bug 40283] New: Accessibility of the status message in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40283 Bug ID: 40283 Summary: Accessibility of the status message in the OPAC Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Accessibility Assignee: koha-bugs@lists.koha-community.org Reporter: nina.martinez@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: martin.renvoize@openfifth.co.uk, matt.blenkinsop@openfifth.co.uk, oleonard@myacpl.org The intent of this success criterion is to make users aware of important changes in content that are not given focus, and to do so in a way that doesn't unnecessarily interrupt their work. https://www.w3.org/WAI/WCAG22/Understanding/status-messages.html To improve this, we can add role=”status” or role=”alert” in the message tag. Using the status role from the ARIA specification to notify Assistive Technologies (AT) when content has been updated with information about the user's or application's status. https://www.w3.org/WAI/WCAG22/Techniques/aria/ARIA22 The purpose of the role=”alert” is to notify Assistive Technologies (AT) when an input error occurs. The role=”alert”attribute makes it possible for an AT (such as a screen reader) to be notified when error messages -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40283 Nina Martinez <nina.martinez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nina.martinez@biblibre.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40283 Nina Martinez <nina.martinez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26038 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26038 [Bug 26038] Accessibility: 4.1.3 Status Messages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40283 Nina Martinez <nina.martinez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40283 --- Comment #1 from Nina Martinez <nina.martinez@biblibre.com> --- Created attachment 183665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183665&action=edit Bug 40283: discharge page This patch add role="status" or role="alert" to the message tag of the opac-discharge page. Test plan: 1- Enable the system preference: UseDischarge 2- Log in to a patron account with items check out, or make checkout 3- Go to "Ask for discharge", there should be a message: "You cannot be discharged because: ..." Inspect the html code, and notice that there is a role="alert" in the message tag. 4- Check in all the items or log in to a new patron account without items checked out, and click on "Ask for discharge". You should see the button "Ask for a discharge", click on it, and a message should appear. Inspect in the html if there is a role="status" in the message tag. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40283 --- Comment #2 from Nina Martinez <nina.martinez@biblibre.com> --- Created attachment 183666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183666&action=edit Bug 40283: Change password page (opac-passwd) Test plan: 1. Enable the system preference: OpacPasswordChange, RequireStrongPassword 2. Log in to a Patron account, choose "Change Password". A message should appear "You password must contain ... and numbers.". Inspect the html code and notice that there is a role="alert" in the message tag. 3. Enter an incorrect current password and a new password, then submit. A message should appear "Your cuurent password was ... to reset your password for you". Inspect the html code, and notice that there is a role="alert" in the message tag. 4. Enter your current password, change it to a new one, and confirm. A message should appear "Your password has been changed.". Inspect the html code, and notice that there is a role="status" in the message tag. 5. Go to the Staff interface. Don't allow the system preference: OpacPasswordChange. Go back to the OPAC, refresh the page: opac-passwd.pl A message should appear "You can't change your password". Inspect the html code and notice that there is a role='alert' in the message tag. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40283 --- Comment #3 from Nina Martinez <nina.martinez@biblibre.com> --- Created attachment 183667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183667&action=edit Bug 40283: Placing a hold page. Test plan: 1. Research a record and choose one, then place a hold on it. Try to place the hold twice. A message should appear: 'You already have at least one ... holds must be at the record level.' Inspect the HTML code and notice that there is a role='alert' in the message tag 2. Go to the Staff interface, then in Koha administration, click on 'Circulation and fine rules.' Determine the number of holds allowed. Log in to a patron account and place holds to reach the limit. Try to exceed the limit. A message should appear: 'This title cannot be requested because you have reached the maximum number of holds.' Inspect the HTML code and notice that there is a role='alert' in the message tag. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40283 --- Comment #4 from Nina Martinez <nina.martinez@biblibre.com> --- Created attachment 183668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183668&action=edit Bug 40283: Messaging page. This patch add role="status" in the message tag of the Messaging page (opac-messaging) Test plan: 1. Enable the following preference system: EnhancedMessagingPreferencesOPAC and TranslateNotices 2. Log in to a patron account and click on messaging in the user menu. Change your messaging settings/ A message should appear "Settings updated". Inspect the html code and notice that there is a role='status' in the message tag. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40283 --- Comment #5 from Nina Martinez <nina.martinez@biblibre.com> --- Created attachment 183669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183669&action=edit Bug 40283: Consent page. This patch add role='status' to the message tag of the consent page (opac-patron-page) Test plan: 1. Enable the system preference: PrivacyPolicyConsent 2. Log in to a patron account. Go to the 'Consent' page, Change your consent twice. If you save Yes, the message should be: "Your consent was registered on 'date'" and if you save no: "We registered that you did not consent on 'date'". Inscpect each time the html code and notice that there is a role='status' in the message tag. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40283 --- Comment #6 from Nina Martinez <nina.martinez@biblibre.com> --- Created attachment 183670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183670&action=edit Bug 40283: Article request page. Test plan: 1- Enable the system preference: ArticleRequests. 2- Go to Circulation and Rules in the staff interface (in the Administration page, click on Circulation and Rules) and set an article request limit. 3- Reach your article requests limit, a message should appear. Inspect the HTML code and notice that there is a role="alert" in the message tag. 4- Go back to Circulation an dRules in the staff interface and choose "No" for "Article requests". Try to male an article request, a message should appear. Inspect the html and notice that there si a role="alert". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40283 --- Comment #7 from Nina Martinez <nina.martinez@biblibre.com> --- Created attachment 183671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183671&action=edit Bug 40283: Your summary page. This patch add role="status" and role="alert" to the Summary page. (opac-user) Test plan: 1- Enable the system preference OpacReportProblem. If you have a checkout record, add a note. A message should appear: "Your note about ...". Inspect the html code and notice that there is a role="status" in the message tag. 2- Create a new patron account with a card expiration date set to tomorrow. Go to the OPAC, log in to this patron account? You should notice on your summary page a message: "Your library card will expire on ...". Inspect the html code and notice that there is a role="alert" in the message tag. 3- Go to the staff interface, patron details, and change the card expiration date to yesterday. Go back to the OPAC and you should now have the message: "Your account has expired as of...". 4-Go to the staff interface, choose your patron, click on more, and choose discharge. 5-Go back to the OPAC, log in to this patron account, and a message should appear: "Your account is frozen because it has been discharged." Inspect the HTML code and notice that there is a role='alert' in the message tag. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40283 --- Comment #8 from Nina Martinez <nina.martinez@biblibre.com> --- Created attachment 183672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183672&action=edit Bug 40283: Course reserves page. Test plan: 1- Enable the system preference: UseCourseReserve. 2- Go to the Course Reserves page, click on the name of the course. Inspect the html code of the message: "No reserves have been selected for this courses", and notice that there is a role="status" in the tag. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40283 --- Comment #9 from Nina Martinez <nina.martinez@biblibre.com> --- Created attachment 183673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183673&action=edit Bug 40283: memberentry page. Added Alert and status role to the messages tags. Test plan: 1- Enable the system preference: OPACPatronDetails 2- Log in to an adult patron account, go to Personal details 3- Without making any changes, click on "submit update request", the alert message should be : 'No changes were made', Inspect the HTML code, and notice that there is a role='alert' in the message tag. 4- Change your date of birth to today and submit 5- An error message should appear: "The following fields contain invalid information ... Patron's age ... correct and resubmit". Inspect the HTML code and notice that there is a role='alert' in the message tag. 6- Add or change an information, and submit the update. A message should appear: 'Thank you ... ' Inspect the HTML code, and notice that there is a role='status'. 7- Now disable the system preference OPACPatronDetails. The status message should be: 'To make changes to your record, please contact the library'. Inspect the HTML code, and notice that there is a role='status' in the message tag. 8- Now log out, click on create a new account, fill the required fields, and fail the captcha? You should see the error message: 'You typed the wrong ... Please try again.' Inspect the HTML code, and notice that there is a role='alert' in the message tag. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40283 --- Comment #10 from Nina Martinez <nina.martinez@biblibre.com> --- Created attachment 183674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183674&action=edit Bug 40283: Privacy page. Test plan: 1- Enable the system preferences: OPACPrivacy, OPACHoldsHistory. 2- Change your privacy rule to "forever" or "default" and save. A message should appear: "Your privacy rules have been updated." Inspect the HTML code and notice that there is a role="status" in the message tag. 3- Change your privacy rule to "Never." A message should appear: "This option will delete all previous checkout history immediately." Inspect the HTML code and notice that there is a role="alert" in the message tag. 4- Check if you have a checkout in your checkout history. If you don't, make a checkout. 5- Click on "Delete checkout history." If you have a checkout history, the message is: "Your checkout history has been deleted." Inspect the HTML code and notice that there is a role="status" in the message tag. 6- Click again on the "Delete checkout history" button; the error message should appear:"No hold history to delete." Inspect the HTML code and notice that there is a role="alert" in the message tag. 7- Check if you have a hold in your holds history. If you don't, place a hold on a record. 8- Repeat step 5 with the "Delete hold history" button. A message should appear: "Your holds history has been deleted." Inspect the HTML code and notice that there is a role="status" in the message tag. 9- Repeat step 6 with the "Delete hold history" button. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40283 --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- opac-passwd.tt includes the addition of 'status="alert"' which I assume is a typo? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40283 Nina Martinez <nina.martinez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183666|0 |1 is obsolete| | --- Comment #12 from Nina Martinez <nina.martinez@biblibre.com> --- Created attachment 183683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183683&action=edit Bug 40283: Change password page (opac-passwd) Test plan: 1. Enable the system preference: OpacPasswordChange, RequireStrongPassword 2. Log in to a Patron account, choose "Change Password". A message should appear "You password must contain ... and numbers.". Inspect the html code and notice that there is a role="alert" in the message tag. 3. Enter an incorrect current password and a new password, then submit. A message should appear "Your current password was ... to reset your password for you". Inspect the html code, and notice that there is a role="alert" in the message tag. 4. Enter your current password, change it to a new one, and confirm. A message should appear "Your password has been changed.". Inspect the html code, and notice that there is a role="status" in the message tag. 5. Go to the Staff interface. Don't allow the system preference: OpacPasswordChange. Go back to the OPAC, refresh the page: opac-passwd.pl A message should appear "You can't change your password". Inspect the html code and notice that there is a role='alert' in the message tag. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40283 --- Comment #13 from Nina Martinez <nina.martinez@biblibre.com> --- (In reply to Owen Leonard from comment #11)
opac-passwd.tt includes the addition of 'status="alert"' which I assume is a typo?
Thank you Owen, I corrected ! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40283 --- Comment #14 from Nina Martinez <nina.martinez@biblibre.com> --- Created attachment 183684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183684&action=edit Bug 40283: Report Problem page. Test plan: 1. Allow the system preference: OPACReportProblem, and entry an email in ReplytoDefault 2. Log in to a patron account. 3. Try to send a problem to a librarian. A message of confirmation should appear: "Your problem report has been sent to the library". Inspect the html code and notice that there is a role="status" in the message tag. 4. Remake step 3 but with a Koha administrator. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40283 --- Comment #15 from Nina Martinez <nina.martinez@biblibre.com> --- Created attachment 183685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183685&action=edit Bug 40283: Lists page. Test plan: 1- Enable the system preference: virtualshelves 2- Create a "New list", two messages should appear "List created" and "This list is empty... ", inspect the html code of "This list is empty ... " and notice that there is a role="status" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40283 --- Comment #16 from Nina Martinez <nina.martinez@biblibre.com> --- Created attachment 183686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183686&action=edit Bug 40283: Share List page. Test plan: 1- Enable the system preference: OpacAllowSharingPrivateLists. 2- Try to share the private list and enter an incorrect email format, a message should appear: "Sorry, but you did not enter a valid email adress." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40283 Nina Martinez <nina.martinez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40283 Nina Martinez <nina.martinez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40283 Nina Martinez <nina.martinez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40283 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40283 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183665|0 |1 is obsolete| | Attachment #183667|0 |1 is obsolete| | Attachment #183668|0 |1 is obsolete| | Attachment #183669|0 |1 is obsolete| | Attachment #183670|0 |1 is obsolete| | Attachment #183671|0 |1 is obsolete| | Attachment #183672|0 |1 is obsolete| | Attachment #183673|0 |1 is obsolete| | Attachment #183674|0 |1 is obsolete| | Attachment #183683|0 |1 is obsolete| | Attachment #183684|0 |1 is obsolete| | Attachment #183685|0 |1 is obsolete| | Attachment #183686|0 |1 is obsolete| | --- Comment #17 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 183689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183689&action=edit Bug 40283: discharge page This patch add role="status" or role="alert" to the message tag of the opac-discharge page. Test plan: 1- Enable the system preference: UseDischarge 2- Log in to a patron account with items check out, or make checkout 3- Go to "Ask for discharge", there should be a message: "You cannot be discharged because: ..." Inspect the html code, and notice that there is a role="alert" in the message tag. 4- Check in all the items or log in to a new patron account without items checked out, and click on "Ask for discharge". You should see the button "Ask for a discharge", click on it, and a message should appear. Inspect in the html if there is a role="status" in the message tag. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40283 --- Comment #18 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 183690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183690&action=edit Bug 40283: Placing a hold page. Test plan: 1. Research a record and choose one, then place a hold on it. Try to place the hold twice. A message should appear: 'You already have at least one ... holds must be at the record level.' Inspect the HTML code and notice that there is a role='alert' in the message tag 2. Go to the Staff interface, then in Koha administration, click on 'Circulation and fine rules.' Determine the number of holds allowed. Log in to a patron account and place holds to reach the limit. Try to exceed the limit. A message should appear: 'This title cannot be requested because you have reached the maximum number of holds.' Inspect the HTML code and notice that there is a role='alert' in the message tag. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40283 --- Comment #19 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 183691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183691&action=edit Bug 40283: Messaging page. This patch add role="status" in the message tag of the Messaging page (opac-messaging) Test plan: 1. Enable the following preference system: EnhancedMessagingPreferencesOPAC and TranslateNotices 2. Log in to a patron account and click on messaging in the user menu. Change your messaging settings/ A message should appear "Settings updated". Inspect the html code and notice that there is a role='status' in the message tag. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40283 --- Comment #20 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 183692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183692&action=edit Bug 40283: Consent page. This patch add role='status' to the message tag of the consent page (opac-patron-page) Test plan: 1. Enable the system preference: PrivacyPolicyConsent 2. Log in to a patron account. Go to the 'Consent' page, Change your consent twice. If you save Yes, the message should be: "Your consent was registered on 'date'" and if you save no: "We registered that you did not consent on 'date'". Inscpect each time the html code and notice that there is a role='status' in the message tag. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40283 --- Comment #21 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 183693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183693&action=edit Bug 40283: Article request page. Test plan: 1- Enable the system preference: ArticleRequests. 2- Go to Circulation and Rules in the staff interface (in the Administration page, click on Circulation and Rules) and set an article request limit. 3- Reach your article requests limit, a message should appear. Inspect the HTML code and notice that there is a role="alert" in the message tag. 4- Go back to Circulation an dRules in the staff interface and choose "No" for "Article requests". Try to male an article request, a message should appear. Inspect the html and notice that there si a role="alert". Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40283 --- Comment #22 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 183694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183694&action=edit Bug 40283: Your summary page. This patch add role="status" and role="alert" to the Summary page. (opac-user) Test plan: 1- Enable the system preference OpacReportProblem. If you have a checkout record, add a note. A message should appear: "Your note about ...". Inspect the html code and notice that there is a role="status" in the message tag. 2- Create a new patron account with a card expiration date set to tomorrow. Go to the OPAC, log in to this patron account? You should notice on your summary page a message: "Your library card will expire on ...". Inspect the html code and notice that there is a role="alert" in the message tag. 3- Go to the staff interface, patron details, and change the card expiration date to yesterday. Go back to the OPAC and you should now have the message: "Your account has expired as of...". 4- Go to the staff interface, choose your patron, click on more, and choose discharge. 5- Go back to the OPAC, log in to this patron account, and a message should appear: "Your account is frozen because it has been discharged." Inspect the HTML code and notice that there is a role='alert' in the message tag. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40283 --- Comment #23 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 183695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183695&action=edit Bug 40283: Course reserves page. Test plan: 1- Enable the system preference: UseCourseReserve. 2- Go to the Course Reserves page, click on the name of the course. Inspect the html code of the message: "No reserves have been selected for this courses", and notice that there is a role="status" in the tag. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40283 --- Comment #24 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 183696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183696&action=edit Bug 40283: memberentry page. Added Alert and status role to the messages tags. Test plan: 1- Enable the system preference: OPACPatronDetails 2- Log in to an adult patron account, go to Personal details 3- Without making any changes, click on "submit update request", the alert message should be : 'No changes were made', Inspect the HTML code, and notice that there is a role='alert' in the message tag. 4- Change your date of birth to today and submit 5- An error message should appear: "The following fields contain invalid information ... Patron's age ... correct and resubmit". Inspect the HTML code and notice that there is a role='alert' in the message tag. 6- Add or change an information, and submit the update. A message should appear: 'Thank you ... ' Inspect the HTML code, and notice that there is a role='status'. 7- Now disable the system preference OPACPatronDetails. The status message should be: 'To make changes to your record, please contact the library'. Inspect the HTML code, and notice that there is a role='status' in the message tag. 8- Now log out, click on create a new account, fill the required fields, and fail the captcha? You should see the error message: 'You typed the wrong ... Please try again.' Inspect the HTML code, and notice that there is a role='alert' in the message tag. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40283 --- Comment #25 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 183697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183697&action=edit Bug 40283: Privacy page. Test plan: 1- Enable the system preferences: OPACPrivacy, OPACHoldsHistory. 2- Change your privacy rule to "forever" or "default" and save. A message should appear: "Your privacy rules have been updated." Inspect the HTML code and notice that there is a role="status" in the message tag. 3- Change your privacy rule to "Never." A message should appear: "This option will delete all previous checkout history immediately." Inspect the HTML code and notice that there is a role="alert" in the message tag. 4- Check if you have a checkout in your checkout history. If you don't, make a checkout. 5- Click on "Delete checkout history." If you have a checkout history, the message is: "Your checkout history has been deleted." Inspect the HTML code and notice that there is a role="status" in the message tag. 6- Click again on the "Delete checkout history" button; the error message should appear:"No hold history to delete." Inspect the HTML code and notice that there is a role="alert" in the message tag. 7- Check if you have a hold in your holds history. If you don't, place a hold on a record. 8- Repeat step 5 with the "Delete hold history" button. A message should appear: "Your holds history has been deleted." Inspect the HTML code and notice that there is a role="status" in the message tag. 9- Repeat step 6 with the "Delete hold history" button. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40283 --- Comment #26 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 183698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183698&action=edit Bug 40283: Change password page (opac-passwd) Test plan: 1. Enable the system preference: OpacPasswordChange, RequireStrongPassword 2. Log in to a Patron account, choose "Change Password". A message should appear "You password must contain ... and numbers.". Inspect the html code and notice that there is a role="alert" in the message tag. 3. Enter an incorrect current password and a new password, then submit. A message should appear "Your current password was ... to reset your password for you". Inspect the html code, and notice that there is a role="alert" in the message tag. 4. Enter your current password, change it to a new one, and confirm. A message should appear "Your password has been changed.". Inspect the html code, and notice that there is a role="status" in the message tag. 5. Go to the Staff interface. Don't allow the system preference: OpacPasswordChange. Go back to the OPAC, refresh the page: opac-passwd.pl A message should appear "You can't change your password". Inspect the html code and notice that there is a role='alert' in the message tag. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40283 --- Comment #27 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 183699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183699&action=edit Bug 40283: Report Problem page. Test plan: 1. Allow the system preference: OPACReportProblem, and entry an email in ReplytoDefault 2. Log in to a patron account. 3. Try to send a problem to a librarian. A message of confirmation should appear: "Your problem report has been sent to the library". Inspect the html code and notice that there is a role="status" in the message tag. 4. Remake step 3 but with a Koha administrator. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40283 --- Comment #28 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 183700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183700&action=edit Bug 40283: Lists page. Test plan: 1- Enable the system preference: virtualshelves 2- Create a "New list", two messages should appear "List created" and "This list is empty... ", inspect the html code of "This list is empty ... " and notice that there is a role="status" Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40283 --- Comment #29 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 183701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183701&action=edit Bug 40283: Share List page. Test plan: 1- Enable the system preference: OpacAllowSharingPrivateLists. 2- Try to share the private list and enter an incorrect email format, a message should appear: "Sorry, but you did not enter a valid email adress." Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40283 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz QA Contact|testopia@bugs.koha-communit |aleisha@catalyst.net.nz |y.org | --- Comment #30 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Hi Nina, thanks for this patchset! A question about the role parameter - should it be added to **every** message that might display for the user? For example, when I was reviewing the changes to the discharge page, I noticed a few <p> messages that have not been given a role: +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-discharge.tt @@ -37,7 +37,7 @@ [% END %] [% IF success %] - <p>Your discharge request has been sent. Your discharge will be available on this page within a few days.</p> + <p role="status">Your discharge request has been sent. Your discharge will be available on this page within a few days.</p> [% ELSIF available %] <p><a href="/cgi-bin/koha/opac-discharge.pl?op=get">Get your discharge</a></p> [% ELSIF pending %] @@ -59,7 +59,7 @@ [% IF failure %] <p> There was an error during the discharge process </p> [% END %] Specifically the "Get your discharge" link and "There was an error during the discharge process" failure message. Should these kinds of messages have roles too? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40283 --- Comment #31 from Nina Martinez <nina.martinez@biblibre.com> --- (In reply to Aleisha Amohia from comment #30)
Hi Nina, thanks for this patchset!
A question about the role parameter - should it be added to **every** message that might display for the user?
For example, when I was reviewing the changes to the discharge page, I noticed a few <p> messages that have not been given a role:
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-discharge.tt @@ -37,7 +37,7 @@ [% END %]
[% IF success %] - <p>Your discharge request has been sent. Your discharge will be available on this page within a few days.</p> + <p role="status">Your discharge request has been sent. Your discharge will be available on this page within a few days.</p> [% ELSIF available %] <p><a href="/cgi-bin/koha/opac-discharge.pl?op=get">Get your discharge</a></p> [% ELSIF pending %] @@ -59,7 +59,7 @@ [% IF failure %] <p> There was an error during the discharge process </p> [% END %]
Specifically the "Get your discharge" link and "There was an error during the discharge process" failure message. Should these kinds of messages have roles too?
Hi Aleisha ! Every message which “provides information to the user on the success or results of an action, on the waiting state of an application, on the progress of a process, or on the existence of errors” that might display for the user should have a role. So the failure message too. In these patches, I handle messages that display often. reference : https://www.w3.org/WAI/WCAG22/Understanding/status-messages.html -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40283 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #32 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- - <div class="alert alert-info"> + <div class="alert alert-info" role="status"> [% IF patron %] [% IF ( patron.category.effective_require_strong_password ) %] <p>Your password must contain at least [% patron.category.effective_min_password_length | html %] characters, including UPPERCASE, lowercase and numbers.</p> Shouldnt that be an alert? Password is not accepted. Class is alert. Can we squash those patches? -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org