https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40283 --- Comment #31 from Nina Martinez <nina.martinez@biblibre.com> --- (In reply to Aleisha Amohia from comment #30)
Hi Nina, thanks for this patchset!
A question about the role parameter - should it be added to **every** message that might display for the user?
For example, when I was reviewing the changes to the discharge page, I noticed a few <p> messages that have not been given a role:
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-discharge.tt @@ -37,7 +37,7 @@ [% END %]
[% IF success %] - <p>Your discharge request has been sent. Your discharge will be available on this page within a few days.</p> + <p role="status">Your discharge request has been sent. Your discharge will be available on this page within a few days.</p> [% ELSIF available %] <p><a href="/cgi-bin/koha/opac-discharge.pl?op=get">Get your discharge</a></p> [% ELSIF pending %] @@ -59,7 +59,7 @@ [% IF failure %] <p> There was an error during the discharge process </p> [% END %]
Specifically the "Get your discharge" link and "There was an error during the discharge process" failure message. Should these kinds of messages have roles too?
Hi Aleisha ! Every message which “provides information to the user on the success or results of an action, on the waiting state of an application, on the progress of a process, or on the existence of errors” that might display for the user should have a role. So the failure message too. In these patches, I handle messages that display often. reference : https://www.w3.org/WAI/WCAG22/Understanding/status-messages.html -- You are receiving this mail because: You are watching all bug changes.