[Bug 11312] New: Add span to facets (for css selection)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11312 Bug ID: 11312 Summary: Add span to facets (for css selection) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: jonathan.druart@biblibre.com QA Contact: testopia@bugs.koha-community.org Bug 11106, bug 8989, bug 11105 add an id for facets. It should be similar for staff and opac (prog and bootstrap). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11312 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11312 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11105 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11312 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11312 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11312 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 23191 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23191&action=edit Bug 11312: Facets should be selectable using an id [staff] Test plan: launch a search and verify all facet headers have an id. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11312 --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 23192 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23192&action=edit Bug 11312: Facets should be selectable using an id [opac-prog] -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11312 --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 23193 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23193&action=edit Bug 11312: Facets should be selectable using an id [opac-bootstrap] -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11312 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11106 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11312 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |francescalamoore@gmail.com --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- *** Bug 11538 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11312 --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- *** Bug 11546 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11312 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23191|0 |1 is obsolete| | Attachment #23192|0 |1 is obsolete| | Attachment #23193|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 24287 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24287&action=edit Bug 11312: Facets should be selectable using an id [staff] Test plan: launch a search and verify all facet headers have an id. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11312 --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 24288 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24288&action=edit Bug 11312: Facets should be selectable using an id [opac-prog] -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11312 --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 24289 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24289&action=edit Bug 11312: Facets should be selectable using an id [opac-bootstrap] -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11312 Francesca <francescalamoore@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24287|0 |1 is obsolete| | --- Comment #9 from Francesca <francescalamoore@gmail.com> --- Created attachment 24309 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24309&action=edit Bug 11312: Facets should be selectable using an id [staff] Test plan: launch a search and verify all facet headers have an id. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11312 Francesca <francescalamoore@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24309|0 |1 is obsolete| | --- Comment #10 from Francesca <francescalamoore@gmail.com> --- Created attachment 24310 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24310&action=edit signed-off Bug 11312: Facets should be selectable using an id [staff] Test plan: launch a search and verify all facet headers have an id. Signed-off-by: Francesca Moore <francescalamoore@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11312 Francesca <francescalamoore@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24288|0 |1 is obsolete| | --- Comment #11 from Francesca <francescalamoore@gmail.com> --- Created attachment 24311 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24311&action=edit signed-off Bug 11312: Facets should be selectable using an id [opac-prog] Signed-off-by: Francesca Moore <francescalamoore@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11312 Francesca <francescalamoore@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24289|0 |1 is obsolete| | --- Comment #12 from Francesca <francescalamoore@gmail.com> --- Created attachment 24312 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24312&action=edit signed-off Bug 11312: Facets should be selectable using an id [opac-bootstrap] Signed-off-by: Francesca Moore <francescalamoore@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11312 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11312 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24310|0 |1 is obsolete| | Attachment #24311|0 |1 is obsolete| | Attachment #24312|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 24377 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24377&action=edit Bug 11312: Facets should be selectable using an id [staff] Test plan: launch a search and verify all facet headers have an id. Signed-off-by: Francesca Moore <francescalamoore@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11312 --- Comment #14 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 24378 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24378&action=edit Bug 11312: Facets should be selectable using an id [opac-prog] Signed-off-by: Francesca Moore <francescalamoore@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11312 --- Comment #15 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 24379 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24379&action=edit Bug 11312: facets labels are not css selectable -- opac-bootstrap To test: 1. search in OPAC directory 2. inspect the facets, note that they now have spans Signed-off-by: David Cook <dcook@prosentient.com.au> Works as described. I'm not sure that this change is necessary, since the parent li elements have IDs that can be hooked onto for CSS, but it doesn't change existing behaviour and more control is always nice, so that's all right. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11312 --- Comment #16 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 24380 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24380&action=edit Bug 11312: Facets should be selectable using an id [opac-bootstrap] Signed-off-by: Francesca Moore <francescalamoore@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11312 --- Comment #17 from Jonathan Druart <jonathan.druart@biblibre.com> --- I added the Francesca's patch (from bug 11546). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11312 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24380|0 |1 is obsolete| | CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11312 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I tested and saw some small issues that could be fixed in a follow up. As we don't have bootstrap in 3.12 the boostrap follow up would be best as a separate patch. INTRANET & PROG OPAC The span for the author facet is not closing correctly: +[% IF facets_loo.type_label_Authors %]<span id="facet-authors"Authors</span>[% END %] Also it would be nice, if all use were following the same naming schema. Most ids use a minus, but we have 2 using an underscore instead. BOOTSTRAP The HTML structure here is a bit different than for the other 2 themes. The patch adds a span inside a h5 tag. It would be cleaner, if we changed it, so the h5 tag has the id. In order to do that the <h5> before and the </h5> after the facet block can be deleted and the span has to be changed to h5. The result would look someting like this: [% IF ( facets_loo.type_label_Topics ) %]<h5 id="facets-Topics">Topics</h5>[% END %] We could also standardize the naming scheme a bit more, by using all lowercase ids. This way it would be the same ids for all 3 templates. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11312 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24377|0 |1 is obsolete| | Attachment #24378|0 |1 is obsolete| | Attachment #24379|0 |1 is obsolete| | --- Comment #19 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 24445 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24445&action=edit Bug 11312: Facets should be selectable using an id [staff] Test plan: launch a search and verify all facet headers have an id. Signed-off-by: Francesca Moore <francescalamoore@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11312 --- Comment #20 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 24446 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24446&action=edit Bug 11312: Facets should be selectable using an id [opac-prog] Signed-off-by: Francesca Moore <francescalamoore@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11312 --- Comment #21 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 24447 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24447&action=edit Bug 11312: facets labels are not css selectable -- opac-bootstrap To test: 1. search in OPAC directory 2. inspect the facets, note that they now have spans Signed-off-by: David Cook <dcook@prosentient.com.au> Works as described. I'm not sure that this change is necessary, since the parent li elements have IDs that can be hooked onto for CSS, but it doesn't change existing behaviour and more control is always nice, so that's all right. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11312 --- Comment #22 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 24448 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24448&action=edit Bug 11312: Facets should be selectable using an id [opac-bootstrap] Signed-off-by: Francesca Moore <francescalamoore@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11312 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #23 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Katrin Fischer from comment #18)
INTRANET & PROG OPAC The span for the author facet is not closing correctly
Hum... (/me is hidden)
Also it would be nice, if all use were following the same naming schema. Most ids use a minus, but we have 2 using an underscore instead.
Yes of course! I don't know what I did...
BOOTSTRAP The HTML structure here is a bit different than for the other 2 themes. The patch adds a span inside a h5 tag. It would be cleaner, if we changed it, so the h5 tag has the id. In order to do that the <h5> before and the </h5> after the facet block can be deleted and the span has to be changed to h5. The result would look someting like this:
[% IF ( facets_loo.type_label_Topics ) %]<h5 id="facets-Topics">Topics</h5>[% END %]
We could also standardize the naming scheme a bit more, by using all lowercase ids. This way it would be the same ids for all 3 templates.
In fact I forgot to re-upload a patch for the bootstrap theme. It is why the code was completely different. I replaced the span with h5. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11312 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24445|0 |1 is obsolete| | Attachment #24446|0 |1 is obsolete| | Attachment #24447|0 |1 is obsolete| | Attachment #24448|0 |1 is obsolete| | --- Comment #24 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24531 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24531&action=edit Bug 11312: Facets should be selectable using an id [staff] Test plan: launch a search and verify all facet headers have an id. Signed-off-by: Francesca Moore <francescalamoore@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11312 --- Comment #25 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24532 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24532&action=edit Bug 11312: Facets should be selectable using an id [opac-prog] Signed-off-by: Francesca Moore <francescalamoore@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11312 --- Comment #26 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24533 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24533&action=edit Bug 11312: facets labels are not css selectable -- opac-bootstrap To test: 1. search in OPAC directory 2. inspect the facets, note that they now have spans Signed-off-by: David Cook <dcook@prosentient.com.au> Works as described. I'm not sure that this change is necessary, since the parent li elements have IDs that can be hooked onto for CSS, but it doesn't change existing behaviour and more control is always nice, so that's all right. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11312 --- Comment #27 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24534 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24534&action=edit Bug 11312: Facets should be selectable using an id [opac-bootstrap] Signed-off-by: Francesca Moore <francescalamoore@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11312 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11312 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #28 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Francesca and Jonathan! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org