http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11312 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #23 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Katrin Fischer from comment #18)
INTRANET & PROG OPAC The span for the author facet is not closing correctly
Hum... (/me is hidden)
Also it would be nice, if all use were following the same naming schema. Most ids use a minus, but we have 2 using an underscore instead.
Yes of course! I don't know what I did...
BOOTSTRAP The HTML structure here is a bit different than for the other 2 themes. The patch adds a span inside a h5 tag. It would be cleaner, if we changed it, so the h5 tag has the id. In order to do that the <h5> before and the </h5> after the facet block can be deleted and the span has to be changed to h5. The result would look someting like this:
[% IF ( facets_loo.type_label_Topics ) %]<h5 id="facets-Topics">Topics</h5>[% END %]
We could also standardize the naming scheme a bit more, by using all lowercase ids. This way it would be the same ids for all 3 templates.
In fact I forgot to re-upload a patch for the bootstrap theme. It is why the code was completely different. I replaced the span with h5. -- You are receiving this mail because: You are watching all bug changes.