[Bug 16726] New: Text in Preferences search box does not clear
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16726 Bug ID: 16726 Summary: Text in Preferences search box does not clear Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: arm@hanover.ca QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com When in Administration - Preferences, using search box. Enter search term, hit enter or click button to search. After search completes, the search box still shows the search text. Once a search is done, the search box should clear as it does for checkout, catalogue, patron searches etc. (Note that this is more annoying now that the search text also persists when switching to a different tab, like from Preferences to Checkout.) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16726 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, I am not sure I agree. For example when you do a simple search in the OPAC we also keep the search term showing, as it allows you to check what you searched for and change your search if nothing was found etc. I like that feature of the system preference editor - as I can spot a typo that might have caused me finding nothing. If this was to be removed, it might be nice to show what was searched for in another way. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16726 --- Comment #2 from Agnes Rivers-Moore <arm@hanover.ca> --- The system already does tell you what you searched for if there are no results in preferences. It says "No system preferences matched your search for: peter" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16726 --- Comment #3 from Agnes Rivers-Moore <arm@hanover.ca> --- The behaviour of the preferences search box is not consistent with all the other search functions in the staff interface. They keep the text while you switch between tabs only before the search is run. I think it is unlikely that staff using Preferences would want to run the same search they have completed in any of the other functions. That's just my opinion; other folks can decide whether this warrants any effort or not, now you know it exists. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16726 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Good points. I think I agree now :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16726 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Note that you can use JS code to clean the search box. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16726 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16726 --- Comment #6 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 62340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62340&action=edit Bug 16726: Clear text in syspref searchbox after submitting To test: 1) Go to Admin -> search for a system preference 2) Notice your search stays in the search box (this is inconsistent with search behaviour across Koha) 3) Apply patch and refresh page 4) Make another search 5) Confirm search still works as expected and search terms have been cleared from search box Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16726 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |aleisha@catalyst.net.nz |ity.org | Change sponsored?|--- |Sponsored CC| |aleisha@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16726 dilan@calyx.net.au changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62340|0 |1 is obsolete| | --- Comment #7 from dilan@calyx.net.au --- Created attachment 62352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62352&action=edit Bug 16726: Clear text in syspref searchbox after submitting To test: 1) Go to Admin -> search for a system preference 2) Notice your search stays in the search box (this is inconsistent with search behaviour across Koha) 3) Apply patch and refresh page 4) Make another search 5) Confirm search still works as expected and search terms have been cleared from search box Sponsored-by: Catalyst IT Signed-off-by: Dilan Johnpulle <dilan@calyx.net.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16726 dilan@calyx.net.au changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dilan@calyx.net.au --- Comment #8 from dilan@calyx.net.au --- Works as intended and no issues were encountered when applying the patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16726 dilan@calyx.net.au changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #9 from dilan@calyx.net.au --- Signed-off-by: Dilan Johnpulle <dilan@calyx.net.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16726 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Aleisha, I talked about JS code previously to tell people that without any patches it is possible to clean the box easily. But if we want to do it with a patch we can do it by removing the value of the input (in prefs-admin-search.inc). We may want to add something on the screen to tell the user on what we search for. I'd like to get opinions on that, Owen maybe? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16726 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Jonathan Druart from comment #10) I agree that it is inconsistent that the preference search leaves the search term in the search box.
We may want to add something on the screen to tell the user on what we search for.
I agree. I think this patch should include that as well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16726 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16726 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62352|0 |1 is obsolete| | --- Comment #12 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 64072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64072&action=edit Bug 16726: Clear text in syspref searchbox after submitting To test: 1) Go to Admin -> search for a system preference 2) Notice your search stays in the search box (this is inconsistent with search behaviour across Koha) 3) Apply patch and refresh page 4) Make another search 5) Confirm search still works as expected and search terms have been cleared from search box 6) Confirm search terms show at the top of the results Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16726 --- Comment #13 from Owen Leonard <oleonard@myacpl.org> --- I think the "you searched for" text should be in a <h1></h1>. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16726 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16726 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16726 --- Comment #14 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 64668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64668&action=edit Bug 16726: Putting text in h1 See Comment 13 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16726 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16726 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64668|0 |1 is obsolete| | --- Comment #15 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 64669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64669&action=edit Bug 16726: [FOLLOW-UP] Putting text in h1 See Comment 13 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16726 Dilan Johnpullé <dilan@calyx.net.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16726 Dilan Johnpullé <dilan@calyx.net.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64669|0 |1 is obsolete| | --- Comment #16 from Dilan Johnpullé <dilan@calyx.net.au> --- Created attachment 64876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64876&action=edit Bug 16726: [FOLLOW-UP] Putting text in h1 Works as outlined in test plan, search terms now appear at top as h1 as well Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16726 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #17 from Nick Clemens <nick@bywatersolutions.com> --- This works fine for me, but the h1 looks too large, it is confusing with the results. h3 is more consistent, but that is styled as expand/collapse on this page. How about below: <div class="dialog">You searched for: <strong>[% searchfield | html %]</strong></div> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16726 --- Comment #18 from Owen Leonard <oleonard@myacpl.org> --- I would prefer the heading to follow the format of catalog search results, "X result(s) found for 'term'" If that's not possible I think this patch is fine. I don't think the message dialog is the right solution. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16726 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16726 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16726 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64072|0 |1 is obsolete| | Attachment #64876|0 |1 is obsolete| | --- Comment #19 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 66699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66699&action=edit Bug 16726: Clear text in syspref searchbox after submitting To test: 1) Go to Admin -> search for a system preference 2) Notice your search stays in the search box (this is inconsistent with search behaviour across Koha) 3) Apply patch and refresh page 4) Make another search 5) Confirm search still works as expected and search terms have been cleared from search box 6) Confirm search terms show at the top of the results Sponsored-by: Catalyst IT Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16726 --- Comment #20 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 66700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66700&action=edit Bug 16726: [FOLLOW-UP] Putting text in h1 Works as outlined in test plan, search terms now appear at top as h1 as well Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16726 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #21 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- It does not look good to me: https://pageshot.net/kN7OYETHoEC4WTSQ/pro.kohadev.org Does someone has something else to suggest? Maybe we should style a bit h1, or h2? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16726 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA --- Comment #22 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- 11:57 < Joubu> does it look good for you? 11:58 < oleonard> Yes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16726 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #23 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16726 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #24 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Ah, when showing a preferences tab, the text still appears : "You searched for: " I think one should check if "searchfield" is defined. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16726 --- Comment #25 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 67551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67551&action=edit Bug 16726: Do not display "You searched for:" if not needed Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16726 --- Comment #26 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Fridolin SOMERS from comment #24)
Ah, when showing a preferences tab, the text still appears : "You searched for: " I think one should check if "searchfield" is defined.
Good catch, last patch pushed to master! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16726 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #27 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x, will be in 17.05.06. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16726 --- Comment #28 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- These patches have been pushed to 16.11.x and will be in 16.11.14. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16726 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #29 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.19 release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org