[Bug 36966] New: Fix links for local cover images for items on staff detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36966 Bug ID: 36966 Summary: Fix links for local cover images for items on staff detail page Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com The links for local cover images aren't built correctly on the detail page of the staff interface While it doesn't cause a problem on current "main", any development that sets the "item" variable in the template at a higher level will generate fatal errors. Owen has bumped into this in his Bootstrap 5 work. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36966 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- (Btw as I fix this... I think I notice we're still using & to separate query parameters in URLs when we should be using &. It's a reserved character for that purpose.) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36966 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28180 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36966 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|28180 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36966 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28179 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28179 [Bug 28179] Use a lightbox gallery to display the images - detail page, staff interface -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36966 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36966 --- Comment #2 from David Cook <dcook@prosentient.com.au> --- Created attachment 167187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167187&action=edit Bug 36966: Fix local cover image links for items This change fixes the local cover image links for items by removing unnecessary parameters, an invalid link, and an uninitialised Template::Toolkit variable. Test plan: 0. Apply patch 1. Enable syspref 'LocalCoverImages' 3. Go to http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=29 4. Click on the dropdown next to "Edit" at the item level 5. Upload an image for the item 6. Note that the local cover image appears in the holdings table 7. Click on the image and note that it loads in the light box 8. Success! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36966 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Should this data-link attr removed from other places? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36966 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36966 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167187|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 167195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167195&action=edit Bug 36966: Fix local cover image links for items This change fixes the local cover image links for items by removing unnecessary parameters, an invalid link, and an uninitialised Template::Toolkit variable. Test plan: 0. Apply patch 1. Enable syspref 'LocalCoverImages' 3. Go to http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=29 4. Click on the dropdown next to "Edit" at the item level 5. Upload an image for the item 6. Note that the local cover image appears in the holdings table 7. Click on the image and note that it loads in the light box 8. Success! Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36966 --- Comment #5 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #3)
Should this data-link attr removed from other places?
Actually, I think I shouldn't have removed it here. I couldn't see anywhere it was used, but looking again today I can see that at the very bottom of light box page it should say "Local cover image (edit)" and that has a link to the editor. I do have a way of making that work. I'll take a look... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36966 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #6 from David Cook <dcook@prosentient.com.au> --- Yeah nah I definitely broke it in a different way.. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36966 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36966 --- Comment #7 from David Cook <dcook@prosentient.com.au> --- Created attachment 167236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167236&action=edit Bug 36966: Fix data-link for local cover images This patch fixes the data-link so that the "edit" link at the bottom of the lightbox viewer correctly takes the user to the editor interface for the local cover image -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36966 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36966 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167195|0 |1 is obsolete| | --- Comment #8 from David Nind <david@davidnind.com> --- Created attachment 167254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167254&action=edit Bug 36966: Fix local cover image links for items This change fixes the local cover image links for items by removing unnecessary parameters, an invalid link, and an uninitialised Template::Toolkit variable. Test plan: 0. Apply patch 1. Enable syspref 'LocalCoverImages' 3. Go to http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=29 4. Click on the dropdown next to "Edit" at the item level 5. Upload an image for the item 6. Note that the local cover image appears in the holdings table 7. Click on the image and note that it loads in the light box 8. Success! Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36966 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167236|0 |1 is obsolete| | --- Comment #9 from David Nind <david@davidnind.com> --- Created attachment 167255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167255&action=edit Bug 36966: Fix data-link for local cover images This patch fixes the data-link so that the "edit" link at the bottom of the lightbox viewer correctly takes the user to the editor interface for the local cover image Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36966 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #10 from David Nind <david@davidnind.com> --- I think this works... but it seems the only way to replace the item-level image is via Edit > Upload image. Before patch applied: 0. Enable LocalCoverImages system preference 1. Upload a record-level image: 1.1 Upload a record-level image: Images tab > Upload 1.2 Upload an item-level image: Holding stab > Edit > Upload image > [use a different image from the record-level one) ==> Result: Different record-level and item-level images 2. Replace the item-level image (Edit > Upload image): 2.1 Replace the item-level cover image: Holdings tab > Edit > Upload image > [use a different image from the record-level image] ==> Result: item-level image replaced (as expected) 3. Replace the item-level image (click on cover image in holdings table): 3.1 Attempt to replace the item-level image: click on the item-level cover under the cover image column > click edit in the light-box viewer > get error trace: Can't call method "biblionumber" on an undefined value at /kohadevbox/koha/catalogue/imageviewer.pl line 42 After the patches are applied: 1. Repeat 3.1: displays all existing images (record and item-level images), and can "Drop files here or click to select a file". Drag and drop a replacement image: ==> Result: . Record-level image replaced . For search results, item-level image displayed Hope I haven't confused things! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36966 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #11 from David Cook <dcook@prosentient.com.au> --- (In reply to David Nind from comment #10)
Hope I haven't confused things!
Nah, I think it's a good catch. I think I've just confused myself a bit previously. Too much multitasking... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36966 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36966 --- Comment #12 from David Cook <dcook@prosentient.com.au> --- Created attachment 167259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167259&action=edit Bug 36966: Actually fix data-link for local cover images -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36966 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |dcook@prosentient.com.au |ity.org | --- Comment #13 from David Cook <dcook@prosentient.com.au> --- Ok... "now" it should work haha. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36966 --- Comment #14 from David Nind <david@davidnind.com> --- (In reply to David Cook from comment #13)
Ok... "now" it should work haha.
Thanks David. Sign off on the way. Thinks I learnt with this big, you can have item-level cover images. David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36966 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36966 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167254|0 |1 is obsolete| | --- Comment #15 from David Nind <david@davidnind.com> --- Created attachment 167263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167263&action=edit Bug 36966: Fix local cover image links for items This change fixes the local cover image links for items by removing unnecessary parameters, an invalid link, and an uninitialised Template::Toolkit variable. Test plan: 0. Apply patch 1. Enable syspref 'LocalCoverImages' 3. Go to http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=29 4. Click on the dropdown next to "Edit" at the item level 5. Upload an image for the item 6. Note that the local cover image appears in the holdings table 7. Click on the image and note that it loads in the light box 8. Success! Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36966 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167255|0 |1 is obsolete| | --- Comment #16 from David Nind <david@davidnind.com> --- Created attachment 167264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167264&action=edit Bug 36966: Fix data-link for local cover images This patch fixes the data-link so that the "edit" link at the bottom of the lightbox viewer correctly takes the user to the editor interface for the local cover image Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36966 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167259|0 |1 is obsolete| | --- Comment #17 from David Nind <david@davidnind.com> --- Created attachment 167265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167265&action=edit Bug 36966: Actually fix data-link for local cover images Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36966 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36966 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167263|0 |1 is obsolete| | Attachment #167264|0 |1 is obsolete| | Attachment #167265|0 |1 is obsolete| | --- Comment #18 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 168090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168090&action=edit Bug 36966: Fix local cover image links for items This change fixes the local cover image links for items by removing unnecessary parameters, an invalid link, and an uninitialised Template::Toolkit variable. Test plan: 0. Apply patch 1. Enable syspref 'LocalCoverImages' 3. Go to http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=29 4. Click on the dropdown next to "Edit" at the item level 5. Upload an image for the item 6. Note that the local cover image appears in the holdings table 7. Click on the image and note that it loads in the light box 8. Success! Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36966 --- Comment #19 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 168091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168091&action=edit Bug 36966: Fix data-link for local cover images This patch fixes the data-link so that the "edit" link at the bottom of the lightbox viewer correctly takes the user to the editor interface for the local cover image Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36966 --- Comment #20 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 168092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168092&action=edit Bug 36966: Actually fix data-link for local cover images Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36966 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36966 --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36966 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to main |Pushed to stable Version(s)|24.11.00 |24.11.00,24.05.02 released in| | --- Comment #22 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36966 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #23 from Fridolin Somers <fridolin.somers@biblibre.com> --- Does not apply on 23.11.x Looks like this depends on Bug 33568 right ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36966 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the local cover release notes| |image links for items | |(staff interface record | |details holdings table > | |dropdown link for Edit > | |Upload image) by removing | |unnecessary parameters, | |fixing an invalid link, an | |uninitialised | |Template::Toolkit variable. | |This has no noticeable | |effect, but is important | |for avoiding future issues. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36966 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org