https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37002 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 167310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167310&action=edit Bug 37002: Correct several HTML markup errors This patch makes several minor corrections to HTML markup in the bibliographic detail page template and related include files. This corrects the following validator errors: - Stray end tag a. - Bad value true for attribute disabled on element select. - Bad value true for attribute disabled on element input. - No space between attributes. - Duplicate attribute class. - The value of the for attribute of the label element must be the ID of a non-hidden form control. The patch is simple enough that an inspection of the patch is probably enough, but following is a detailed test plan of the affected areas: - Apply the patch and view the bibliographic detail page in the staff interface. - Under the "Edit" menu in the toolbar, these options should still work correctly: - Modify record using template - Edit items in a batch - Delete items in a batch - Click the "Items" link in the sidebar and find the "Bookable" setting for the title's items. Make at least one item bookable and return to the detail page. - Click the "Place booking" button in the toolbar and confirm that you can successfully place the booking. - If you have access to Novelist, confirm that Novelist content displays correctly on the detail page. - Turn on the "EnableItemGroups" preference. - On the detail page, open the "Item groups" tab and click the "New item group" button. - In the modal, the "Name" and "Display order" labels give focus to the corresponding form field when clicked. - Create an item group. - Under the holdings tab, select one or more items and click "Add/move to item group". - In the modal, clicking the "Item group" label should give focus to the dropdown. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37002 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167310|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 167316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167316&action=edit Bug 37002: Correct several HTML markup errors This patch makes several minor corrections to HTML markup in the bibliographic detail page template and related include files. This corrects the following validator errors: - Stray end tag a. - Bad value true for attribute disabled on element select. - Bad value true for attribute disabled on element input. - No space between attributes. - Duplicate attribute class. - The value of the for attribute of the label element must be the ID of a non-hidden form control. The patch is simple enough that an inspection of the patch is probably enough, but following is a detailed test plan of the affected areas: - Apply the patch and view the bibliographic detail page in the staff interface. - Under the "Edit" menu in the toolbar, these options should still work correctly: - Modify record using template - Edit items in a batch - Delete items in a batch - Click the "Items" link in the sidebar and find the "Bookable" setting for the title's items. Make at least one item bookable and return to the detail page. - Click the "Place booking" button in the toolbar and confirm that you can successfully place the booking. - If you have access to Novelist, confirm that Novelist content displays correctly on the detail page. - Turn on the "EnableItemGroups" preference. - On the detail page, open the "Item groups" tab and click the "New item group" button. - In the modal, the "Name" and "Display order" labels give focus to the corresponding form field when clicked. - Create an item group. - Under the holdings tab, select one or more items and click "Add/move to item group". - In the modal, clicking the "Item group" label should give focus to the dropdown. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37002 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop@ptfs-europe | |.com --- Comment #4 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Lucas did you mean to do a second sign off or was it supposed to be a PQA? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37002 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37002 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37002 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixes several minor release notes| |HTML markup validation | |errors for the | |bibliographic detail page | |in the staff interface. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37002 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.