[Bug 37722] New: Add Koha Objects for Koha Holidays
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37722 Bug ID: 37722 Summary: Add Koha Objects for Koha Holidays Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37722 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37722 --- Comment #1 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 170688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170688&action=edit Bug 37722: Add KOha Objects for Koha Holidays These patches add objects for special and repeating holidays To test: prove -v t/db_dependent/Koha/Holidays/ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37722 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | CC| |phil@chetcolibrary.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37722 Olivier V <ovezina@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170688|0 |1 is obsolete| | --- Comment #2 from Olivier V <ovezina@inlibro.com> --- Created attachment 171995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171995&action=edit Bug 37722: Add KOha Objects for Koha Holidays These patches add objects for special and repeating holidays To test: prove -v t/db_dependent/Koha/Holidays/ Signed-off-by: Olivier V <olivier.vezina@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37722 Olivier V <ovezina@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ovezina@inlibro.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37722 --- Comment #3 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 173188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173188&action=edit Bug 37722: (QA follow-up): fix copyright header -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37722 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Status|Signed Off |Failed QA QA Contact|testopia@bugs.koha-communit |victor@tuxayo.net |y.org | --- Comment #4 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Looks like dead code: ``` use Koha::Database; ``` In Koha/Holidays/RepeatingHoliday.pm Koha/Holidays/RepeatingHolidays.pm Koha/Holidays/SpecialHoliday.pm Koha/Holidays/SpecialHolidays.pm --------- Any reason to switch from RepeatableHoliday (based on table name) to RepeatingHoliday? --------- commit title Bug 37722: Add KOha Objects for Koha Holidays Is a variation of the last case there: «Depending on the situation, it might be written "koha" or "Koha" or maybe even "KOHA". Writing "kOha" just means you got the shifting out of sync, though.» 😝😝😝 https://bugs.koha-community.org/bugzilla3/quips.cgi?action=show ----- All looks good otherwise :) -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org