[Bug 30611] New: Add ability to send passwordreseturl in the Welcome email
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30611 Bug ID: 30611 Summary: Add ability to send passwordreseturl in the Welcome email Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com With the removal of the ability to include the plaintext password in the acctdetails, now welcome, notice it would be great to give patrons another option for setting their login details. We have the ability to reset forgotten passwords from the OPAC using a limited time token embedded in a URL. It would be great to have the same option in the WELCOME notice. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30611 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |9097 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9097 [Bug 9097] Add option to trigger 'Welcome mail' manually -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30611 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Should this be part of the 'WELCOME' notice, or should it be it's own notice entirely which can be triggered independently from the various places the welcome notice can be triggered? Perhaps it could be an optional part of the welcome notice that is picked at the trigger time? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30611 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30611 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think maybe it would make sense to have an option to trigger the password reset email manually instead. The validity of the password reset URLs is limited, so it might be better to point people to the feature itself, maybe by including a direct link to the password request form. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30611 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30611 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add ability to send |Add ability to send |passwordreseturl in the |passwordreseturl from the |Welcome email |staff client -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30611 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|9097 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9097 [Bug 9097] Add option to trigger 'Welcome mail' manually -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30611 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134357&action=edit Bug 30611: Add STAFF_PASSWORD_RESET notice This patch adds a new STAFF_PASSWORD_RESET notice template for password recoveries initiated via the staff client as aposed for those initiated by the end user. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30611 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134358&action=edit Bug 30611: Add ability for staff to send password reset emails This patch adds the ability for staff with the edit_borrowers permission to send password reset emails to users. The staff initiated password reset has it's own notice, STAFF_PASSWORD_RESET, and the reset link produced has an extended timeout of 5 days, as apposed to the usual 2 day limit. Test plan 1) Apply patch and run the database update 2) Login to the staff client with a user who has the 'edit_borrowers' permission. 3) Note that a new, 'Send password reset' option appears under the 'More' menu on the patron details page. 4) Clicking the button will queue the STAFF_PASSWORD_RESET notice and redirect the user to the Notices tab. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30611 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30611 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27812 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30611 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29925 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30611 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=9097 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30611 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I think this should perhaps target 22.05 as it adds back in an alternative to the functionality lost with bug 27812. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30611 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134357|0 |1 is obsolete| | --- Comment #6 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 134378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134378&action=edit Bug 30611: Add STAFF_PASSWORD_RESET notice This patch adds a new STAFF_PASSWORD_RESET notice template for password recoveries initiated via the staff client as aposed for those initiated by the end user. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30611 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134358|0 |1 is obsolete| | --- Comment #7 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 134379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134379&action=edit Bug 30611: Add ability for staff to send password reset emails This patch adds the ability for staff with the edit_borrowers permission to send password reset emails to users. The staff initiated password reset has it's own notice, STAFF_PASSWORD_RESET, and the reset link produced has an extended timeout of 5 days, as apposed to the usual 2 day limit. Test plan 1) Apply patch and run the database update 2) Login to the staff client with a user who has the 'edit_borrowers' permission. 3) Note that a new, 'Send password reset' option appears under the 'More' menu on the patron details page. 4) Clicking the button will queue the STAFF_PASSWORD_RESET notice and redirect the user to the Notices tab. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30611 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #8 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- Works brilliantly, thanks Martin. This is a great feature - saves me from having to load the OPAC repeatedly throughout the day. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30611 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27812 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27812 [Bug 27812] Remove the ability to transmit a patron's plain text password over email -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30611 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30611 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- QAing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30611 --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- + my $days = $staff ? 5 : 2; No blocker. But these should at least be constants, but probably pref or config controlled. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30611 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Failed QA --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- I think we should check at least pref OpacResetPassword to make the link we are sending to be working. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30611 --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Good call.. I had completely overlooked that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30611 --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134719&action=edit Bug 30611: (QA follow-up) Only show reset option for allowed categories This patch adds a check that the patron can reach the password reset page using category.effective_reset_password which handles fallback to OpacResetPassword system preference transparently. Test plan 1) Set at least one patron category to dissallow patron password resets 2) Search for a patron of that category 3) Confirm the 'Send password reset' option no longer appears -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30611 --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134720&action=edit Bug 30611: (follow-up) Use constants Update ternary for token timeout to use perl constants -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30611 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30611 --- Comment #15 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Another victim of Attempt to reload Koha/Template/Plugin/Branches.pm aborted. Ignoring it :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30611 --- Comment #16 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Always linked to includes btw -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30611 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30611 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134378|0 |1 is obsolete| | --- Comment #17 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 134774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134774&action=edit Bug 30611: Add STAFF_PASSWORD_RESET notice This patch adds a new STAFF_PASSWORD_RESET notice template for password recoveries initiated via the staff client as aposed for those initiated by the end user. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Chmod 755 on atomic update file. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30611 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134379|0 |1 is obsolete| | --- Comment #18 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 134775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134775&action=edit Bug 30611: Add ability for staff to send password reset emails This patch adds the ability for staff with the edit_borrowers permission to send password reset emails to users. The staff initiated password reset has it's own notice, STAFF_PASSWORD_RESET, and the reset link produced has an extended timeout of 5 days, as apposed to the usual 2 day limit. Test plan 1) Apply patch and run the database update 2) Login to the staff client with a user who has the 'edit_borrowers' permission. 3) Note that a new, 'Send password reset' option appears under the 'More' menu on the patron details page. 4) Clicking the button will queue the STAFF_PASSWORD_RESET notice and redirect the user to the Notices tab. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30611 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134719|0 |1 is obsolete| | --- Comment #19 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 134776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134776&action=edit Bug 30611: (QA follow-up) Only show reset option for allowed categories This patch adds a check that the patron can reach the password reset page using category.effective_reset_password which handles fallback to OpacResetPassword system preference transparently. Test plan 1) Set at least one patron category to dissallow patron password resets 2) Search for a patron of that category 3) Confirm the 'Send password reset' option no longer appears Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30611 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134720|0 |1 is obsolete| | --- Comment #20 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 134777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134777&action=edit Bug 30611: (follow-up) Use constants Update ternary for token timeout to use perl constants Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30611 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add ability to send |Add ability to trigger a |passwordreseturl from the |patron password reset from |staff client |the staff client -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30611 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds a release notes| |button to the patron | |details page in the client | |to allow librarians, with | |appropriate permissions, to | |trigger a password reset | |for patrons. | | | |The result is | |a notice sent to the user | |with a fresh password reset | |link allowing the user to | |enter a new password for | |their account. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30611 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30611 --- Comment #21 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30611 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30611 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #22 from Fridolin Somers <fridolin.somers@biblibre.com> --- Arf this breaks unit test : kohadev-koha@kohadevbox:/kohadevbox/koha$ prove xt/sample_notices.t xt/sample_notices.t .. 1/? # Failed test 'No sample notice to add' # at xt/sample_notices.t line 84. # Sample notices to add in fr-FR/1-Obligatoire/sample_notices.sql: STAFF_PASSWORD_RESET # Looks like you failed 1 test of 6. Note there is Bug 27619 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30611 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30611 --- Comment #23 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- On it.. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30611 --- Comment #24 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Ah yes, I think I kind of assumed bug 27619 would be in before this one.. I was happy to wait. It's easy to fix this by adding the sample notice to the fr SQL.. but maybe it's more pertinent for me to QA 27619 to get that in? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30611 --- Comment #25 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Martin Renvoize from comment #24)
Ah yes, I think I kind of assumed bug 27619 would be in before this one.. I was happy to wait.
It's easy to fix this by adding the sample notice to the fr SQL.. but maybe it's more pertinent for me to QA 27619 to get that in?
I prefer a quick fix on sample notices to the fr in order to calm jenkins -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30611 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #26 from Fridolin Somers <fridolin.somers@biblibre.com> --- In the end, bug 27619 was pushed. All good here. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org