[Bug 30695] New: Checkouts and holds count display in tab could be better in patron details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30695 Bug ID: 30695 Summary: Checkouts and holds count display in tab could be better in patron details Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org When you look at a biblio's detail you see | Holdings (count) | Descriptions (count) | ... The patron detail page displays things in a way that looks untidy and inconsistent with other areas. | count Checkout(s) | count Hold(s) | ... This is highly opinionated, but I propose we make it consistent with the biblios one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30695 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |tomascohen@gmail.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30695 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- See also Bug 26979 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30695 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30695 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 134650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134650&action=edit Bug 30695: Display tabs more consistently in patron details This patch makes tab texts display 'Thing (count)' as opossed to the current mix we have. To test, check before after the patch how it looks. You need to: - Enable ArticleRequests - Set ClaimReturnedLostValue to 1 (for example) - Have some clubs set -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30695 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- There's still some inconsistency on how we display Claims and Clubs. But that could belong to some other bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30695 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30695 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134650|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 134657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134657&action=edit Bug 30695: Display tabs more consistently in patron details This patch makes tab texts display 'Thing (count)' as opossed to the current mix we have. To test, check before after the patch how it looks. You need to: - Enable ArticleRequests - Set ClaimReturnedLostValue to 1 (for example) - Have some clubs set Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30695 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26979 CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30695 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134657|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134721&action=edit Bug 30695: Display tabs more consistently in patron details This patch makes tab texts display 'Thing (count)' as opossed to the current mix we have. To test, check before after the patch how it looks. You need to: - Enable ArticleRequests - Set ClaimReturnedLostValue to 1 (for example) - Have some clubs set Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30695 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134722&action=edit Bug 30695: (QA follow-up) Catch moremember.tt too This patch does the same treatment for moremember.tt where the same summary block is includes. We also correct the tab order to be a little more consistent too. We should really move this to an include and refer to it from both templates instead of this copy/paste code.. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30695 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This is a marked improvement.. I will revisit the see also now to see how they relate. Passing QA on this one though. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30695 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30695 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Patch complexity|String patch |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30695 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Small patch |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30695 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30695 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30695 --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30695 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- This breaks a Selenium test : kohadev-koha@kohadevbox:/kohadevbox/koha$ prove t/db_dependent/selenium/basic_workflow.t t/db_dependent/selenium/basic_workflow.t .. 1/22 CP main = 0.82 t/db_dependent/selenium/basic_workflow.t .. 3/22 CP add patron category = 2.00 t/db_dependent/selenium/basic_workflow.t .. 5/22 CP add patron = 1.66 CP add biblio = 0.08 t/db_dependent/selenium/basic_workflow.t .. 11/22 CP add items = 3.94 t/db_dependent/selenium/basic_workflow.t .. 12/22 # Failed test at t/db_dependent/selenium/basic_workflow.t line 238. # got: 'Checkouts (1)' # expected: '1 Checkout(s)' t/db_dependent/selenium/basic_workflow.t .. 14/22 # Failed test at t/db_dependent/selenium/basic_workflow.t line 238. # got: 'Checkouts (2)' # expected: '2 Checkout(s)' t/db_dependent/selenium/basic_workflow.t .. 16/22 # Failed test at t/db_dependent/selenium/basic_workflow.t line 238. # got: 'Checkouts (3)' # expected: '3 Checkout(s)' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30695 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 135053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135053&action=edit Bug 30695: (follow-up) Fix selenium test The tab title words were re-ordered and we forgot to update the corresponding selenium test. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30695 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Fix attached, tested and pushed as rm assist :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30695 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed, | |rel_22_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30695 --- Comment #12 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Martin Renvoize from comment #11)
Fix attached, tested and pushed as rm assist :)
Great thanks ;) -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org