[Bug 31123] New: Add a simple way to add 'Harmful content warnings' to catalogue records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123 Bug ID: 31123 Summary: Add a simple way to add 'Harmful content warnings' to catalogue records Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl I propose adding a new 'quick add' button into the biblio toolbar that would trigger a modal where staff can enter a short content warning note to be added to a designated 59X field (MARC21). I would then modify the default XSLTs to display the note highlighted to draw the users attention. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31028 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140345&action=edit Bug 31123: Add `ContentWarningField` preference This patch adds a new `ContentWarningField` preference allowing the library to define which 59X field to use to store harmful content warning notes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140346&action=edit Bug 31123: Display content warnings on the intranet This patch adds handling to our XSLT processing to pass the new `ContentWarningField` preference value to the stylesheets and then uses that variable to add content warning notes to both the detail and search result displays of the staff client. Test plan 1) Run the database update to expose the new system preference 2) Set `ContentWarningField` to something sensible, like `599` 3) Add the above select field to one of your frameworks with a subfield `a`. 4) Edit a record with that framework to add a content warning into the record 5) Search for the record and confirm you now see `Content warning: Your test text` 6) Click into the record detail and confirm you see the content warning text there too 7) Bonus points: Assign a new authorized value category to the chosen field and subfield and confirm the staff client display text is used in the above tests. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140347&action=edit Bug 31123: Display content warnings in OPAC This patch adds handling of content warning display to the OPAC for both detail and search result views Test plan 1) Work through the test plan for the previous patch 2) Confirm that the same text now also displays on the equivilent OPAC pages. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- OK.. so this patchset just allows for adding the designated content_warning fields to display on OPAC and Staff interfaces without having to customise your local XSLT stylesheets. The 'quick add' functionality is still a work in progress and is likely to move to it's own bug now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140345|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 140356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140356&action=edit Bug 31123: Add `ContentWarningField` preference This patch adds a new `ContentWarningField` preference allowing the library to define which 59X field to use to store harmful content warning notes. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140346|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 140357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140357&action=edit Bug 31123: Display content warnings on the intranet This patch adds handling to our XSLT processing to pass the new `ContentWarningField` preference value to the stylesheets and then uses that variable to add content warning notes to both the detail and search result displays of the staff client. Test plan 1) Run the database update to expose the new system preference 2) Set `ContentWarningField` to something sensible, like `599` 3) Add the above select field to one of your frameworks with a subfield `a`. 4) Edit a record with that framework to add a content warning into the record 5) Search for the record and confirm you now see `Content warning: Your test text` 6) Click into the record detail and confirm you see the content warning text there too 7) Bonus points: Assign a new authorized value category to the chosen field and subfield and confirm the staff client display text is used in the above tests. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140347|0 |1 is obsolete| | --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 140358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140358&action=edit Bug 31123: Display content warnings in OPAC This patch adds handling of content warning display to the OPAC for both detail and search result views Test plan 1) Work through the test plan for the previous patch 2) Confirm that the same text now also displays on the equivilent OPAC pages. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #8 from David Nind <david@davidnind.com> --- I have signed off, but noted that when using authorized values the authorized value code is displayed in the OPAC and staff interface, but not the text from the descriptions. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to David Nind from comment #8)
I have signed off, but noted that when using authorized values the authorized value code is displayed in the OPAC and staff interface, but not the text from the descriptions.
Hi Martin, could you have a look at this, before we continue here? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Interesting, I can't replicate that issue.. perhaps caching related? We don't really touch any of the AV in XSLT handling code in here, so I can't see how it would fail here but not elsewhere? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31551 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31551 [Bug 31551] Add a 'Quick add' option for harmful content warnings. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123 --- Comment #11 from David Nind <david@davidnind.com> --- (In reply to Martin Renvoize from comment #10)
Interesting, I can't replicate that issue.. perhaps caching related?
It was some sort of caching issue - apologies for the false alarm! I retested again, and then did a flush_memcached, restart_all, and cleared the browser cache - the descriptions for the authorised values now display instead of the authorised value codes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123 --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Awesome, thanks for retesting David :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |holiver@tavi-port.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Martin, I have questions :) Can you how you chose the subfields? Will this be documented somewhere, maybe in the pref? It looks like $z is displayed first, separated by a space and then followed by abcdefgijklnou, but this is not a "complete" list of subfields either. + <xsl:when test="marc:subfield[@code='z']"> + <xsl:value-of select="marc:subfield[@code='z']"/><xsl:text> </xsl:text> + </xsl:when> + <xsl:otherwise> + <xsl:call-template name="subfieldSelect"> + <xsl:with-param name="codes">abcdefgijklnou</xsl:with-param> + </xsl:call-template> + </xsl:otherwise> + </xsl:choose> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Failing, but just to get your attention, overall this looks good. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123 --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I think my choice of subfields and z was a bit arbitrary.. I used the 'action note', 583, as a basis. Happy to be guided. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123 --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Subfield `z` is often 'public note' and subfield `x` is often 'nonpublic note' for other fields.. I did wonder about supporting subfield `u` specifically for a 'uri' to allow for linking to more details or a content policy or some such. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Martin Renvoize from comment #16)
Subfield `z` is often 'public note' and subfield `x` is often 'nonpublic note' for other fields.. I did wonder about supporting subfield `u` specifically for a 'uri' to allow for linking to more details or a content policy or some such.
a, x an z certainly make sense. Not sure what is better: keep it simple or make it a complete list. Both could be options. The 5xx vary a lot in the number of subfields, 500 for example has almost none/just the basics: https://www.loc.gov/marc/bibliographic/bd500.html -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140356|0 |1 is obsolete| | --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 143880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143880&action=edit Bug 31123: Add `ContentWarningField` preference This patch adds a new `ContentWarningField` preference allowing the library to define which 59X field to use to store harmful content warning notes. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140357|0 |1 is obsolete| | --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 143881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143881&action=edit Bug 31123: Display content warnings on the intranet This patch adds handling to our XSLT processing to pass the new `ContentWarningField` preference value to the stylesheets and then uses that variable to add content warning notes to both the detail and search result displays of the staff client. Test plan 1) Run the database update to expose the new system preference 2) Set `ContentWarningField` to something sensible, like `599` 3) Add the above select field to one of your frameworks with a subfield `a`. 4) Edit a record with that framework to add a content warning into the record 5) Search for the record and confirm you now see `Content warning: Your test text` 6) Click into the record detail and confirm you see the content warning text there too 7) Bonus points: Assign a new authorized value category to the chosen field and subfield and confirm the staff client display text is used in the above tests. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140358|0 |1 is obsolete| | --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 143882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143882&action=edit Bug 31123: Display content warnings in OPAC This patch adds handling of content warning display to the OPAC for both detail and search result views Test plan 1) Work through the test plan for the previous patch 2) Confirm that the same text now also displays on the equivilent OPAC pages. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123 --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #17)
(In reply to Martin Renvoize from comment #16)
Subfield `z` is often 'public note' and subfield `x` is often 'nonpublic note' for other fields.. I did wonder about supporting subfield `u` specifically for a 'uri' to allow for linking to more details or a content policy or some such.
a, x an z certainly make sense. Not sure what is better: keep it simple or make it a complete list. Both could be options.
The 5xx vary a lot in the number of subfields, 500 for example has almost none/just the basics: https://www.loc.gov/marc/bibliographic/bd500.html
Rebased. Suggestion: let's use a complete list? That way libraries can use whatever. Also maybe good in case of UNIMARC? Did a tiny rebase: conflict in .pref -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143880|0 |1 is obsolete| | --- Comment #22 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 147342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147342&action=edit Bug 31123: Add `ContentWarningField` preference This patch adds a new `ContentWarningField` preference allowing the library to define which 59X field to use to store harmful content warning notes. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143881|0 |1 is obsolete| | --- Comment #23 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 147343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147343&action=edit Bug 31123: Display content warnings on the intranet This patch adds handling to our XSLT processing to pass the new `ContentWarningField` preference value to the stylesheets and then uses that variable to add content warning notes to both the detail and search result displays of the staff client. Test plan 1) Run the database update to expose the new system preference 2) Set `ContentWarningField` to something sensible, like `599` 3) Add the above select field to one of your frameworks with a subfield `a`. 4) Edit a record with that framework to add a content warning into the record 5) Search for the record and confirm you now see `Content warning: Your test text` 6) Click into the record detail and confirm you see the content warning text there too 7) Bonus points: Assign a new authorized value category to the chosen field and subfield and confirm the staff client display text is used in the above tests. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143882|0 |1 is obsolete| | --- Comment #24 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 147344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147344&action=edit Bug 31123: Display content warnings in OPAC This patch adds handling of content warning display to the OPAC for both detail and search result views Test plan 1) Work through the test plan for the previous patch 2) Confirm that the same text now also displays on the equivilent OPAC pages. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123 --- Comment #25 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 147345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147345&action=edit Bug 31123: Update Staff XSLT to include all subfields This patch updates the XSLT sheets to include all subfields in your selected ContentWarningField in display and handles converting the subfield u if present to a hyperlink. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123 --- Comment #26 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 147346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147346&action=edit Bug 31123: Add all subfields to OPAC stylsheet This patch updates the OPAC XSLT's to display all subfields, barring the 'x' field which is often used as a 'private note' in other notes fields. We also handle converting subfield 'u' to a hyper link if it's found to be present and use subfield 'a' for the link text if present. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This new feature allows release notes| |librarians to pick a note | |field to use to store | |'Content warnings' about | |biblio records. | | | |The new | |`ContentWarningField` | |system preference can be | |set to any MARC field, | |though for MARC21 an 59X is | |recommended. One can then | |add said field to the | |frameworks and it will be | |displayed appropriately | |with the label 'Content | |warning:' in OPAC and Staff | |interfaces on both detail | |and results pages. We hide | |subfield x from the OPAC as | |it is often used as a | |'private note' in other | |note fields and we also | |handle turning the content | |of a 'u' subfield into a | |clickable link if you wish | |to use that. Other | |subfields as just displayed | |in line when present. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147342|0 |1 is obsolete| | Attachment #147343|0 |1 is obsolete| | Attachment #147344|0 |1 is obsolete| | Attachment #147345|0 |1 is obsolete| | Attachment #147346|0 |1 is obsolete| | --- Comment #27 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 148992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148992&action=edit Bug 31123: Add `ContentWarningField` preference This patch adds a new `ContentWarningField` preference allowing the library to define which 59X field to use to store harmful content warning notes. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123 --- Comment #28 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 148993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148993&action=edit Bug 31123: Display content warnings on the intranet This patch adds handling to our XSLT processing to pass the new `ContentWarningField` preference value to the stylesheets and then uses that variable to add content warning notes to both the detail and search result displays of the staff client. Test plan 1) Run the database update to expose the new system preference 2) Set `ContentWarningField` to something sensible, like `599` 3) Add the above select field to one of your frameworks with a subfield `a`. 4) Edit a record with that framework to add a content warning into the record 5) Search for the record and confirm you now see `Content warning: Your test text` 6) Click into the record detail and confirm you see the content warning text there too 7) Bonus points: Assign a new authorized value category to the chosen field and subfield and confirm the staff client display text is used in the above tests. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123 --- Comment #29 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 148994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148994&action=edit Bug 31123: Display content warnings in OPAC This patch adds handling of content warning display to the OPAC for both detail and search result views Test plan 1) Work through the test plan for the previous patch 2) Confirm that the same text now also displays on the equivilent OPAC pages. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123 --- Comment #30 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 148995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148995&action=edit Bug 31123: Update Staff XSLT to include all subfields This patch updates the XSLT sheets to include all subfields in your selected ContentWarningField in display and handles converting the subfield u if present to a hyperlink. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123 --- Comment #31 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 148996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148996&action=edit Bug 31123: Add all subfields to OPAC stylsheet This patch updates the OPAC XSLT's to display all subfields, barring the 'x' field which is often used as a 'private note' in other notes fields. We also handle converting subfield 'u' to a hyper link if it's found to be present and use subfield 'a' for the link text if present. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123 --- Comment #32 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 148997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148997&action=edit Bug 31123: Fix file permission Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123 --- Comment #33 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting CC| |jacob.omara@ptfs-europe.com --- Comment #34 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Enhancement - not backporting to 22.11.x Nice work everyone! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | Status|Needs documenting |RESOLVED Documentation| |Caroline Cyr La Rose contact| | Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/685 CC| |caroline.cyr-la-rose@inlibr | |o.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This new feature allows |This new feature allows release notes|librarians to pick a note |librarians to pick a note |field to use to store |field to use to store |'Content warnings' about |'Content warnings' about |biblio records. |biblio records. | | |The new |The new |`ContentWarningField` |`ContentWarningField` |system preference can be |system preference can be |set to any MARC field, |set to any MARC field, |though for MARC21 an 59X is |though for MARC21 an 59X is |recommended. One can then |recommended. One can add |add said field to the |said field to the |frameworks and it will be |frameworks and it will be |displayed appropriately |displayed appropriately |with the label 'Content |with the label 'Content |warning:' in OPAC and Staff |warning:' in OPAC and staff |interfaces on both detail |interface on both detail |and results pages. We hide |and results pages. We hide |subfield x from the OPAC as |subfield x from the OPAC as |it is often used as a |it is often used as a |'private note' in other |'private note' in other |note fields and we also |note fields and we also |handle turning the content |handle turning the content |of a 'u' subfield into a |of a 'u' subfield into a |clickable link if you wish |clickable link if you wish |to use that. Other |to use that. Other |subfields as just displayed |subfields as just displayed |in line when present. |in line when present. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This new feature allows |**Sponsored by** *Tavistock release notes|librarians to pick a note |& Portman Library* |field to use to store | |'Content warnings' about |This |biblio records. |new feature allows | |librarians to pick a note |The new |field to use to store |`ContentWarningField` |'Content warnings' about |system preference can be |biblio records. |set to any MARC field, | |though for MARC21 an 59X is |The new |recommended. One can add |`ContentWarningField` |said field to the |system preference can be |frameworks and it will be |set to any MARC field, |displayed appropriately |though for MARC21 an 59X is |with the label 'Content |recommended. One can add |warning:' in OPAC and staff |said field to the |interface on both detail |frameworks and it will be |and results pages. We hide |displayed appropriately |subfield x from the OPAC as |with the label 'Content |it is often used as a |warning:' in OPAC and staff |'private note' in other |interface on both detail |note fields and we also |and results pages. We hide |handle turning the content |subfield x from the OPAC as |of a 'u' subfield into a |it is often used as a |clickable link if you wish |'private note' in other |to use that. Other |note fields and we also |subfields as just displayed |handle turning the content |in line when present. |of a 'u' subfield into a | |clickable link if you wish | |to use that. Other | |subfields as just displayed | |in line when present. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36370 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36370 [Bug 36370] Add ContentWarningField to UNIMARC XSLT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36375 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36375 [Bug 36375] Inconsistencies in ContentWarningField display -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org