http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12336 Viktor Sarge <viktor.sarge@regionhalland.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12336 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28594|0 |1 is obsolete| | --- Comment #2 from Magnus Enger <magnus@enger.priv.no> --- Created attachment 28622 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28622&action=edit Bug 12336 - [SIGNED-OFF] Author of reserved book is not displayed in opac-user.pl This patch adds a line in opac-user.pl passing author info to opac-user.tt Thanks to cait for helping me out and showing me how to solve this with half the amount of code. Test plan: * Reserve a book. * Go to the opac and log in as the patron you reserved the book for. * Apply the patch with change to opac-user.pl * Revisit the opac and refresh it. * See if author now shows up Signed-off-by: Magnus Enger <digitalutvikling@gmail.com> Created a hold. Author is not shown n the public catalogue before applying the patch, but it does show after applying the patch. Way to go, Viktor! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12336 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28622|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 28632 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28632&action=edit Bug 12336 - [SIGNED-OFF] Author of reserved book is not displayed in opac-user.pl This patch adds a line in opac-user.pl passing author info to opac-user.tt Thanks to cait for helping me out and showing me how to solve this with half the amount of code. Test plan: * Reserve a book. * Go to the opac and log in as the patron you reserved the book for. * Apply the patch with change to opac-user.pl * Revisit the opac and refresh it. * See if author now shows up Signed-off-by: Magnus Enger <digitalutvikling@gmail.com> Created a hold. Author is not shown n the public catalogue before applying the patch, but it does show after applying the patch. Way to go, Viktor! Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12336 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- I think this is more a bugfix than an enh. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12336 --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Viktor Sarge from comment #5)

I agree Jonathan. I fixes that opac-user.tt tries to output a value that opac-user.pl don't create. I understand that I should add [ENH] to enh. bugs - is there something I should do to flag it as a bug?

You can just change the severity with the dropdown list near "Importance:". The values are "critical", "normal", ..., "enhancement", "new feature". -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12336 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed by Module Maintainer |Pushed to Master CC| |tomascohen@gmail.com --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Viktor! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12336 --- Comment #9 from Viktor Sarge <viktor.sarge@regionhalland.se> --- Thank you! This is great fun. And the timing is spotless - now I can publish post #100 on our blog with the news of my first patch being accepted :) (In reply to Galen Charlton from comment #8)

Pushed to 3.16.x for inclusion in 3.16.1.

Congratulations for having your first patch accepted into Koha, Viktor!

-- You are receiving this mail because: You are watching all bug changes.