[Bug 11973] New: Fix Armenian language description
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11973 Bug ID: 11973 Summary: Fix Armenian language description Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: bgkriegel@gmail.com QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr Armenian language description (in armenian) should be Հայերեն instead of Հայերէն (sixth letter) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11973 --- Comment #1 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 26482 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26482&action=edit Bug 11973 - Fix Armenian language description This patch fix Armenian language description To test: 1) Do a fake translation to Armenian, mkdir koha-tmpl/intranet-tmpl/prog/hy-Armn 2) Go to Administration > System preferences > I18N/L10N 3) Armenian description looks like the second string in Bug description 4) Apply the patch 5) Run updatedatabase.pl 6) Reload page, now description look as first string in Bug description (it's the sixth letter, similar to 't') -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11973 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11973 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26482|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 26493 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26493&action=edit Bug 11973 - Fix Armenian language description This patch fix Armenian language description To test: 1) Do a fake translation to Armenian, mkdir koha-tmpl/intranet-tmpl/prog/hy-Armn 2) Go to Administration > System preferences > I18N/L10N 3) Armenian description looks like the second string in Bug description 4) Apply the patch 5) Run updatedatabase.pl 6) Reload page, now description look as first string in Bug description (it's the sixth letter, similar to 't') Ammended patch, wrong column. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11973 Holger Meißner <h.meissner.82@web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26493|0 |1 is obsolete| | --- Comment #3 from Holger Meißner <h.meissner.82@web.de> --- Created attachment 26508 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26508&action=edit Bug 11973 - Fix Armenian language description This patch fix Armenian language description To test: 1) Do a fake translation to Armenian, mkdir koha-tmpl/intranet-tmpl/prog/hy-Armn 2) Go to Administration > System preferences > I18N/L10N 3) Armenian description looks like the second string in Bug description 4) Apply the patch 5) Run updatedatabase.pl 6) Reload page, now description look as first string in Bug description (it's the sixth letter, similar to 't') Ammended patch, wrong column. Signed-off-by: Holger Meißner <h.meissner.82@web.de> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11973 Holger Meißner <h.meissner.82@web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |h.meissner.82@web.de --- Comment #4 from Holger Meißner <h.meissner.82@web.de> --- Those letters look so similar. I increased the font size and did a screenshot before and after, to be sure. :D -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11973 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch fixes the English sql file, but the wrong string still appears in the translated SQL files: installer/data/mysql/de-DE/mandatory/subtag_registry.sql 86 VALUES ( 'hy', 'language', 'hy', 'Հայերէն'); installer/data/mysql/es-ES/mandatory/subtag_registry.sql 74 VALUES ( 'hy', 'language', 'hy', 'Հայերէն'); installer/data/mysql/it-IT/necessari/subtag_registry.sql 76 VALUES ( 'hy', 'language', 'hy', 'Հայերէն'); installer/data/mysql/nb-NO/1-Obligatorisk/subtag_registry.sql 95 VALUES ( 'hy', 'language', 'hy', 'Հայերէն'); installer/data/mysql/pl-PL/mandatory/subtag_registry.sql 74 VALUES ( 'hy', 'language', 'hy', 'Հայերէն'); installer/data/mysql/ru-RU/mandatory/subtag_registry.sql 74 VALUES ( 'hy', 'language', 'hy', 'Հայերէն'); installer/data/mysql/uk-UA/mandatory/subtag_registry.sql 74 VALUES ( 'hy', 'language', 'hy', 'Հայերէն'); We really should only maintain the language files once, as they contain all the translations. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11973 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9056 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11973 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11568 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11973 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11393 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11973 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 26517 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26517&action=edit [PASSED QA] Bug 11973 - Fix Armenian language description This patch fix Armenian language description To test: 1) Do a fake translation to Armenian, mkdir koha-tmpl/intranet-tmpl/prog/hy-Armn 2) Go to Administration > System preferences > I18N/L10N 3) Armenian description looks like the second string in Bug description 4) Apply the patch 5) Run updatedatabase.pl 6) Reload page, now description look as first string in Bug description (it's the sixth letter, similar to 't') Ammended patch, wrong column. Signed-off-by: Holger Meißner <h.meissner.82@web.de> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Patch fixes the English sample file for translations and includes a database update to correct the string in existing installations. Passes all tests and QA script. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11973 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11973 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26508|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11973 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I have added some other related bugs. My suggestion would be, that we first fix the English file as reference and then either - copy the corrected English file for all translated installers - or better: move it out of the language specific installer directories (like syspref.sql) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11973 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #8 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Bernardo! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11973 --- Comment #9 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to Katrin Fischer from comment #7)
I have added some other related bugs. My suggestion would be, that we first fix the English file as reference and then either - copy the corrected English file for all translated installers - or better: move it out of the language specific installer directories (like syspref.sql)
I did a patch for your last suggestion, changed Installer.pm and did a install to test it. It worked Later I changed my mind and did Bug 12017. I think it's better to have languages descriptions out of database, at last for translations. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11973 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Bernardo, thx a lot for looking into this. I think one of the reasons it wasn't moved to the templates was that we don't want to translate, but show the native description for languages - not sure how to do that with the translation system. Also in advanced search we show the native and the translated description together. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11973 --- Comment #11 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Katrin, I did a new version. Now all is native, and advanced search shows translations. All in templates. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11973 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers@biblibre.co | |m Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11973 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #12 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.08 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org