[Bug 34828] New: Add Koha::MetadataExtractor class
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34828 Bug ID: 34828 Summary: Add Koha::MetadataExtractor class Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34828 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33955 CC| |tomascohen@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34828 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34828 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 155907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155907&action=edit Bug 34828: Introduce Koha::MetadataExtractor and ->get_normalized_upc This patch introduces a new pattern for the different ->get_<thing> methods we've been adding. The aim is that code will look more like: my $metadata_extractor = Koha::MetadataExtractor->new; while ( my $biblio = $biblios->next ) { my $record = $biblio->record; my $schema = $biblio->record_schema; $data->{$biblio->id}->{normalized_upc} = $metadata_extractor->get_normalized_upc( { record => $record, schema => $schema } ); $data->{$biblio->id}->{normalized_ean} = $metadata_extractor->get_normalized_ean( { record => $record, schema => $schema } ); } The key is that we are actually reusing the MARC::Record, and code for each schema is organized cleanly so easier to maintain. For the class names, I chose to add the 'MARC' name in the path, so we don't need to refactor anything if we want to add support for another serialization formats. To test: 1. Apply this patch 2. Run: $ ktd --shell k$ qa -c 1 => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34828 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #2 from David Cook <dcook@prosentient.com.au> --- I'm intrigued by this one. It looks practical and high performance. However, it also feels a bit unnatural. It's more natural to have something like $metadata->get_normalized_upc. -- Looking at your patches, I notice that Koha::MetadataExtractor::MARC::MARC21 doesn't have any internal state, so it doesn't necessarily need to require object instantiation. And the only internal state for Koha::MetadataExtractor is a list of stateless objects. So I have a suggestion for an alternative using static class methods. It would be just as practical and high performance, but it would be more concise. It would look like this: $biblio_metadata->extractor->get_normalized_upc({ record => $record }) I suppose that might look a little confusing, so you could do something like 'my $extractor = $biblio_metadata->get_extractor' and then use '$extractor->get_normalized_upc({ record => $record })'. The Koha::Biblio::Metadata object has the "schema" to-hand, so the "extractor" method would dynamically return the name of the schema-specific extractor class for that metadata record, and then "get_normalized_upc" would be called as a static class method like Koha::MetadataExtractor::MARC::MARC21->get_normalized_upc({ record => $record }). It's very concise and has all the same benefits of your current implementation. I'll include a little proof-of-concept as a comment. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34828 --- Comment #3 from David Cook <dcook@prosentient.com.au> --- #!/usr/bin/perl use strict; use warnings; my $biblio = Local::Biblio->new({type => 'Test'}); warn $biblio; warn $biblio->extractor; warn $biblio->extractor->awesome; package Local::Biblio; sub new { my ($class,$args) = @_; $args = {} unless $args; my $self = bless($args,$class); return $self; } sub extractor { my ($self) = @_; my $type = $self->{type}; return "Local::Extractor::$type"; } package Local::Extractor; sub new { my ($class) = @_; my $self = {}; return bless $self, $class; } package Local::Extractor::Test; sub awesome { my ($class,$args) = @_; return "$class == awesome"; } 1; -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34828 --- Comment #4 from David Cook <dcook@prosentient.com.au> --- #!/usr/bin/perl use strict; use warnings; my $biblio = Local::Biblio->new({type => 'Test'}); warn $biblio; warn $biblio->extractor; warn $biblio->extractor->awesome; package Local::Biblio; sub new { my ($class,$args) = @_; $args = {} unless $args; my $self = bless($args,$class); return $self; } sub extractor { my ($self) = @_; my $type = $self->{type}; return "Local::Extractor::$type"; } package Local::Extractor::Test; sub awesome { my ($class,$args) = @_; return "$class == awesome"; } 1; -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34828 --- Comment #5 from David Cook <dcook@prosentient.com.au> --- Another option would be to implement get_normalized_upc() in Koha::Biblio::Metadata and have it do an internal call to that "extractor" function. That could be useful for caching and storing internal state in Koha::Biblio::Metadata if we wanted. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34828 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- David and all, I'm happy to have the ball roll and have all your ideas. I'm not attached to this particular code in any way. I'm just generally not sure about the approach we have taken, and this is the best I have come up with. opac-detail.pl has calls to: GetNormalizedEAN GetNormalizedISBN GetNormalizedOCLCNumber GetNormalizedUPC GetMarcControlnumber GetMarcISBN GetMarcISSN GetMarcSeries GetMarcSubjects GetMarcUrls About object orientation: I think I just didn't want to type long names for each call (considering we might have mixes of schemas, even). I would agree my code could just be passed a Koha::Biblio::Metadata object instead, which *should* cache the calculated MARC::Record object in some way. The ambivalence between Koha::Biblio and Koha::Biblio::Metadata has always smelled. It become evident when we were developing the /biblios endpoint. And the reason I filed bug 14645 8 years ago (LOL, just remembered). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34828 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- What do we want to type/read? I personally would like something like: my $extractor = Koha::Biblio::MetadataExtractor->new({biblio => $biblio}); Koha::MetadataExtractor retrieves the record and the schema from the biblio object. then simply retrieve using: my $upc = $extractor->[get_]normalized_upc; And we will see for authorities later, we don't need it for now. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34828 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #7)
What do we want to type/read?
I personally would like something like:
my $extractor = Koha::Biblio::MetadataExtractor->new({biblio => $biblio});
Koha::MetadataExtractor retrieves the record and the schema from the biblio object.
then simply retrieve using:
my $upc = $extractor->[get_]normalized_upc;
I like that. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34828 --- Comment #9 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #7)
What do we want to type/read?
I personally would like something like:
my $extractor = Koha::Biblio::MetadataExtractor->new({biblio => $biblio});
Thinking about it again today and I suppose I just wonder about all the different objects we'll have to do similar things. Koha::Biblio Koha::Biblio::Metadata Koha::Biblio::MetadataExtractor Koha::MetadataRecord Koha::RecordProcessor I can't keep them all straight. I hadn't even heard of Koha::MetadataRecord until yesterday. Something like "get_normalized_upc" should conceptually be a method of Koha::Biblio or Koha::Biblio::Metadata. But it would be a bit annoying to have a lot of if/elsif/else statements in methods like "get_normalized_upc" based on a schema condition. So I can see the value of Koha::Biblio::MetadataExtractor and having separate subclasses for different schemas, as it is a clean way of providing schema specific method overrides. But surely "hiding" it within Koha::Biblio or Koha::Biblio::Metadata would be better reading/writing for developers. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34828 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34828 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155907|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 156565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156565&action=edit Bug 34828: Introduce Koha::MetadataExtractor and ->get_normalized_upc This patch introduces a new pattern for the different ->get_<thing> methods we've been adding. The aim is that code will look more like: my $metadata_extractor = Koha::MetadataExtractor->new; while ( my $biblio = $biblios->next ) { my $record = $biblio->record; my $schema = $biblio->record_schema; $data->{$biblio->id}->{normalized_upc} = $metadata_extractor->get_normalized_upc( { record => $record, schema => $schema } ); $data->{$biblio->id}->{normalized_ean} = $metadata_extractor->get_normalized_ean( { record => $record, schema => $schema } ); } The key is that we are actually reusing the MARC::Record, and code for each schema is organized cleanly so easier to maintain. For the class names, I chose to add the 'MARC' name in the path, so we don't need to refactor anything if we want to add support for another serialization formats. To test: 1. Apply this patch 2. Run: $ ktd --shell k$ qa -c 1 => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34828 --- Comment #11 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 156566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156566&action=edit Bug 34828: Move to Koha::Biblio::Metadata::Extractor We are not directly linked with the other Koha::Metadata* packages. Better to isolate this under Koha::Biblio::Metadata (at least for now). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34828 --- Comment #12 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 156567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156567&action=edit Bug 34828: Add Koha::Biblio::Metadata::Extractor::MARC and inherit from it The new usage is now: 1. With a Koha::Biblio object my $extractor = Koha::Biblio::Metadata::Extractor->new({biblio => $biblio}); $extractor->get_normalized_upc; or 2. With a MARC::Record my $extractor = Koha::Biblio::Metadata::Extractor->new({metadata=> $biblio->metadata->record}); $extractor->get_normalized_upc; Note that there are "Inconsistent hierarchy during C3 merge of class" warnings raised by the QA script. We could remove them by replacing the 'use' by 'require' in Koha::Biblio::Metadata::Extractor::MARC (in ->new) but that's suboptimal. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34828 --- Comment #13 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 156568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156568&action=edit Bug 34828: Make normalized_oclc uses Koha::Biblio::Metadata::Extractor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34828 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23235 Status|ASSIGNED |In Discussion --- Comment #14 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Hey, what do you think of this change? Note that I don't think we should add this new concept/module/abstraction/complexity if there is no plan to move it further (i.e. a goal/roadmap we share to replace what is C4::Koha and Koha::Biblio that is parsing MARC::Record to get data). Also note that bug 23235 become even more relevant now... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34828 --- Comment #15 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #14)
Hey, what do you think of this change?
I like it. That's how I thought we could use it.
Note that I don't think we should add this new concept/module/abstraction/complexity if there is no plan to move it further (i.e. a goal/roadmap we share to replace what is C4::Koha and Koha::Biblio that is parsing MARC::Record to get data).
It is done, I don't think having 'MARC' in the package name hurts, as of UNIMARC and MARC21, the different packages make sense, though.
Also note that bug 23235 become even more relevant now...
Yeah, probably. Setting to NSO? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34828 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34828 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34828 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156565|0 |1 is obsolete| | --- Comment #16 from David Nind <david@davidnind.com> --- Created attachment 156575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156575&action=edit Bug 34828: Introduce Koha::MetadataExtractor and ->get_normalized_upc This patch introduces a new pattern for the different ->get_<thing> methods we've been adding. The aim is that code will look more like: my $metadata_extractor = Koha::MetadataExtractor->new; while ( my $biblio = $biblios->next ) { my $record = $biblio->record; my $schema = $biblio->record_schema; $data->{$biblio->id}->{normalized_upc} = $metadata_extractor->get_normalized_upc( { record => $record, schema => $schema } ); $data->{$biblio->id}->{normalized_ean} = $metadata_extractor->get_normalized_ean( { record => $record, schema => $schema } ); } The key is that we are actually reusing the MARC::Record, and code for each schema is organized cleanly so easier to maintain. For the class names, I chose to add the 'MARC' name in the path, so we don't need to refactor anything if we want to add support for another serialization formats. To test: 1. Apply this patch 2. Run: $ ktd --shell k$ qa -c 1 => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34828 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156566|0 |1 is obsolete| | --- Comment #17 from David Nind <david@davidnind.com> --- Created attachment 156576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156576&action=edit Bug 34828: Move to Koha::Biblio::Metadata::Extractor We are not directly linked with the other Koha::Metadata* packages. Better to isolate this under Koha::Biblio::Metadata (at least for now). Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34828 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156567|0 |1 is obsolete| | --- Comment #18 from David Nind <david@davidnind.com> --- Created attachment 156577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156577&action=edit Bug 34828: Add Koha::Biblio::Metadata::Extractor::MARC and inherit from it The new usage is now: 1. With a Koha::Biblio object my $extractor = Koha::Biblio::Metadata::Extractor->new({biblio => $biblio}); $extractor->get_normalized_upc; or 2. With a MARC::Record my $extractor = Koha::Biblio::Metadata::Extractor->new({metadata=> $biblio->metadata->record}); $extractor->get_normalized_upc; Note that there are "Inconsistent hierarchy during C3 merge of class" warnings raised by the QA script. We could remove them by replacing the 'use' by 'require' in Koha::Biblio::Metadata::Extractor::MARC (in ->new) but that's suboptimal. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34828 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156568|0 |1 is obsolete| | --- Comment #19 from David Nind <david@davidnind.com> --- Created attachment 156578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156578&action=edit Bug 34828: Make normalized_oclc uses Koha::Biblio::Metadata::Extractor Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34828 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #20 from David Nind <david@davidnind.com> --- I've signed off, as the test plan works. However, I don't really understand the changes as I'm not a developer - please feel free to change it back to needs sign off if that is required. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34828 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156575|0 |1 is obsolete| | Attachment #156576|0 |1 is obsolete| | Attachment #156577|0 |1 is obsolete| | Attachment #156578|0 |1 is obsolete| | --- Comment #21 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 156743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156743&action=edit Bug 34828: Introduce Koha::MetadataExtractor and ->get_normalized_upc This patch introduces a new pattern for the different ->get_<thing> methods we've been adding. The aim is that code will look more like: my $metadata_extractor = Koha::MetadataExtractor->new; while ( my $biblio = $biblios->next ) { my $record = $biblio->record; my $schema = $biblio->record_schema; $data->{$biblio->id}->{normalized_upc} = $metadata_extractor->get_normalized_upc( { record => $record, schema => $schema } ); $data->{$biblio->id}->{normalized_ean} = $metadata_extractor->get_normalized_ean( { record => $record, schema => $schema } ); } The key is that we are actually reusing the MARC::Record, and code for each schema is organized cleanly so easier to maintain. For the class names, I chose to add the 'MARC' name in the path, so we don't need to refactor anything if we want to add support for another serialization formats. To test: 1. Apply this patch 2. Run: $ ktd --shell k$ qa -c 1 => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34828 --- Comment #22 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 156744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156744&action=edit Bug 34828: Move to Koha::Biblio::Metadata::Extractor We are not directly linked with the other Koha::Metadata* packages. Better to isolate this under Koha::Biblio::Metadata (at least for now). Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34828 --- Comment #23 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 156745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156745&action=edit Bug 34828: Add Koha::Biblio::Metadata::Extractor::MARC and inherit from it The new usage is now: 1. With a Koha::Biblio object my $extractor = Koha::Biblio::Metadata::Extractor->new({biblio => $biblio}); $extractor->get_normalized_upc; or 2. With a MARC::Record my $extractor = Koha::Biblio::Metadata::Extractor->new({metadata=> $biblio->metadata->record}); $extractor->get_normalized_upc; Note that there are "Inconsistent hierarchy during C3 merge of class" warnings raised by the QA script. We could remove them by replacing the 'use' by 'require' in Koha::Biblio::Metadata::Extractor::MARC (in ->new) but that's suboptimal. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34828 --- Comment #24 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 156746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156746&action=edit Bug 34828: Make normalized_oclc uses Koha::Biblio::Metadata::Extractor Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34828 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #25 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Thanks Jonathan and David^2. I really feel we now have a better path for future refactoring efforts. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34828 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add Koha::MetadataExtractor |Add |class |Koha::Biblio::Metadata::Ext | |ractor* classes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34828 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34828 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This development adds a new release notes| |class for handling metadata | |extraction from the | |metadata registry in Koha. | |The way it is built | |provides a good framework | |for reorganizing the | |codebase around this area, | |as well as making it more | |streamlined to write tests. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34828 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34828 --- Comment #26 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34828 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #27 from Fridolin Somers <fridolin.somers@biblibre.com> --- Looks great. Maybe there will be a plugin hook for this. Enhancement not pushed to 23.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34828 --- Comment #28 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 156789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156789&action=edit Bug 34828: Remove useless variable Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34828 --- Comment #29 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 156791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156791&action=edit Bug 34828: Fix test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34828 --- Comment #30 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Follow-ups pushed to master. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34828 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34828 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35142 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35142 [Bug 35142] Koha::Util::oclc_number should be removed in favor of Koha::Biblio::Metadata::Extractor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34828 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42563 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42563 [Bug 42563] Add Koha::Biblio->host_items using MetadataExtractor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34828 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42566 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@openfifth.c | |o.uk Blocks|42566 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42566 [Bug 42566] Remove C4::Koha::GetNormalizedUPC in favor of MetadataExtractor -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org