https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37563 --- Comment #2 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- Created attachment 170022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170022&action=edit Refund amount for 2.40 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37563 --- Comment #4 from CJ Lynce <cj.lynce@westlakelibrary.org> --- Created attachment 170045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170045&action=edit Bug 37563: Refund, payout, and discount modals in borrower transactions and Point of Sale have broken/bad formatting of values This patch corrects formatting of amounts in both the POS and member accounting module Payment, Discount, and Payout modals. It also corrects an issue where amounts of a previous modal show up when clicking on the same modal for a different accountline the member Accounting page. Finally, it corrects an issue with the member Accounting Discount modal in that an amount without both decimal places will not display. Steps to test: 1) Login to staff client 2) Enable the 'EnablePointOfSale' system preference 3) Enable the 'UseCashRegisters' system preference 4) Open POS module and configure a cash register 5) In the POS module -> 'Configure items for purchase', create some items with different costs (divisible by .10, e.g 25 or 1.10, etc.)) 6) Use the POS module to make a few transactions 7) Open POS -> 'Cash Summary for [BRANCH]', and open your configured register 8) Click 'Issue Refund' and check the formatting of the paid and returned to patron numbers *** Issue A) See that numbers are not formatted with two decimal places 9) Pull up the 'Accounting' tab for a borrower 10) Create at least 3 invoices for different amounts (divisible by .10, e.g 25 or 1.10, etc.) 11) Pay TWO of your invoices then open the 'Transactions' tab 12) Create a manual credit for an amount (divisible by .10, e.g 25 or 1.10, etc.) 13) Click the 'Apply discount' button on one of your invoices *** Issue B) No 'Amount charged' appears 14) Click 'Issue refund' for one of the paid invoices. *** Issue C) The 'Return to Patron' line does not have 2 decimal places 15) Click 'Issue refund' for another paid invoice *** Issue D) The 'Amount Paid' shows the amount from the first modal 16) Click 'Apply discount' for one of the unpaid invoices *** Issue E) The 'Amount charged' line is blank *** Issue F) The discount line is also blank, should at least have a 0.00 value 17) Click 'Issue Payout' for your manual credit. *** Issue G) The 'Return to Patron' line does not have 2 decimal places 18) Apply patch 19) Repeat steps 7 & 8 and check the formatting is correct for issue A 20) Repeat steps 13-17 and check behavior and formatting is correct for issues B-G 21) Celebrate that you are done with all the steps and looking at numbers, and that all is right in the Koha payment world (maybe) Sponsored by: Westlake Porter Public Library -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37563 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170045|0 |1 is obsolete| | --- Comment #5 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 170074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170074&action=edit Bug 37563: Refund, payout, and discount modals in borrower transactions and Point of Sale have broken/bad formatting of values This patch corrects formatting of amounts in both the POS and member accounting module Payment, Discount, and Payout modals. It also corrects an issue where amounts of a previous modal show up when clicking on the same modal for a different accountline the member Accounting page. Finally, it corrects an issue with the member Accounting Discount modal in that an amount without both decimal places will not display. Steps to test: 1) Login to staff client 2) Enable the 'EnablePointOfSale' system preference 3) Enable the 'UseCashRegisters' system preference 4) Open POS module and configure a cash register 5) In the POS module -> 'Configure items for purchase', create some items with different costs (divisible by .10, e.g 25 or 1.10, etc.)) 6) Use the POS module to make a few transactions 7) Open POS -> 'Cash Summary for [BRANCH]', and open your configured register 8) Click 'Issue Refund' and check the formatting of the paid and returned to patron numbers *** Issue A) See that numbers are not formatted with two decimal places 9) Pull up the 'Accounting' tab for a borrower 10) Create at least 3 invoices for different amounts (divisible by .10, e.g 25 or 1.10, etc.) 11) Pay TWO of your invoices then open the 'Transactions' tab 12) Create a manual credit for an amount (divisible by .10, e.g 25 or 1.10, etc.) 13) Click the 'Apply discount' button on one of your invoices *** Issue B) No 'Amount charged' appears 14) Click 'Issue refund' for one of the paid invoices. *** Issue C) The 'Return to Patron' line does not have 2 decimal places 15) Click 'Issue refund' for another paid invoice *** Issue D) The 'Amount Paid' shows the amount from the first modal 16) Click 'Apply discount' for one of the unpaid invoices *** Issue E) The 'Amount charged' line is blank *** Issue F) The discount line is also blank, should at least have a 0.00 value 17) Click 'Issue Payout' for your manual credit. *** Issue G) The 'Return to Patron' line does not have 2 decimal places 18) Apply patch 19) Repeat steps 7 & 8 and check the formatting is correct for issue A 20) Repeat steps 13-17 and check behavior and formatting is correct for issues B-G 21) Celebrate that you are done with all the steps and looking at numbers, and that all is right in the Koha payment world (maybe) Sponsored by: Westlake Porter Public Library Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37563 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170074|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 170536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170536&action=edit Bug 37563: Refund, payout, and discount modals in borrower transactions and Point of Sale have broken/bad formatting of values This patch corrects formatting of amounts in both the POS and member accounting module Payment, Discount, and Payout modals. It also corrects an issue where amounts of a previous modal show up when clicking on the same modal for a different accountline the member Accounting page. Finally, it corrects an issue with the member Accounting Discount modal in that an amount without both decimal places will not display. Steps to test: 1) Login to staff client 2) Enable the 'EnablePointOfSale' system preference 3) Enable the 'UseCashRegisters' system preference 4) Open POS module and configure a cash register 5) In the POS module -> 'Configure items for purchase', create some items with different costs (divisible by .10, e.g 25 or 1.10, etc.)) 6) Use the POS module to make a few transactions 7) Open POS -> 'Cash Summary for [BRANCH]', and open your configured register 8) Click 'Issue Refund' and check the formatting of the paid and returned to patron numbers *** Issue A) See that numbers are not formatted with two decimal places 9) Pull up the 'Accounting' tab for a borrower 10) Create at least 3 invoices for different amounts (divisible by .10, e.g 25 or 1.10, etc.) 11) Pay TWO of your invoices then open the 'Transactions' tab 12) Create a manual credit for an amount (divisible by .10, e.g 25 or 1.10, etc.) 13) Click the 'Apply discount' button on one of your invoices *** Issue B) No 'Amount charged' appears 14) Click 'Issue refund' for one of the paid invoices. *** Issue C) The 'Return to Patron' line does not have 2 decimal places 15) Click 'Issue refund' for another paid invoice *** Issue D) The 'Amount Paid' shows the amount from the first modal 16) Click 'Apply discount' for one of the unpaid invoices *** Issue E) The 'Amount charged' line is blank *** Issue F) The discount line is also blank, should at least have a 0.00 value 17) Click 'Issue Payout' for your manual credit. *** Issue G) The 'Return to Patron' line does not have 2 decimal places 18) Apply patch 19) Repeat steps 7 & 8 and check the formatting is correct for issue A 20) Repeat steps 13-17 and check behavior and formatting is correct for issues B-G 21) Celebrate that you are done with all the steps and looking at numbers, and that all is right in the Koha payment world (maybe) Sponsored by: Westlake Porter Public Library Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37563 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37563 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Refund, payout, and |Refund, payout, and |discount modals in borrower |discount modals in patron |transactions and Point of |transactions and point of |Sale have broken/bad |sale have broken/bad |formatting of values |formatting of values -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37563 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37563 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to main |RESOLVED CC| |lucas@bywatersolutions.com --- Comment #11 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Doesn't apply cleanly to 24.05.x, please rebase if needed. -- You are receiving this mail because: You are watching all bug changes.