[Bug 38061] New: Serials collection table improvements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38061 Bug ID: 38061 Summary: Serials collection table improvements Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: matt.blenkinsop@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38061 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |matt.blenkinsop@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38061 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38061 --- Comment #1 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 172297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172297&action=edit Bug 38061: Add item column to serial collections table This patch adds a column to the table to link to the item Test plan: 1) Add a new subscription to a serial record (with the option 'create an item record' selected) 2) Receive several issues and create the linked items 3) Navigate to the serials collection table 4) There should be a column for the linked item 5) Click on one of the links, it should display the item -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38061 --- Comment #2 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 172298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172298&action=edit Bug 38061: Tidy serials-collection.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38061 --- Comment #3 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 172299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172299&action=edit Bug 38061: Remove pre-selection of serials in the table Test plan: 1) Navigate to the serials-collection table 2) None of the checkboxes in the left hand column should be selected Sponsored-by: Association KohaLa - https://koha-fr.org/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38061 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nathalie.savarit@univ-amu.f | |r -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38061 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Please improve bug description to be more specific :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38061 --- Comment #5 from Nathalie SAVARIT <nathalie.savarit@univ-amu.fr> --- Katrin, when you're in serials-collection table, some issues are pre-ticked : expected issues, overdue issues... So, if you wish to delete issues, you must first uncheck those already ticked. We would like no issues to be pre-ticked to avoid deletion errors. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38061 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think removing the pre-selection would be an unwanted workflow change for some libraries. We train that these are the issues predicted but not received yet. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38061 --- Comment #7 from Nathalie SAVARIT <nathalie.savarit@univ-amu.fr> --- It currently poses a problem for batch deletions of issues. Issues may be deleted if you forget to untick the box. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38061 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- But it adds clicks for other workflows. Would a select all/unselect all or some other GUI option do the trick instead? It's certainly a change that I would not hide in a "seemingly" unrelated bug, but something we should discuss with libraries using that module. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38061 --- Comment #9 from Nathalie SAVARIT <nathalie.savarit@univ-amu.fr> --- I understand. It's a request from users in the French community. I've asked the people who took part in the working group to come and discuss the ticket. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38061 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com, | |jzairo@bywatersolutions.com --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I hope that didn't come across as unfriendly, I am just trying to be careful concerning side effects when behavior is changed. I feel a lot of libraries will be very happy about the enhancements for serials KohaLa/PTFS-E are working on. I think I got curious about the bug because of the bug description - "Improvements" or "enhancements" usually is a trigger for questions ;) Ideally this might have been better as 2 small bugs: * Adding the new column for the item link * Changing the checkboxes I have taken another look at the serials collections page and I think maybe the "Receive" link in the toolbar already does something very similar, but with a different selection of status (EXPECTED, LATE vs. EXPECTED, LATE, MISSING_STATUSES, CLAIMED) Maybe the receive link would be enough and it would be OK to remove the pre-selection. Adding some others for opinions. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38061 --- Comment #11 from Nathalie SAVARIT <nathalie.savarit@univ-amu.fr> --- No, don't worry :) In addition to the ‘receive’ link, you can sort the columns. In this case, I really think that pre-ticking the boxes is unnecessary. Let's wait for feedback from other users ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38061 Martin AUBEUT <martin.aubeut@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.aubeut@gmail.com --- Comment #12 from Martin AUBEUT <martin.aubeut@gmail.com> --- I think the two workflows can coexist! Let the user choose to switch between having the checkbox checked by default or unchecked by default, with a unchecked checkbox in the subscription. ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38061 Esther Melander <esther.melander@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |esther.melander@bywatersolu | |tions.com --- Comment #13 from Esther Melander <esther.melander@bywatersolutions.com> --- I tested this by adding a subscription to a record. I received several issues. I can see the link column but the column is blank. I'm not sure I understand what generates the link? I can see the received issues on the holding table in the Bibliographic view, so I would expect a link to the Item Detail view for the issue from the serial collection page? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38061 --- Comment #14 from Nathalie SAVARIT <nathalie.savarit@univ-amu.fr> --- Esther, You need to create an item when you receive the issue to see the link. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38061 --- Comment #15 from Esther Melander <esther.melander@bywatersolutions.com> --- Created attachment 172792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172792&action=edit Missing issue on serials collection page. I'm not sure why it did not work initially because I did configure the subscription to create the item records (probably a problem with the sandbox). On my second attempt, it did appear to work and I can see the links to the item records in the Link column. However, I received 3 issues and the first issue is not appearing on the serials collection page. The next 2 issues are with their links. (Image example attached). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38061 --- Comment #16 from Nathalie SAVARIT <nathalie.savarit@univ-amu.fr> --- Hi Ester. The issues are classified by year of publication (not by date received). The first issue must be on the ‘2024’ tab (publication 10/01/2024), which is why it does not appear with the others. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38061 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172297|0 |1 is obsolete| | --- Comment #17 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 176440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176440&action=edit Bug 38061: Add item column to serial collections table This patch adds a column to the table to link to the item Test plan: 1) Add a new subscription to a serial record (with the option 'create an item record' selected) 2) Receive several issues and create the linked items 3) Navigate to the serials collection table 4) There should be a column for the linked item 5) Click on one of the links, it should display the item Signed-off-by: Nathalie <nathalie.savarit@univ-amu.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38061 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172298|0 |1 is obsolete| | --- Comment #18 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 176441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176441&action=edit Bug 38061: Tidy serials-collection.pl Signed-off-by: Nathalie <nathalie.savarit@univ-amu.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38061 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172299|0 |1 is obsolete| | --- Comment #19 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 176442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176442&action=edit Bug 38061: Remove pre-selection of serials in the table Test plan: 1) Navigate to the serials-collection table 2) None of the checkboxes in the left hand column should be selected Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Nathalie <nathalie.savarit@univ-amu.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38061 Nathalie SAVARIT <nathalie.savarit@univ-amu.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #20 from Nathalie SAVARIT <nathalie.savarit@univ-amu.fr> --- Tested on Hackathon KohaLa Lyon, 13th january 2025. Feel free to give more details if you still have issues when testing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38061 Sophie Wawrzyniak <sophie.wawrzyniak@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sophie.wawrzyniak@univ-lyon | |3.fr --- Comment #21 from Sophie Wawrzyniak <sophie.wawrzyniak@univ-lyon3.fr> --- (In reply to Biblibre Sandboxes from comment #17)
Created attachment 176440 [details] [review] Bug 38061: Add item column to serial collections table
This patch adds a column to the table to link to the item
Test plan: 1) Add a new subscription to a serial record (with the option 'create an item record' selected) 2) Receive several issues and create the linked items 3) Navigate to the serials collection table 4) There should be a column for the linked item 5) Click on one of the links, it should display the item
Signed-off-by: Nathalie <nathalie.savarit@univ-amu.fr>
Can the 'linked item' column be editable ? (for example if the item is created retrospectively). Idea from hackathon KohaLa 2025. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38061 Melanie Catt <melanie.catt@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |melanie.catt@univ-lyon3.fr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38061 pjouve <pauline.jouve@enssib.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pauline.jouve@enssib.fr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38061 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com Attachment #176441|0 |1 is obsolete| | --- Comment #22 from Jonathan Druart <jonathan.druart@gmail.com> --- Comment on attachment 176441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176441 Bug 38061: Tidy serials-collection.pl We no longer want tidy patches. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38061 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |baptiste.wojtkowski@biblibr | |e.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38061 --- Comment #23 from Nathalie SAVARIT <nathalie.savarit@univ-amu.fr> --- Hi, what about Martin's proposition : "I think the two workflows can coexist! Let the user choose to switch between having the checkbox checked by default or unchecked by default, with a unchecked checkbox in the subscription. ;)" This was the most popular option at the Koha symposium working group this week. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38061 --- Comment #24 from Nathalie SAVARIT <nathalie.savarit@univ-amu.fr> --- And keep on current operation: if nothing is ticked, no issues can be received. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38061 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38061 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176440|0 |1 is obsolete| | --- Comment #25 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 179644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179644&action=edit Bug 38061: Add item column to serial collections table This patch adds a column to the table to link to the item Test plan: 1) Add a new subscription to a serial record (with the option 'create an item record' selected) 2) Receive several issues and create the linked items 3) Navigate to the serials collection table 4) There should be a column for the linked item 5) Click on one of the links, it should display the item Signed-off-by: Nathalie <nathalie.savarit@univ-amu.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38061 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176442|0 |1 is obsolete| | --- Comment #26 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 179645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179645&action=edit Bug 38061: Remove pre-selection of serials in the table Test plan: 1) Navigate to the serials-collection table 2) None of the checkboxes in the left hand column should be selected Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Nathalie <nathalie.savarit@univ-amu.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38061 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #27 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- This looks good and is working well in my testing. I am a bit hesitant to pass QA as there seems to be some disagreement about the initial state of check boxes? This is a change in behavior. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38061 --- Comment #28 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 182159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182159&action=edit Bug 38061: Add a checkbox to determine whether collection table issues should be pre-selected Test plan: Apply the patches and update the database 1) Create a new subscription with items, there should be a checkbox at the bottom of the form to pre-select collection table issues - make sure this is checked 2) Receive some items against the subscription 3) Navigate to the collections table 4) The checkboxes should be pre-selected as per previous behaviour in Koha 5) Edit the subscription and uncheck the checkbox 6) Return to the collections table and the checkboxes should all be unchecked -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38061 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #29 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- I've added a concept patch for Martin's suggestion. It adds a column to the subscription table to set whether the collections table should be pre-selected or not. Let me know if this meets the expected behaviour :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38061 --- Comment #30 from Nathalie SAVARIT <nathalie.savarit@univ-amu.fr> --- Hi Matthew, thanks for adding a concept patch for Martin's suggestion ! This is what the French community has been waiting for. That's fine for me. So there is no longer any ambiguity or disagreement about the initial state of check boxes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38061 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38061 Nathalie SAVARIT <nathalie.savarit@univ-amu.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #31 from Nathalie SAVARIT <nathalie.savarit@univ-amu.fr> --- This is what the French community has been waiting for. That's fine for me. So there is no longer any ambiguity or disagreement about the initial state of check boxes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38061 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182159|0 |1 is obsolete| | --- Comment #32 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 183141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183141&action=edit Bug 38061: Add a checkbox to determine whether collection table issues should be pre-selected Test plan: Apply the patches and update the database 1) Create a new subscription with items, there should be a checkbox at the bottom of the form to pre-select collection table issues - make sure this is checked 2) Receive some items against the subscription 3) Navigate to the collections table 4) The checkboxes should be pre-selected as per previous behaviour in Koha 5) Edit the subscription and uncheck the checkbox 6) Return to the collections table and the checkboxes should all be unchecked Signed-off-by: Nathalie <nathalie.savarit@univ-amu.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38061 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |baptiste.wojtkowski@biblibr |y.org |e.com --- Comment #33 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Hi, there is a little issue with the QA script: FAIL tinyint_has_boolean_flag The new column subscription.preselect_issues_in_collections_table is using TINYINT(1) as type but is not defined as boolean in the schema file (Koha/Schema/Result/Subscription.pm), see the SQL12 coding guideline -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38061 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179644|0 |1 is obsolete| | --- Comment #34 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 183433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183433&action=edit Bug 38061: Add item column to serial collections table This patch adds a column to the table to link to the item Test plan: 1) Add a new subscription to a serial record (with the option 'create an item record' selected) 2) Receive several issues and create the linked items 3) Navigate to the serials collection table 4) There should be a column for the linked item 5) Click on one of the links, it should display the item Signed-off-by: Nathalie <nathalie.savarit@univ-amu.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38061 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179645|0 |1 is obsolete| | --- Comment #35 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 183434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183434&action=edit Bug 38061: Remove pre-selection of serials in the table Test plan: 1) Navigate to the serials-collection table 2) None of the checkboxes in the left hand column should be selected Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Nathalie <nathalie.savarit@univ-amu.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38061 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183141|0 |1 is obsolete| | --- Comment #36 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 183435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183435&action=edit Bug 38061: Add a checkbox to determine whether collection table issues should be pre-selected Test plan: Apply the patches and update the database 1) Create a new subscription with items, there should be a checkbox at the bottom of the form to pre-select collection table issues - make sure this is checked 2) Receive some items against the subscription 3) Navigate to the collections table 4) The checkboxes should be pre-selected as per previous behaviour in Koha 5) Edit the subscription and uncheck the checkbox 6) Return to the collections table and the checkboxes should all be unchecked Signed-off-by: Nathalie <nathalie.savarit@univ-amu.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38061 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|baptiste.wojtkowski@biblibr | |e.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38061 Mathieu Saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored CC| |mathsabypro@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38061 --- Comment #37 from Mathieu Saby <mathsabypro@gmail.com> --- This patch was sponsored by Kohala association, but it is no more visible in the commit. Could you add back this information please? Kohala association would be glad to see it pushed for the next release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38061 --- Comment #38 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 186273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186273&action=edit Bug 38061: (QA follow-up) Add default falsy value for subscription creation/editing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38061 --- Comment #39 from Mathieu Saby <mathsabypro@gmail.com> --- Baptiste, did you have any other comments regarding the QA for this patch? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38061 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |baptiste.wojtkowski@biblibr | |e.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38061 --- Comment #40 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 190234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190234&action=edit Bug 38061: (QA follow-up): dbrev: print if column already exists -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38061 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183433|0 |1 is obsolete| | --- Comment #41 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 190235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190235&action=edit Bug 38061: Add item column to serial collections table This patch adds a column to the table to link to the item Test plan: 1) Add a new subscription to a serial record (with the option 'create an item record' selected) 2) Receive several issues and create the linked items 3) Navigate to the serials collection table 4) There should be a column for the linked item 5) Click on one of the links, it should display the item Signed-off-by: Nathalie <nathalie.savarit@univ-amu.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38061 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183435|0 |1 is obsolete| | --- Comment #42 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 190236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190236&action=edit Bug 38061: Add a checkbox to determine whether collection table issues should be pre-selected Test plan: Apply the patches and update the database 1) Create a new subscription with items, there should be a checkbox at the bottom of the form to pre-select collection table issues - make sure this is checked 2) Receive some items against the subscription 3) Navigate to the collections table 4) The checkboxes should be pre-selected as per previous behaviour in Koha 5) Edit the subscription and uncheck the checkbox 6) Return to the collections table and the checkboxes should all be unchecked Signed-off-by: Nathalie <nathalie.savarit@univ-amu.fr> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38061 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186273|0 |1 is obsolete| | --- Comment #43 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 190237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190237&action=edit Bug 38061: (QA follow-up) Add default falsy value for subscription creation/editing Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38061 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190234|0 |1 is obsolete| | --- Comment #44 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 190238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190238&action=edit Bug 38061: (QA follow-up): dbrev: print if column already exists Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38061 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183434|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38061 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38061 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190235|0 |1 is obsolete| | --- Comment #45 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 190289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190289&action=edit Bug 38061: Add item column to serial collections table This patch adds a column to the table to link to the item Test plan: 1) Add a new subscription to a serial record (with the option 'create an item record' selected) 2) Receive several issues and create the linked items 3) Navigate to the serials collection table 4) There should be a column for the linked item 5) Click on one of the links, it should display the item Signed-off-by: Nathalie <nathalie.savarit@univ-amu.fr> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38061 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190236|0 |1 is obsolete| | --- Comment #46 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 190290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190290&action=edit Bug 38061: Add a checkbox to determine whether collection table issues should be pre-selected Test plan: Apply the patches and update the database 1) Create a new subscription with items, there should be a checkbox at the bottom of the form to pre-select collection table issues - make sure this is checked 2) Receive some items against the subscription 3) Navigate to the collections table 4) The checkboxes should be pre-selected as per previous behaviour in Koha 5) Edit the subscription and uncheck the checkbox 6) Return to the collections table and the checkboxes should all be unchecked Signed-off-by: Nathalie <nathalie.savarit@univ-amu.fr> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38061 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190237|0 |1 is obsolete| | --- Comment #47 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 190291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190291&action=edit Bug 38061: (QA follow-up) Add default falsy value for subscription creation/editing Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38061 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190238|0 |1 is obsolete| | --- Comment #48 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 190292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190292&action=edit Bug 38061: (QA follow-up): dbrev: print if column already exists Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38061 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This introduces for each release notes| |new and existing | |subscription a field named | |"Pre-select issues in the | |collections table" CC| |victor@tuxayo.net --- Comment #49 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Thanks Baptiste. I also confirm the test plan passes and code looks good. note for RM: preselect_issues_in_collections_table is at false by default (new and existing installs, for each new and existing subscription)
From what we understand from the comments it seems ok but that's worth highlighting here.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38061 Mathieu Saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Comma delimited| |Association KohaLa list of Sponsors| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38061 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38061 --- Comment #50 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38061 --- Comment #51 from Nathalie SAVARIT <nathalie.savarit@univ-amu.fr> --- Nice work everyone! Looking forward to upgrading to 26.05 ! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38061 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting --- Comment #52 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- This bug won't be backported to the 25.11.x branch as it has been deemed an enhancement or new feature. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org