https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21584 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20978, 2696 Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 [Bug 2696] Fine payments should show what was paid for https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 [Bug 20978] Add Koha::Account::add_credit -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21584 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 80676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80676&action=edit Bug 21584: Wrong offset type for Lost Item Bug 2696 introduced account_offset_type.inc but 'Lost Item Return' doesn't match what is added on the database. Moreover, bug 20978 added references to this wrong value too in Koha::Account This patch performs a trivial fix for this. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21584 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13098 Keywords| |rel_18_11_candidate Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13098 [Bug 13098] Item lost multiple times by the same patron will create only be charged once -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21584 --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- The original bug is in: koha-tmpl/intranet-tmpl/prog/en/includes/account_offset_type.inc it is not easy to 'reproduce', as the code that should generate credit return offsets is not working properly (bug 13098). This is my attempt: - View the following file: installer/data/mysql/account_offset_types.sql $ less installer/data/mysql/account_offset_types.sql - Notice there's 'Lost Item' in line 4 - View koha-tmpl/intranet-tmpl/prog/en/includes/account_offset_type.inc $ less koha-tmpl/intranet-tmpl/prog/en/includes/account_offset_type.inc - Notice it maps the values from the account_offset_types.sql file into english descriptions. => FAIL: There's no mapping for 'Lost Item', but there's a mapping for 'Lost Item Return', which doesn't really exist in account_offset_types.sql - Apply the patch => SUCCESS: The value <-> description mapping in account_offset_type.inc makes sense now. It respects the values that would be stored on the DB if the feature worked correctly. => BONUS: Koha/Account.pm gets fixed to generate the right value too. Notice there's a hash with mappings for some keywords into both account_offset_types and account types. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21584 --- Comment #4 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81048&action=edit Bug 21584: Wrong offset type for Lost Item Bug 2696 introduced account_offset_type.inc but 'Lost Item Return' doesn't match what is added on the database. Moreover, bug 20978 added references to this wrong value too in Koha::Account This patch performs a trivial fix for this. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Patch matches what was outlined in test plan, also passes qa test tool Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21584 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21584 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21584 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED CC| |martin.renvoize@ptfs-europe | |.com --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Causation bug 20978 not in 18.05.x series. -- You are receiving this mail because: You are watching all bug changes.