[Bug 21614] New: Search bar on Stock rotation page displays both [-] and [+] simultaneously
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21614 Bug ID: 21614 Summary: Search bar on Stock rotation page displays both [-] and [+] simultaneously Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org When I go to the stock rotation page, the search bar at the top of the page is set to "Search patrons" and both [-] and [+] are displayed. To reproduce: 1) Activate stock rotation module in system preferences 2) Go to Tools > Stock rotation 3) Notice the [-] and [+] next to the search bar at the top 4) Try clicking on [-] and [+], nothing happens -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21614 --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I'm not sure what is the decision process to choose which search bar to put at the top of a page, but I feel like "Search patrons" is not useful in this case. I would put the same search bar as in "Rotation collections" with Check out, Check in, Renew and Search the catalog, the latter being selected by default. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21614 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Severity|enhancement |normal Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21614 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21614 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 80931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80931&action=edit Bug 21614: Search bar on Stock rotation page displays both [-] and [+] simultaneously This patch modifies the stock rotation template so that it include the circulation search bar include instead of the patrons one. To test, apply the patch and enable the StockRotation system preference. - Go to Tools -> Stock rotation. - Confirm that the search boxes at top are 'Check out,' 'Check in,' 'Renew,' and 'Search the catalog.' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21614 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Owen, can you select "Search the catalog" by default, instead of "Check out"? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21614 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21614 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80931|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 80987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80987&action=edit Bug 21614: Search bar on Stock rotation page displays both [-] and [+] simultaneously This patch modifies the stock rotation template so that it include the catalog search bar include instead of the patrons one. To test, apply the patch and enable the StockRotation system preference. - Go to Tools -> Stock rotation. - Confirm that the search boxes at top are 'Check out,' 'Check in,' 'Renew,' and 'Search the catalog.' 'Search the catalog' should be selected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21614 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21614 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80987|0 |1 is obsolete| | --- Comment #5 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 80991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80991&action=edit Bug 21614: Search bar on Stock rotation page displays both [-] and [+] simultaneously This patch modifies the stock rotation template so that it include the catalog search bar include instead of the patrons one. To test, apply the patch and enable the StockRotation system preference. - Go to Tools -> Stock rotation. - Confirm that the search boxes at top are 'Check out,' 'Check in,' 'Renew,' and 'Search the catalog.' 'Search the catalog' should be selected. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21614 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21614 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80991|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 81026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81026&action=edit Bug 21614: Search bar on Stock rotation page displays both [-] and [+] simultaneously This patch modifies the stock rotation template so that it include the catalog search bar include instead of the patrons one. To test, apply the patch and enable the StockRotation system preference. - Go to Tools -> Stock rotation. - Confirm that the search boxes at top are 'Check out,' 'Check in,' 'Renew,' and 'Search the catalog.' 'Search the catalog' should be selected. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21614 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21614 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Depends on| |11897 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 [Bug 11897] Stock Rotation for Koha -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21614 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Dependency not in 18.05.x series. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org