[Bug 40794] New: Add an id to the div containing payments tabs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40794 Bug ID: 40794 Summary: Add an id to the div containing payments tabs Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: mathsabypro@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle@bywatersolutions.com In payment pages (pay.pl etc) there is a menu with 4 tabs (Transactions, make a payment...) In Koha 23.11 the div for this menu had an id (toptabs). It is no more the case (I suppose this is because toptabs is now used for the general top-bar menu of Koha). It would be nice to add a new id to this div, to help code manipulation with CSS/JS -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40794 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40794 --- Comment #1 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 186976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186976&action=edit Bug 40794: Add id='account-tabs' wrapper to payment and account tab templates This patch adds a new id="account-tabs" to that div. To test: Apply the patch and restart_all. Clear browser cache if necessary. 1. Go to a patron’s accounting tab → Transactions / Make payment / Manual invoice / Manual credit. 2. Inspect the HTML for the tabs menu. The surrounding div should have both class="toptabs" and id="account-tabs". 3. Verify styling and tab functionality remain unchanged. 4. Sign off and have a great day! :D -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40794 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com Assignee|koha-bugs@lists.koha-commun |Laura.escamilla@bywatersolu |ity.org |tions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40794 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |An id="account-tabs" release notes| |attribute has been added to | |the account/payment tab | |navigation (Transactions, | |Make a payment, Create | |manual invoice, Create | |manual credit). This allows | |for easier customization | |and targeting with CSS/JS | |without conflicting with | |the global toptabs | |navigation. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40794 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40794 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186976|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 190031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190031&action=edit Bug 40794: Add id='account-tabs' wrapper to payment and account tab templates This patch adds a new id="account-tabs" to that div. To test: Apply the patch and restart_all. Clear browser cache if necessary. 1. Go to a patron’s accounting tab → Transactions / Make payment / Manual invoice / Manual credit. 2. Inspect the HTML for the tabs menu. The surrounding div should have both class="toptabs" and id="account-tabs". 3. Verify styling and tab functionality remain unchanged. 4. Sign off and have a great day! :D Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40794 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40794 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190031|0 |1 is obsolete| | --- Comment #3 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 191777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191777&action=edit Bug 40794: Add id='account-tabs' wrapper to payment and account tab templates This patch adds a new id="account-tabs" to that div. To test: Apply the patch and restart_all. Clear browser cache if necessary. 1. Go to a patron’s accounting tab → Transactions / Make payment / Manual invoice / Manual credit. 2. Inspect the HTML for the tabs menu. The surrounding div should have both class="toptabs" and id="account-tabs". 3. Verify styling and tab functionality remain unchanged. 4. Sign off and have a great day! :D Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40794 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40794 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40794 --- Comment #4 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40794 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.05.00 |26.05.00,25.11.02 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40794 --- Comment #5 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40794 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #6 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Enhancement - Not backporting to 25.05 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org