[Bug 41214] New: Cash register should only show if UseCashRegisters sys pref is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41214 Bug ID: 41214 Summary: Cash register should only show if UseCashRegisters sys pref is enabled Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: pedro.amorim@openfifth.co.uk QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41214 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41214 --- Comment #1 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 189263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189263&action=edit Bug 41214: Only show cash register if UseCashRegisters sys pref is enabled Test plan: 1) Add a new account: http://localhost:8081/cgi-bin/koha/sip2/accounts/add 2) Notice the 'cash register' field does not show 3) Enable UseCashRegisters sys pref 4) Repeat 1 (or edit an existing account). Refresh the page. 5) Notice the 'cash register' field now shows -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41214 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@openfifth.co.u | |k Depends on| |37893 Assignee|koha-bugs@lists.koha-commun |pedro.amorim@openfifth.co.u |ity.org |k Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 [Bug 37893] Migrate some SIP configuration into the staff interface -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41214 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com, | |martin.renvoize@openfifth.c | |o.uk, | |matt.blenkinsop@openfifth.c | |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41214 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Can we have a cypress test for this? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41214 --- Comment #3 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 189322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189322&action=edit Bug 41214: Add cypress test cypress run --spec t/cypress/integration/SIP2/Accounts.ts --config video=false,screenshotOnRunFailure=false -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41214 --- Comment #4 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 189695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189695&action=edit Bug 41214: Convert hideIn to a callback to allow total removal of fields via syspref -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41214 --- Comment #5 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 189697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189697&action=edit Bug 41214: Apply the same logic to table columns -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41214 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189697|0 |1 is obsolete| | --- Comment #6 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 189698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189698&action=edit Bug 41214: Apply the same logic to table columns -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41214 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41214 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189263|0 |1 is obsolete| | --- Comment #7 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 189699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189699&action=edit Bug 41214: Only show cash register if UseCashRegisters sys pref is enabled Test plan: 1) Add a new account: http://localhost:8081/cgi-bin/koha/sip2/accounts/add 2) Notice the 'cash register' field does not show 3) Enable UseCashRegisters sys pref 4) Repeat 1 (or edit an existing account). Refresh the page. 5) Notice the 'cash register' field now shows Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41214 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189322|0 |1 is obsolete| | --- Comment #8 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 189700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189700&action=edit Bug 41214: Add cypress test cypress run --spec t/cypress/integration/SIP2/Accounts.ts --config video=false,screenshotOnRunFailure=false Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41214 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189695|0 |1 is obsolete| | --- Comment #9 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 189701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189701&action=edit Bug 41214: Convert hideIn to a callback to allow total removal of fields via syspref Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41214 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189698|0 |1 is obsolete| | --- Comment #10 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 189702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189702&action=edit Bug 41214: Apply the same logic to table columns Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41214 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41214 --- Comment #11 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Thanks Matt for the follow-ups, that is a better approach here imo. I'm moving this to Signed-off with both mine and Matt's SO lines for the following reasons: 1) We both worked on this (and tested it) and we're both happy with the solution here. 2) It's a small patch with core VueJS framework changes i.e. make 'hideIn' be optionally used as a callback. Setting Joubu as QA contact as it makes sense. I'm happy to put it back to NSO if the above reasons are not enough for SO. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41214 --- Comment #12 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 189902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189902&action=edit Bug 41214: Only show cash register if UseCashRegisters sys pref is enabled Test plan: 1) Add a new account: http://localhost:8081/cgi-bin/koha/sip2/accounts/add 2) Notice the 'cash register' field does not show 3) Enable UseCashRegisters sys pref 4) Repeat 1 (or edit an existing account). Refresh the page. 5) Notice the 'cash register' field now shows Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41214 --- Comment #13 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 189903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189903&action=edit Bug 41214: Add cypress test cypress run --spec t/cypress/integration/SIP2/Accounts.ts --config video=false,screenshotOnRunFailure=false Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41214 --- Comment #14 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 189904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189904&action=edit Bug 41214: Convert hideIn to a callback to allow total removal of fields via syspref Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41214 --- Comment #15 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 189905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189905&action=edit Bug 41214: Apply the same logic to table columns Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41214 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41214 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189699|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41214 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189700|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41214 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189701|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41214 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189702|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41214 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_26_05_candidate CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41214 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #16 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- This files seem to not be tidy: [FAIL] koha-tmpl/intranet-tmpl/prog/js/vue/components/FormElement.vue FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl koha-tmpl/intranet-tmpl/prog/js/vue/components/FormElement.vue` [FAIL] koha-tmpl/intranet-tmpl/prog/js/vue/components/ResourceList.vue FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl koha-tmpl/intranet-tmpl/prog/js/vue/components/ResourceList.vue` [PASS] koha-tmpl/intranet-tmpl/prog/js/vue/components/SIP2/Main.vue [FAIL] koha-tmpl/intranet-tmpl/prog/js/vue/components/SIP2/SIP2AccountResource.vue FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl koha-tmpl/intranet-tmpl/prog/js/vue/components/SIP2/SIP2AccountResource.vue` [FAIL] koha-tmpl/intranet-tmpl/prog/js/vue/composables/base-resource.js FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl koha-tmpl/intranet-tmpl/prog/js/vue/composables/base-resource.js` When I run tidy.pl on the, a diff is generated. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41214 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41214 --- Comment #17 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 191343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191343&action=edit Bug 41214: (QA follow-up): Tidy fix -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41214 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41214 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This change turns the release notes| |display of the 'cash | |register' field in SIP2 | |accounts to become | |conditional depending on | |whether the | |UseCashRegisters sys pref | |is enabled or not. | |For developers: This | |changes the hideIn option | |for VueJS framework | |resources, now allowing it | |to be a callback function | |which is checked in | |real-time, dictating | |whether a field is | |displayed or not. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41214 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41214 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41214 --- Comment #18 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41214 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_26_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41214 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00 |26.05.00,25.11.03 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41214 --- Comment #19 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41214 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to stable |Needs documenting --- Comment #20 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Enhancement - Not backporting to 25.05 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org