[Bug 19640] New: IdRef webservice display is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19640 Bug ID: 19640 Summary: IdRef webservice display is broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org The OPAC webservice IdRef display is broken. The call returns results but citations are empty. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19640 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19640 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8992 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8992 [Bug 8992] Add an interfacing with the idref webservice -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19640 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19640 --- Comment #1 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 69181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69181&action=edit Display of IdRef broken -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19640 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19640 --- Comment #2 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 69182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69182&action=edit Bug 19640: fix OPAC IdRef webservice display The OPAC webservice IdRef display was broken. The call returns results but citations where empty. Maybe the webservice has changed. This patch corrects the fetch of datas in result. Also fixes a small HTML missing tag tr. Also adds a comment with link to official doc : http://documentation.abes.fr/aideidrefdeveloppeur/index.html#MicroWebBiblio Test plan : 1) Enable system preference IdRef 2) Choose an existing PPN like 032581270 3) Look result on : https://www.idref.fr/services/biblio/032581270.json 4) Call in OPAC website : /cgi-bin/koha/opac-idref.pl?unimarc3=032581270 5) Without patch you see only one role containing empty rows 6) With patch you see all roles with correct rows -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19640 Simon Pouchol <simon.pouchol@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69182|0 |1 is obsolete| | --- Comment #3 from Simon Pouchol <simon.pouchol@biblibre.com> --- Created attachment 69196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69196&action=edit Bug 19640: fix OPAC IdRef webservice display The OPAC webservice IdRef display was broken. The call returns results but citations where empty. Maybe the webservice has changed. This patch corrects the fetch of datas in result. Also fixes a small HTML missing tag tr. Also adds a comment with link to official doc : http://documentation.abes.fr/aideidrefdeveloppeur/index.html#MicroWebBiblio Test plan : 1) Enable system preference IdRef 2) Choose an existing PPN like 032581270 3) Look result on : https://www.idref.fr/services/biblio/032581270.json 4) Call in OPAC website : /cgi-bin/koha/opac-idref.pl?unimarc3=032581270 5) Without patch you see only one role containing empty rows 6) With patch you see all roles with correct rows Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19640 Simon Pouchol <simon.pouchol@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |simon.pouchol@biblibre.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19640 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19640 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69196|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 69332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69332&action=edit Bug 19640: fix OPAC IdRef webservice display The OPAC webservice IdRef display was broken. The call returns results but citations where empty. Maybe the webservice has changed. This patch corrects the fetch of datas in result. Also fixes a small HTML missing tag tr. Also adds a comment with link to official doc : http://documentation.abes.fr/aideidrefdeveloppeur/index.html#MicroWebBiblio Test plan : 1) Enable system preference IdRef 2) Choose an existing PPN like 032581270 3) Look result on : https://www.idref.fr/services/biblio/032581270.json 4) Call in OPAC website : /cgi-bin/koha/opac-idref.pl?unimarc3=032581270 5) Without patch you see only one role containing empty rows 6) With patch you see all roles with correct rows Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Amended: removed unused @unimarc3 (not to be confused with $unimarc3). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19640 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Severity|minor |normal QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19640 --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Does not seem to affect translation. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19640 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19640 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Pushed to Master |Pushed to Stable --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Pushed to stable for 17.11.01, awesome work all! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19640 --- Comment #8 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x, will be in v17.05.07 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org