https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18833 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|plugin unimarc_210c |plugin unimarc_field_210c |pagination error |pagination error -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18833 --- Comment #1 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 64486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64486&action=edit Bug 18833 - plugin unimarc_field_210c pagination error In plugin unimarc_field_210c, the editors search results have pagination. First page works but not other pages. The main problem whas mainly because $startfrom var was missused. It is defined in C4::Output::pagination_bar as page number. This patch corrects by using a $offset var. Also removes dead code, obsoleted by using C4::Output::pagination_bar. Also changes hardcoded results per page from 19 to 20. Test plan : - Use UNIMARC catalogue - Define in framework value builder unimarc_field_210c on 210$c - Create autority type EDITORS with heading 200$b - Create 22 authorities of that type - Index those new authorities - Create a new biblio record - Click on 210$c plugin - Click on "Search" - You see 20 results - Click on page 2 => Without patch you get empty table => With patch you get 2 results - Check that you see "Results 21 to 22 of 22" - Delete 2 autorities and retest -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18833 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18833 Simon Pouchol <simon.pouchol@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |simon.pouchol@biblibre.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18833 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68295|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 69190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69190&action=edit Bug 18833 - plugin unimarc_field_210c pagination error In plugin unimarc_field_210c, the editors search results have pagination. First page works but not other pages. The main problem whas mainly because $startfrom var was missused. It is defined in C4::Output::pagination_bar as page number. This patch corrects by using a $offset var. Also removes dead code, obsoleted by using C4::Output::pagination_bar. Also changes hardcoded results per page from 19 to 20. Test plan : - Use UNIMARC catalogue - Define in framework value builder unimarc_field_210c on 210$c - Create autority type EDITORS with heading 200$b - Create 22 authorities of that type - Index those new authorities - Create a new biblio record - Click on 210$c plugin - Click on "Search" - You see 20 results - Click on page 2 => Without patch you get empty table => With patch you get 2 results - Check that you see "Results 21 to 22 of 22" - Delete 2 autorities and retest Works as intended. Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18833 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18833 --- Comment #7 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x, will be in v17.05.07 -- You are receiving this mail because: You are watching all bug changes.