[Bug 24161] New: Late orders improvements - keeping track of claims
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 Bug ID: 24161 Summary: Late orders improvements - keeping track of claims Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org * Allow multiple claim dates to be associated with an individual order line * Show multiple claim dates against an order line in the late orders page * Show multiple claim dates against an order line in the basket page -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24162 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24162 [Bug 24162] Late orders improvements - display new columns -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org CC| |mark.gavillet@ptfs-europe.c | |om -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 97114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97114&action=edit Bug 24161: DB changes Sponsored-by: Cork Institute of Technology -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 97115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97115&action=edit Bug 24161: DBIC changes Sponsored-by: Cork Institute of Technology -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 97116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97116&action=edit Bug 24161: Add the Koha::Acquisition::Order::Claim[s] classes Sponsored-by: Cork Institute of Technology -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 97117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97117&action=edit Bug 24161: Keep tracks of late orders claims So far we only record the number of claims and the date of the last claim, in the aqorders table. To keep track of the different claim dates, this patchset is going to make the following DB changes: * Create a new table 'aqorders_claims' (id, ordernumber, claimed_on) * Remove the two columns from the aqorders table: claims_count and claimed_date This will allow to display the different claim dates where needed: on the late orders page, and the basket page. To avoid additional fetches of Koha::Acquisition::Orders, GetLateOrders has been moved to Koha::Acquisition::Orders->filter_by_late That way we are going to add consistency, robustness, and cover the feature with new tests. Test plan: 0/ Create a bunch of new orders. Make sure they are from different vendor (with different delivery time). 1/ Go to the late orders page and claim some orders 2/ Reclaim some of those orders 3/ Confirm that you can see the different claim dates for a given orders (the history of the late orders claims is kept and displayed) 4/ Bonus point: Regression tests: a. Modify the closedate of the basket in the database. That will allow you to make sure the patch set did not introduce regressions. It would be good to test the different filters on the late orders page: * delay * Estimated delivery date from/to * Vendor b. Confirm that the subtotal and the total values from the late orders page is correct. c. Test the update database entry: do not apply these patches, claims some orders against master. Apply the patch, execute the update DB entry then confirm that the number of claims is correct (note that the dates will not as it is not possible to guess them). QA note: the branchcode parameter has been removed from filter_by_late. At first glance it seems that it was not used. Sponsored-by: Cork Institute of Technology -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 97118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97118&action=edit Bug 24161: Remove GetLateOrders Sponsored-by: Cork Institute of Technology -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 97119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97119&action=edit Bug 24161: Add tests Sponsored-by: Cork Institute of Technology -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12502 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502 [Bug 12502] Add columns for note, order number and ISBN to late orders page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|24162 |24163 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24162 [Bug 24162] Late orders improvements - display new columns https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24163 [Bug 24163] Ability to define a CSV profile for late orders export -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | Version|unspecified |master CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Jonathan, working on this tree - can you please do a quick rebase/check? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97117|0 |1 is obsolete| | Attachment #97118|0 |1 is obsolete| | Attachment #97119|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 97470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97470&action=edit Bug 24161: Keep tracks of late orders claims So far we only record the number of claims and the date of the last claim, in the aqorders table. To keep track of the different claim dates, this patchset is going to make the following DB changes: * Create a new table 'aqorders_claims' (id, ordernumber, claimed_on) * Remove the two columns from the aqorders table: claims_count and claimed_date This will allow to display the different claim dates where needed: on the late orders page, and the basket page. To avoid additional fetches of Koha::Acquisition::Orders, GetLateOrders has been moved to Koha::Acquisition::Orders->filter_by_late That way we are going to add consistency, robustness, and cover the feature with new tests. Test plan: 0/ Create a bunch of new orders. Make sure they are from different vendor (with different delivery time). 1/ Go to the late orders page and claim some orders 2/ Reclaim some of those orders 3/ Confirm that you can see the different claim dates for a given orders (the history of the late orders claims is kept and displayed) 4/ Bonus point: Regression tests: a. Modify the closedate of the basket in the database. That will allow you to make sure the patch set did not introduce regressions. It would be good to test the different filters on the late orders page: * delay * Estimated delivery date from/to * Vendor b. Confirm that the subtotal and the total values from the late orders page is correct. c. Test the update database entry: do not apply these patches, claims some orders against master. Apply the patch, execute the update DB entry then confirm that the number of claims is correct (note that the dates will not as it is not possible to guess them). QA note: the branchcode parameter has been removed from filter_by_late. At first glance it seems that it was not used. Sponsored-by: Cork Institute of Technology -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 97471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97471&action=edit Bug 24161: Remove GetLateOrders Sponsored-by: Cork Institute of Technology -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 97472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97472&action=edit Bug 24161: Add tests Sponsored-by: Cork Institute of Technology -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer@bsz-bw.de | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I had already started here yesterday, so trying to clean up my notes: +=head3 authorizer Wonder if we should make this 'creator', as we have discussed for the API endpoint. Missing description in the updatedatabase: + print "Upgrade to $DBversion done (Bug XXXXX - description)\n"; Both not blocking further testing! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 Bug 24161 depends on bug 12502, which changed state. Bug 12502 Summary: Add columns for note, order number and ISBN to late orders page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97472|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98280&action=edit Bug 24161: Add tests Sponsored-by: Cork Institute of Technology -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97114|0 |1 is obsolete| | Attachment #97115|0 |1 is obsolete| | Attachment #97116|0 |1 is obsolete| | Attachment #97470|0 |1 is obsolete| | Attachment #97471|0 |1 is obsolete| | Attachment #98280|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98522&action=edit Bug 24161: DB changes Sponsored-by: Cork Institute of Technology -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98523&action=edit Bug 24161: DBIC changes Sponsored-by: Cork Institute of Technology -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98524&action=edit Bug 24161: Add the Koha::Acquisition::Order::Claim[s] classes Sponsored-by: Cork Institute of Technology -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98525&action=edit Bug 24161: Keep tracks of late orders claims So far we only record the number of claims and the date of the last claim, in the aqorders table. To keep track of the different claim dates, this patchset is going to make the following DB changes: * Create a new table 'aqorders_claims' (id, ordernumber, claimed_on) * Remove the two columns from the aqorders table: claims_count and claimed_date This will allow to display the different claim dates where needed: on the late orders page, and the basket page. To avoid additional fetches of Koha::Acquisition::Orders, GetLateOrders has been moved to Koha::Acquisition::Orders->filter_by_late That way we are going to add consistency, robustness, and cover the feature with new tests. Test plan: 0/ Create a bunch of new orders. Make sure they are from different vendor (with different delivery time). 1/ Go to the late orders page and claim some orders 2/ Reclaim some of those orders 3/ Confirm that you can see the different claim dates for a given orders (the history of the late orders claims is kept and displayed) 4/ Bonus point: Regression tests: a. Modify the closedate of the basket in the database. That will allow you to make sure the patch set did not introduce regressions. It would be good to test the different filters on the late orders page: * delay * Estimated delivery date from/to * Vendor b. Confirm that the subtotal and the total values from the late orders page is correct. c. Test the update database entry: do not apply these patches, claims some orders against master. Apply the patch, execute the update DB entry then confirm that the number of claims is correct (note that the dates will not as it is not possible to guess them). QA note: the branchcode parameter has been removed from filter_by_late. At first glance it seems that it was not used. Sponsored-by: Cork Institute of Technology -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98526&action=edit Bug 24161: Remove GetLateOrders Sponsored-by: Cork Institute of Technology -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 --- Comment #18 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98527&action=edit Bug 24161: Add tests Sponsored-by: Cork Institute of Technology -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24388 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24388 [Bug 24388] Useless test in acqui/lateorders.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 Angela <angela.oconnordesmond@staff.ittralee.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |angela.oconnordesmond@staff | |.ittralee.ie --- Comment #19 from Angela <angela.oconnordesmond@staff.ittralee.ie> --- The development which adds multiple claim dates is available for testing on the following sandbox: http://staff-bug24161.sandboxes.ptfs-europe.co.uk. To ensure it is working correctly please follow these steps: 1. Create multiple orders against two or more vendors and close the baskets 2. On the late orders page, claim some of the orders 3. The date of the claim will be displayed in the "Claimed date" column 4. Make more claims against the same items 5. You should now see multiple dates listed in the "Claimed date" column Nothing happens when claim button on late orders page clicked. Error message "connect to localhost failed (Connection refused) connect to localhost failed connect to localhost failed (Connection refused) no (more) retries!" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 --- Comment #20 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Angela from comment #19) Hello Angela, You get this error because there is no MTA (mail system) configured on the sandbox. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98522|0 |1 is obsolete| | --- Comment #21 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 102111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102111&action=edit Bug 24161: DB changes Sponsored-by: Cork Institute of Technology -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98523|0 |1 is obsolete| | --- Comment #22 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 102112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102112&action=edit Bug 24161: DBIC changes Sponsored-by: Cork Institute of Technology -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98524|0 |1 is obsolete| | --- Comment #23 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 102113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102113&action=edit Bug 24161: Add the Koha::Acquisition::Order::Claim[s] classes Sponsored-by: Cork Institute of Technology -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98525|0 |1 is obsolete| | --- Comment #24 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 102114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102114&action=edit Bug 24161: Keep tracks of late orders claims So far we only record the number of claims and the date of the last claim, in the aqorders table. To keep track of the different claim dates, this patchset is going to make the following DB changes: * Create a new table 'aqorders_claims' (id, ordernumber, claimed_on) * Remove the two columns from the aqorders table: claims_count and claimed_date This will allow to display the different claim dates where needed: on the late orders page, and the basket page. To avoid additional fetches of Koha::Acquisition::Orders, GetLateOrders has been moved to Koha::Acquisition::Orders->filter_by_late That way we are going to add consistency, robustness, and cover the feature with new tests. Test plan: 0/ Create a bunch of new orders. Make sure they are from different vendor (with different delivery time). 1/ Go to the late orders page and claim some orders 2/ Reclaim some of those orders 3/ Confirm that you can see the different claim dates for a given orders (the history of the late orders claims is kept and displayed) 4/ Bonus point: Regression tests: a. Modify the closedate of the basket in the database. That will allow you to make sure the patch set did not introduce regressions. It would be good to test the different filters on the late orders page: * delay * Estimated delivery date from/to * Vendor b. Confirm that the subtotal and the total values from the late orders page is correct. c. Test the update database entry: do not apply these patches, claims some orders against master. Apply the patch, execute the update DB entry then confirm that the number of claims is correct (note that the dates will not as it is not possible to guess them). QA note: the branchcode parameter has been removed from filter_by_late. At first glance it seems that it was not used. Sponsored-by: Cork Institute of Technology -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98526|0 |1 is obsolete| | --- Comment #25 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 102115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102115&action=edit Bug 24161: Remove GetLateOrders Sponsored-by: Cork Institute of Technology -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98527|0 |1 is obsolete| | --- Comment #26 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 102116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102116&action=edit Bug 24161: Add tests Sponsored-by: Cork Institute of Technology -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 --- Comment #27 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Rebased -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 --- Comment #28 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Updated PTFS-E sandboxes to support email.. emails will not be delivered externally but will go into a log file which can be accessed via the 'Logs' menu in the sandbox UI -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 --- Comment #29 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 102220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102220&action=edit Bug 24161: DBIC manual changes No idea what's happening with the current_timestamp, but previous change was wrong. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102220|0 |1 is obsolete| | --- Comment #30 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 102222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102222&action=edit Bug 24161: DBIC manual changes No idea what's happening with the current_timestamp, but previous change was wrong. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 --- Comment #31 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Feedback from sponsor testing. (1) The 'claimed date' field lists the claimed dates side by side, could they be stacked vertically instead with most recent at the top? (2) The 'estimated delivery date from - to' filter appears to be broken (3) The 'vendor' filter does not list all vendors? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102114|0 |1 is obsolete| | Attachment #102115|0 |1 is obsolete| | Attachment #102116|0 |1 is obsolete| | Attachment #102222|0 |1 is obsolete| | --- Comment #32 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 103567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103567&action=edit Bug 24161: Keep tracks of late orders claims So far we only record the number of claims and the date of the last claim, in the aqorders table. To keep track of the different claim dates, this patchset is going to make the following DB changes: * Create a new table 'aqorders_claims' (id, ordernumber, claimed_on) * Remove the two columns from the aqorders table: claims_count and claimed_date This will allow to display the different claim dates where needed: on the late orders page, and the basket page. To avoid additional fetches of Koha::Acquisition::Orders, GetLateOrders has been moved to Koha::Acquisition::Orders->filter_by_late That way we are going to add consistency, robustness, and cover the feature with new tests. Test plan: 0/ Create a bunch of new orders. Make sure they are from different vendor (with different delivery time). 1/ Go to the late orders page and claim some orders 2/ Reclaim some of those orders 3/ Confirm that you can see the different claim dates for a given orders (the history of the late orders claims is kept and displayed) 4/ Bonus point: Regression tests: a. Modify the closedate of the basket in the database. That will allow you to make sure the patch set did not introduce regressions. It would be good to test the different filters on the late orders page: * delay * Estimated delivery date from/to * Vendor b. Confirm that the subtotal and the total values from the late orders page is correct. c. Test the update database entry: do not apply these patches, claims some orders against master. Apply the patch, execute the update DB entry then confirm that the number of claims is correct (note that the dates will not as it is not possible to guess them). QA note: the branchcode parameter has been removed from filter_by_late. At first glance it seems that it was not used. Sponsored-by: Cork Institute of Technology -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 --- Comment #33 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 103568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103568&action=edit Bug 24161: Remove GetLateOrders Sponsored-by: Cork Institute of Technology -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 --- Comment #34 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 103569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103569&action=edit Bug 24161: Add tests Sponsored-by: Cork Institute of Technology -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 --- Comment #35 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 103570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103570&action=edit Bug 24161: DBIC manual changes No idea what's happening with the current_timestamp, but previous change was wrong. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 --- Comment #36 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 103571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103571&action=edit Bug 24161: Display claimed dates vertically -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 --- Comment #37 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Martin Renvoize from comment #31)
Feedback from sponsor testing.
(1) The 'claimed date' field lists the claimed dates side by side, could they be stacked vertically instead with most recent at the top?
Done in a follow-up patch
(2) The 'estimated delivery date from - to' filter appears to be broken
Indeed! Patch amended ("Keep tracks of late orders claims")
(3) The 'vendor' filter does not list all vendors?
It seems to be a bug in master, can you report this separately? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 --- Comment #38 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for the quick followups Jonathan. Yes, I did wonder about that final one perhaps being in master.. I'll report that separately now you've varified. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 --- Comment #39 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Bug 25266 added -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102111|0 |1 is obsolete| | --- Comment #40 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 103588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103588&action=edit Bug 24161: DB changes Sponsored-by: Cork Institute of Technology Signed-off-by: Angela O'Connor Desmond <angela.oconnordesmond@staff.ittralee.ie> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102112|0 |1 is obsolete| | --- Comment #41 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 103589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103589&action=edit Bug 24161: DBIC changes Sponsored-by: Cork Institute of Technology Signed-off-by: Angela O'Connor Desmond <angela.oconnordesmond@staff.ittralee.ie> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102113|0 |1 is obsolete| | --- Comment #42 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 103590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103590&action=edit Bug 24161: Add the Koha::Acquisition::Order::Claim[s] classes Sponsored-by: Cork Institute of Technology Signed-off-by: Angela O'Connor Desmond <angela.oconnordesmond@staff.ittralee.ie> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103567|0 |1 is obsolete| | --- Comment #43 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 103591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103591&action=edit Bug 24161: Keep tracks of late orders claims So far we only record the number of claims and the date of the last claim, in the aqorders table. To keep track of the different claim dates, this patchset is going to make the following DB changes: * Create a new table 'aqorders_claims' (id, ordernumber, claimed_on) * Remove the two columns from the aqorders table: claims_count and claimed_date This will allow to display the different claim dates where needed: on the late orders page, and the basket page. To avoid additional fetches of Koha::Acquisition::Orders, GetLateOrders has been moved to Koha::Acquisition::Orders->filter_by_late That way we are going to add consistency, robustness, and cover the feature with new tests. Test plan: 0/ Create a bunch of new orders. Make sure they are from different vendor (with different delivery time). 1/ Go to the late orders page and claim some orders 2/ Reclaim some of those orders 3/ Confirm that you can see the different claim dates for a given orders (the history of the late orders claims is kept and displayed) 4/ Bonus point: Regression tests: a. Modify the closedate of the basket in the database. That will allow you to make sure the patch set did not introduce regressions. It would be good to test the different filters on the late orders page: * delay * Estimated delivery date from/to * Vendor b. Confirm that the subtotal and the total values from the late orders page is correct. c. Test the update database entry: do not apply these patches, claims some orders against master. Apply the patch, execute the update DB entry then confirm that the number of claims is correct (note that the dates will not as it is not possible to guess them). QA note: the branchcode parameter has been removed from filter_by_late. At first glance it seems that it was not used. Sponsored-by: Cork Institute of Technology Signed-off-by: Angela O'Connor Desmond <angela.oconnordesmond@staff.ittralee.ie> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103568|0 |1 is obsolete| | --- Comment #44 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 103592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103592&action=edit Bug 24161: Remove GetLateOrders Sponsored-by: Cork Institute of Technology Signed-off-by: Angela O'Connor Desmond <angela.oconnordesmond@staff.ittralee.ie> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103569|0 |1 is obsolete| | --- Comment #45 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 103593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103593&action=edit Bug 24161: Add tests Sponsored-by: Cork Institute of Technology Signed-off-by: Angela O'Connor Desmond <angela.oconnordesmond@staff.ittralee.ie> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103570|0 |1 is obsolete| | --- Comment #46 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 103594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103594&action=edit Bug 24161: DBIC manual changes No idea what's happening with the current_timestamp, but previous change was wrong. Signed-off-by: Angela O'Connor Desmond <angela.oconnordesmond@staff.ittralee.ie> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103571|0 |1 is obsolete| | --- Comment #47 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 103595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103595&action=edit Bug 24161: Display claimed dates vertically Signed-off-by: Angela O'Connor Desmond <angela.oconnordesmond@staff.ittralee.ie> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 --- Comment #48 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 1) 2 small issues in the QA script: FAIL Koha/Acquisition/Order/Claim.pm OK critic FAIL forbidden patterns forbidden pattern: Incorrect license statement (using postal address), may be a false positive if the file is coming from outside Koha (bug 24545) (line 16) alid FAIL Koha/Acquisition/Order/Claims.pm OK critic FAIL forbidden patterns forbidden pattern: Incorrect license statement (using postal address), may be a false positive if the file is coming from outside Koha (bug 24545) (line 16) 2) Database documentation Can you please add notes to the entry in kohastructure.sql? I am still testing, but will need to create some more data in my db first. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #49 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 3) In my testing, the vendor pull down was empty, although there showed orders in my results. Can you please check? I was testing with an order made today, oder 0 days ago, estimated delivery date in the range I searched for (between May 1 and May 6). It should be that when you select a certain vendor in the filters, you can do a 'check all' and claim them all at once (see bug 7930), but can't test atm. 4) You mention a removed branch parameter. I was wondering if there was some kind of permissions thing going on here that would only allow you to claim your own late orders (permission order_manage_all maybe, but more likely the older independentbranches?). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 --- Comment #50 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 104190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104190&action=edit Bug 24161: Fix license statements -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 --- Comment #51 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 104191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104191&action=edit Bug 24161: (follow-up) DB changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #52 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #48) Thanks Katrin for having a look at this!
1) 2 small issues in the QA script:
FAIL Koha/Acquisition/Order/Claim.pm OK critic FAIL forbidden patterns forbidden pattern: Incorrect license statement (using postal address), may be a false positive if the file is coming from outside Koha (bug 24545) (line 16) alid
FAIL Koha/Acquisition/Order/Claims.pm OK critic FAIL forbidden patterns forbidden pattern: Incorrect license statement (using postal address), may be a false positive if the file is coming from outside Koha (bug 24545) (line 16)
Fixed!
2) Database documentation
Can you please add notes to the entry in kohastructure.sql?
Done!
I am still testing, but will need to create some more data in my db first.
(In reply to Katrin Fischer from comment #49)
3) In my testing, the vendor pull down was empty, although there showed orders in my results. Can you please check? I was testing with an order made today, oder 0 days ago, estimated delivery date in the range I searched for (between May 1 and May 6).
It should be that when you select a certain vendor in the filters, you can do a 'check all' and claim them all at once (see bug 7930), but can't test atm.
Yes, Martin opened bug 25266 for that, it's not directly related to these patches. I had trouble finding out a solution.
4) You mention a removed branch parameter. I was wondering if there was some kind of permissions thing going on here that would only allow you to claim your own late orders (permission order_manage_all maybe, but more likely the older independentbranches?).
The (reverse) path is: GetLateOrders has "branch" as third parameter, which is sent by lateorders.pl and it's expecting to come from the lateorders.tt template. But there is no "branch" parameter in that form. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103588|0 |1 is obsolete| | --- Comment #53 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 104207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104207&action=edit Bug 24161: DB changes Sponsored-by: Cork Institute of Technology Signed-off-by: Angela O'Connor Desmond <angela.oconnordesmond@staff.ittralee.ie> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103589|0 |1 is obsolete| | --- Comment #54 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 104208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104208&action=edit Bug 24161: DBIC changes Sponsored-by: Cork Institute of Technology Signed-off-by: Angela O'Connor Desmond <angela.oconnordesmond@staff.ittralee.ie> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103590|0 |1 is obsolete| | --- Comment #55 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 104209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104209&action=edit Bug 24161: Add the Koha::Acquisition::Order::Claim[s] classes Sponsored-by: Cork Institute of Technology Signed-off-by: Angela O'Connor Desmond <angela.oconnordesmond@staff.ittralee.ie> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103591|0 |1 is obsolete| | --- Comment #56 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 104210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104210&action=edit Bug 24161: Keep tracks of late orders claims So far we only record the number of claims and the date of the last claim, in the aqorders table. To keep track of the different claim dates, this patchset is going to make the following DB changes: * Create a new table 'aqorders_claims' (id, ordernumber, claimed_on) * Remove the two columns from the aqorders table: claims_count and claimed_date This will allow to display the different claim dates where needed: on the late orders page, and the basket page. To avoid additional fetches of Koha::Acquisition::Orders, GetLateOrders has been moved to Koha::Acquisition::Orders->filter_by_late That way we are going to add consistency, robustness, and cover the feature with new tests. Test plan: 0/ Create a bunch of new orders. Make sure they are from different vendor (with different delivery time). 1/ Go to the late orders page and claim some orders 2/ Reclaim some of those orders 3/ Confirm that you can see the different claim dates for a given orders (the history of the late orders claims is kept and displayed) 4/ Bonus point: Regression tests: a. Modify the closedate of the basket in the database. That will allow you to make sure the patch set did not introduce regressions. It would be good to test the different filters on the late orders page: * delay * Estimated delivery date from/to * Vendor b. Confirm that the subtotal and the total values from the late orders page is correct. c. Test the update database entry: do not apply these patches, claims some orders against master. Apply the patch, execute the update DB entry then confirm that the number of claims is correct (note that the dates will not as it is not possible to guess them). QA note: the branchcode parameter has been removed from filter_by_late. At first glance it seems that it was not used. Sponsored-by: Cork Institute of Technology Signed-off-by: Angela O'Connor Desmond <angela.oconnordesmond@staff.ittralee.ie> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103592|0 |1 is obsolete| | --- Comment #57 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 104211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104211&action=edit Bug 24161: Remove GetLateOrders Sponsored-by: Cork Institute of Technology Signed-off-by: Angela O'Connor Desmond <angela.oconnordesmond@staff.ittralee.ie> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103593|0 |1 is obsolete| | --- Comment #58 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 104212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104212&action=edit Bug 24161: Add tests Sponsored-by: Cork Institute of Technology Signed-off-by: Angela O'Connor Desmond <angela.oconnordesmond@staff.ittralee.ie> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103594|0 |1 is obsolete| | --- Comment #59 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 104213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104213&action=edit Bug 24161: DBIC manual changes No idea what's happening with the current_timestamp, but previous change was wrong. Signed-off-by: Angela O'Connor Desmond <angela.oconnordesmond@staff.ittralee.ie> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103595|0 |1 is obsolete| | --- Comment #60 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 104214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104214&action=edit Bug 24161: Display claimed dates vertically Signed-off-by: Angela O'Connor Desmond <angela.oconnordesmond@staff.ittralee.ie> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104190|0 |1 is obsolete| | --- Comment #61 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 104215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104215&action=edit Bug 24161: Fix license statements Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104191|0 |1 is obsolete| | --- Comment #62 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 104216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104216&action=edit Bug 24161: (follow-up) DB changes Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 --- Comment #63 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 --- Comment #64 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 104258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104258&action=edit Bug 24161: (follow-up) Fix typo in POD # Failed test 'POD test for Koha/Acquisition/Orders.pm' # at /usr/share/perl5/Test/Pod.pm line 187. # Koha/Acquisition/Orders.pm (43): Non-ASCII character seen before =encoding in 'uivalent'. Assuming UTF-8 xt/author/podcorrectness.t .. 622/829 # Looks like you failed 1 test of 829. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 --- Comment #65 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 104259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104259&action=edit Bug 24161: (follow-up) DBIC changes Define koha_object[s]_class methods -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 --- Comment #66 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 --- Comment #67 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 104265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104265&action=edit Bug 24161: (follow-up) Typo in POD Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com --- Comment #68 from Joy Nelson <joy@bywatersolutions.com> --- not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 --- Comment #69 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 104826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104826&action=edit Bug 24161: Fix failing test (when running slow) We "mocked" the claim date to make sure we were not going to hit this problem, but it's not done on the correct claim, it should be done on the last one (so second). from Koha::Acq::Order->claimed_date 294 my $last_claim = $self->claims->last; 295 return unless $last_claim; 296 return $last_claim->claimed_on; -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 --- Comment #70 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 --- Comment #71 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 104848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104848&action=edit Bug 24161: (follow-up) Fix failing test (when running slow) The previous assumption was wrong, we just need to return the last one. The tests mean to have 2 different values in the claimed_on dates. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 --- Comment #72 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Late orders improvements - |Improve the 'Late orders' |keeping track of claims |process: keep track of | |claims -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds the release notes| |ability to track multiple | |claim dates for a late | |order and exposes this | |audit record via the late | |orders and basket pages. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Improve the 'Late orders' |Improve the 'Late orders' |process: keep track of |process: Keep track of |claims |claims -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Improve the 'Late orders' |Improve the 'Late orders' |process: Keep track of |process: Keep track of |claims |claim dates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Improve the 'Late orders' |Add ability to track the |process: Keep track of |claim dates of later orders |claim dates | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 --- Comment #73 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am not sure if the database for this one works correctly. It looks like the timestamp was always set to the 'update date' instead of the last known claim date as it should have been. :( <pre> $DBversion = '19.12.00.085'; if( CheckVersion( $DBversion ) ) { unless ( TableExists( 'aqorders_claims' ) ) { $dbh->do(q| CREATE TABLE aqorders_claims ( id int(11) AUTO_INCREMENT, ordernumber INT(11) NOT NULL, claimed_on TIMESTAMP NOT NULL DEFAULT CURRENT_TIMESTAMP, PRIMARY KEY (id), CONSTRAINT aqorders_claims_ibfk_1 FOREIGN KEY (ordernumber) REFERENCES aqorders (ordernumber) ON DELETE CASCADE ON UPDATE CASCADE ) ENGINE = InnoDB DEFAULT CHARSET = utf8mb4 COLLATE = utf8mb4_unicode_ci |); my $orders = $dbh->selectall_arrayref(q| SELECT ordernumber, claims_count, claimed_date FROM aqorders WHERE claims_count > 0 |, { Slice => {} }); my $insert_claim_sth = $dbh->prepare(q| INSERT INTO aqorders_claims (ordernumber, claimed_on) VALUES (?,?) |); for my $order ( @$orders ) { for my $claim (1..$order->{claims_count}) { $insert_claim_sth->execute($order->{ordernumber}, $order->{claimed_on}); } } $dbh->do(q|ALTER TABLE aqorders DROP COLUMN claims_count, DROP COLUMN claimed_date|); } NewVersion( $DBversion, 24161, "Add new join table aqorders_claims to keep track of claims"); } -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 --- Comment #74 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Katrin Fischer from comment #73)
I am not sure if the database for this one works correctly. It looks like the timestamp was always set to the 'update date' instead of the last known claim date as it should have been. :(
<pre> $DBversion = '19.12.00.085'; if( CheckVersion( $DBversion ) ) { unless ( TableExists( 'aqorders_claims' ) ) { $dbh->do(q| CREATE TABLE aqorders_claims ( id int(11) AUTO_INCREMENT, ordernumber INT(11) NOT NULL, claimed_on TIMESTAMP NOT NULL DEFAULT CURRENT_TIMESTAMP, PRIMARY KEY (id), CONSTRAINT aqorders_claims_ibfk_1 FOREIGN KEY (ordernumber) REFERENCES aqorders (ordernumber) ON DELETE CASCADE ON UPDATE CASCADE ) ENGINE = InnoDB DEFAULT CHARSET = utf8mb4 COLLATE = utf8mb4_unicode_ci |);
my $orders = $dbh->selectall_arrayref(q| SELECT ordernumber, claims_count, claimed_date FROM aqorders WHERE claims_count > 0 |, { Slice => {} }); my $insert_claim_sth = $dbh->prepare(q| INSERT INTO aqorders_claims (ordernumber, claimed_on) VALUES (?,?) |);
for my $order ( @$orders ) { for my $claim (1..$order->{claims_count}) { $insert_claim_sth->execute($order->{ordernumber}, $order->{claimed_on}); } }
$dbh->do(q|ALTER TABLE aqorders DROP COLUMN claims_count, DROP COLUMN claimed_date|); }
NewVersion( $DBversion, 24161, "Add new join table aqorders_claims to keep track of claims"); }
Looks like the following line 22065 $insert_claim_sth->execute($order->{ordernumber}, $order->{claimed_on}); should have used $order->{claimed_on} instead. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 --- Comment #75 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #74)
(In reply to Katrin Fischer from comment #73) Looks like the following line 22065 $insert_claim_sth->execute($order->{ordernumber}, $order->{claimed_on}); should have used $order->{claimed_on} instead.
Did you mean claimed_date maybe? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 --- Comment #76 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Katrin Fischer from comment #75)
(In reply to Jonathan Druart from comment #74)
(In reply to Katrin Fischer from comment #73) Looks like the following line 22065 $insert_claim_sth->execute($order->{ordernumber}, $order->{claimed_on}); should have used $order->{claimed_on} instead.
Did you mean claimed_date maybe?
Yes!... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30539 --- Comment #77 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Reported on bug 30539 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30539 [Bug 30539] Koha upgrade error "Column 'claimed_on' cannot be null" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32187 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32187 [Bug 32187] (Bug 24161 follow-up) With IndependentBranches on a non superlibrarian librarian is not able to track late orders -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37109 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37109 [Bug 37109] Don't provide old claims fields when duplicating acquisitions orders -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org