[Bug 36970] New: (Bug 34160 follow-up) Barcode should be html filtered, not uri filtered
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36970 Bug ID: 36970 Summary: (Bug 34160 follow-up) Barcode should be html filtered, not uri filtered Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Hold requests Assignee: januszop@gmail.com Reporter: januszop@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com If a barcode (in rare cases) contains a space, with bug 34160, it is converted into %20 in holds queue view (because of mistakenly applied uri filter). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36970 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36970 --- Comment #1 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 167196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167196&action=edit Bug 36970: (Bug 34160 follow-up) Barcode should be html filtered, not uri filtered If a barcode (in rare cases) contains a space, with bug 34160, it is converted into %20 in holds queue view (because of mistakenly applied uri filter). Nota bene, in parallel lines of view_holdsqueue.tt a right filter is used for the barcode. Test plan: ========== 1. Have an item with the barcode containing a space. 2. Make a hold on it, run build_holds_queue.pl 3. Go to Circulation > Holds queue ; select your branch etc. 4. You should see '%20' instead of the space in the barcode. 5. Apply the patch, restart_all. 6. Repeat p. 3. You should now see the space in the barcode. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36970 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Depends on| |34160 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34160 [Bug 34160] Link item barcode to the item more details page from the holds queue viewer -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36970 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|(Bug 34160 follow-up) |(Bug 34160 follow-up) |Barcode should be html |Barcode should be html |filtered, not uri filtered |filtered, not uri filtered | |in holds queue view -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36970 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36970 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167196|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 167197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167197&action=edit Bug 36970: (Bug 34160 follow-up) Barcode should be html filtered, not uri filtered If a barcode (in rare cases) contains a space, with bug 34160, it is converted into %20 in holds queue view (because of mistakenly applied uri filter). Nota bene, in parallel lines of view_holdsqueue.tt a right filter is used for the barcode. Test plan: ========== 1. Have an item with the barcode containing a space. 2. Make a hold on it, run build_holds_queue.pl 3. Go to Circulation > Holds queue ; select your branch etc. 4. You should see '%20' instead of the space in the barcode. 5. Apply the patch, restart_all. 6. Repeat p. 3. You should now see the space in the barcode. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36970 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the display of release notes| |barcodes with spaces in the | |holds queue. Barcodes are | |now displayed correctly | |with a space, rather than | |with '%20'. CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. Running the holds queue builder: misc/cronjobs/holds/build_holds_queue.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36970 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36970 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167197|0 |1 is obsolete| | --- Comment #4 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 168113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168113&action=edit Bug 36970: (Bug 34160 follow-up) Barcode should be html filtered, not uri filtered If a barcode (in rare cases) contains a space, with bug 34160, it is converted into %20 in holds queue view (because of mistakenly applied uri filter). Nota bene, in parallel lines of view_holdsqueue.tt a right filter is used for the barcode. Test plan: ========== 1. Have an item with the barcode containing a space. 2. Make a hold on it, run build_holds_queue.pl 3. Go to Circulation > Holds queue ; select your branch etc. 4. You should see '%20' instead of the space in the barcode. 5. Apply the patch, restart_all. 6. Repeat p. 3. You should now see the space in the barcode. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36970 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36970 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36970 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mik@adminkuhn.ch --- Comment #6 from Phil Ringnalda <phil@chetcolibrary.org> --- *** Bug 37847 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36970 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to main |Pushed to stable Version(s)|24.11.00 |24.11.00,24.05.06 released in| | --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36970 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |fridolin.somers@biblibre.co | |m Version(s)|24.11.00,24.05.06 |24.11.00,24.05.06,23.11.11 released in| | --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.11 << The road to hell is paved with encoding issues >> ^^ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36970 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED CC| |wainuiwitikapark@catalyst.n | |et.nz Resolution|--- |FIXED --- Comment #9 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org