https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35238 --- Comment #1 from Eugene Espinoza <eugenegf@yahoo.com> --- Created attachment 159577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159577&action=edit Bug 35238: Incorrect label markup in patron card creator printer profile edit form HTML element for Template name is changed from 'label for "template_name"' to 'span with "label" class'. So from: <label for="template_name">Template name:</label> It should now be: <span class="label">Template name:</span> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35238 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159578|0 |1 is obsolete| | --- Comment #3 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 165149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165149&action=edit Bug 35238: Incorrect label markup in patron card creator printer profile edit form HTML element for Template name is changed from 'label for "template_name"' to 'span with "label" class'. So from: <label for="template_name">Template name:</label> It should now be: <span class="label">Template name:</span> To test: 1) Go to: Tools -> Patron card creator -> Edit printer profile. 2) Right click page and choose "View page source". 3) Locate the part with "Template name". It should read: <span class="label">Template name:</span> Signed-off-by: Riomar Resurreccion <urslibrary.webinars@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35238 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |david@davidnind.com Assignee|oleonard@myacpl.org |eugenegf@yahoo.com --- Comment #5 from David Nind <david@davidnind.com> --- Added assignee. Looks like it has been signed off as well. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35238 --- Comment #7 from David Nind <david@davidnind.com> --- Can confirm that the patch still applies, and things works as per the test plan. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35238 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165150|0 |1 is obsolete| | --- Comment #8 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 168098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168098&action=edit Bug 35238: Incorrect label markup in patron card creator printer profile edit form HTML element for Template name is changed from 'label for "template_name"' to 'span with "label" class'. So from: <label for="template_name">Template name:</label> It should now be: <span class="label">Template name:</span> To test: 1) Go to: Tools -> Patron card creator -> Edit printer profile. 2) Right click page and choose "View page source". 3) Locate the part with "Template name". It should read: <span class="label">Template name:</span> Signed-off-by: Riomar Resurreccion <urslibrary.webinars@gmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35238 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35238 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|24.11.00,24.05.06 |24.11.00,24.05.06,23.11.11 released in| | CC| |fridolin.somers@biblibre.co | |m --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.11 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35238 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #12 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 -- You are receiving this mail because: You are watching all bug changes.