[Bug 9612] New: SRU Responce is different when DOM indexing is enabled
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9612 Bug ID: 9612 Summary: SRU Responce is different when DOM indexing is enabled Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.10 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Z39.50 / SRU / OpenSearch Servers Assignee: gmcharlt@gmail.com Reporter: martin.renvoize@ptfs-europe.com CC: m.de.rooy@rijksmuseum.nl It looks as though the SRU server is not picking up an xslt to transform zebra results into meaningful SRU responses. I think the file to to changed is 'retrieval-info-bib-dom.xml' but I'm unsure how to proceed with changing it to mimic the output given for a grs-1 indexed catalogue. Maybe someone more knowledgeable of zebra configuration then I could step in? Two public SRU servers, one with DOM indexing and one with GRS-1 Indexing follow as examples of the differences. DOM: http://tavi.koha-ptfs.eu:9998/biblios?version=1.1&operation=searchRetrieve&recordPacking=xml&query=any=medical&startRecord=1&maximumRecords=1 GRS-1: http://bldscat.ids.ac.uk:9998/biblios?version=1.1&operation=searchRetrieve&recordPacking=xml&query=any=medical&startRecord=1&maximumRecords=1 As you can see, the GRS-1 response is much more comprehensible, and I believe is also the correct response. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9612 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- OK.. So i've found that if you comment out the line: '<retrieval syntax="xml" name="index"/> <!-- allow viewing index entries -->' You get nice marcxml formatted responses again.. so why is this line here in the first place... I'm no zebra pro but it baffles me? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9612 --- Comment #2 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- (In reply to comment #1)
OK.. So i've found that if you comment out the line:
'<retrieval syntax="xml" name="index"/> <!-- allow viewing index entries -->'
You get nice marcxml formatted responses again.. so why is this line here in the first place... I'm no zebra pro but it baffles me?
The idea is that it should be possible to view Zebra's indexes, but apparently we have it set up so that the indexes are displayed by default. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9612 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.10 |master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9612 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|SRU Responce is different |SRU Response is different |when DOM indexing is |when DOM indexing is |enabled |enabled -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9612 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|gmcharlt@gmail.com |m.de.rooy@rijksmuseum.nl --- Comment #3 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- I have been testing zebra/sru with dom-dom-icu again. Worked much better now. I plan to send a patch that includes resolving this bug next week. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9612 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9612 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I look forward to it, and will happily test. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9612 --- Comment #5 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 26625 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26625&action=edit Bug 9612: SRU response for DOM indexing This patch makes changes to koha-conf.xml by removing the fallback section from biblioserver and authserver. The information is in a include file on the same server (no need to fall back) and moreover, some information is not up-to-date and should be moved elsewhere. The patch also simplifies the DOM retrieval-info files for auth and bib. And eliminates superfluous F and usmarc from the dom-config files. (I felt the urge to remove marcxml too, but left it for now; see also the second patch.) For reference, look at the marcxml example files of Zebra. NOTE: This patch does not deal with the Debian package installs. In the same way koha-conf-site.xml.in, and *-retrieval-info-* could be adjusted. Test plan: [1] Run at least a dev install in order to copy the new files to your Zebra folders. Choose for DOM indexing. Enable the SRU server on port 9998 (small edit in koha-conf.xml). [2] Restart Zebra and reindex -a -b -x. [3] Verify if a search from Koha still functions as expected. Check the SRU output on port 9998. NOTE: If you do not pass recordSchema, you should get back a marc response now (instead of index schema). Bonus: Add your server as a Z3950 target to another Koha install. And perform a Z3950 search from the other server to your new install. Bonus: Check response from the auth and biblio socket via yaz-client. [4] Reindex again with -a -b but without -x. [5] Repeat Koha search, SRU response (Z3950, yaz-client). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9612 --- Comment #6 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 26626 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26626&action=edit Bug 9612: Zconn parameters and elementSetName in _new_Zconn This patch makes a few adjustments in C4::Context::Zconn. It does no longer pass the (ignored) auth, syntax parameters to _new_Zconn. Note that auth was not completely ignored in theory, but we never pass auth=1 [while not having user/password in koha-conf]. Furthermore, it removes the elementSetName for dom indexing. Using marcxml here does not make a difference. It only adds a constraint on what is in the dom-config files. (It could probably be removed there now..) Two cosmetic code changes: Removes unused label retry. And moved 'servername' into the database name option. Test plan: When using Zebra with dom indexing, do a biblio and authority search. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9612 --- Comment #7 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Have been testing this in quite some variants. The final patches have been tested again with Makefile for both dom as well as grs1 for completeness. In the commit message I have indicated that similar changes can be made to the debian template files. (I have not attached a patch, since I cannot test that one.) Note that the changes proposed here should imo not disrupt the package install as seen from a code perspective. I am asking Robin to confirm this. After that the status can be set to Needs Signoff. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9612 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robin@catalyst.net.nz --- Comment #8 from Robin Sheat <robin@catalyst.net.nz> --- These shouldn't break the package install, but the changes to koha-conf.xml won't be reflected there, so the bug will probably exist. It'd be good to change debian/templates/koha-conf-site.xml.in to match, and possibly also koha-create (as it looks like some of the parts for the file come from there.) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9612 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12012 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9612 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #9 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Robin Sheat from comment #8)
These shouldn't break the package install, but the changes to koha-conf.xml won't be reflected there, so the bug will probably exist. It'd be good to change debian/templates/koha-conf-site.xml.in to match, and possibly also koha-create (as it looks like some of the parts for the file come from there.)
Thanks. I will open up a new report for that road. Bug 12012. In the meantime this is ready for signoff. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9612 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26625|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 27500 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27500&action=edit [SIGNED OFF] Bug 9612: SRU response for DOM indexing This patch makes changes to koha-conf.xml by removing the fallback section from biblioserver and authserver. The information is in a include file on the same server (no need to fall back) and moreover, some information is not up-to-date and should be moved elsewhere. The patch also simplifies the DOM retrieval-info files for auth and bib. And eliminates superfluous F and usmarc from the dom-config files. (I felt the urge to remove marcxml too, but left it for now; see also the second patch.) For reference, look at the marcxml example files of Zebra. NOTE: This patch does not deal with the Debian package installs. In the same way koha-conf-site.xml.in, and *-retrieval-info-* could be adjusted. Test plan: [1] Run at least a dev install in order to copy the new files to your Zebra folders. Choose for DOM indexing. Enable the SRU server on port 9998 (small edit in koha-conf.xml). [2] Restart Zebra and reindex -a -b -x. [3] Verify if a search from Koha still functions as expected. Check the SRU output on port 9998. NOTE: If you do not pass recordSchema, you should get back a marc response now (instead of index schema). Bonus: Add your server as a Z3950 target to another Koha install. And perform a Z3950 search from the other server to your new install. Bonus: Check response from the auth and biblio socket via yaz-client. [4] Reindex again with -a -b but without -x. [5] Repeat Koha search, SRU response (Z3950, yaz-client). Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9612 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26626|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 27501 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27501&action=edit [SIGNED OFF] Bug 9612: Zconn parameters and elementSetName in _new_Zconn This patch makes a few adjustments in C4::Context::Zconn. It does no longer pass the (ignored) auth, syntax parameters to _new_Zconn. Note that auth was not completely ignored in theory, but we never pass auth=1 [while not having user/password in koha-conf]. Furthermore, it removes the elementSetName for dom indexing. Using marcxml here does not make a difference. It only adds a constraint on what is in the dom-config files. (It could probably be removed there now..) Two cosmetic code changes: Removes unused label retry. And moved 'servername' into the database name option. Test plan: When using Zebra with dom indexing, do a biblio and authority search. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9612 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Finally got around to testing this, and it behaves as expected and also simplifies the config somewhat which I see as a good thing. Nice work M. de Rooy -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9612 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Depends on| |12012 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9612 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate CC| |gmcharlt@gmail.com --- Comment #13 from Galen Charlton <gmcharlt@gmail.com> --- Marking as candidate for 3.16.0 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9612 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|12012 | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9612 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Pushed for QA --- Comment #14 from Galen Charlton <gmcharlt@gmail.com> --- Passing QA and pushing to master. Thanks, Marcel! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9612 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed for QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9612 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9612 --- Comment #15 from Owen Leonard <oleonard@myacpl.org> --- All searches (staff client and OPAC) are returning bad results and git bisect blames this bug. The search seems to be finding results (it returns a count of results which looks valid), but the search results page shows no data in the table of results--no title, no author, no item information, etc. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9612 --- Comment #16 from Galen Charlton <gmcharlt@gmail.com> --- (In reply to Owen Leonard from comment #15)
All searches (staff client and OPAC) are returning bad results and git bisect blames this bug. The search seems to be finding results (it returns a count of results which looks valid), but the search results page shows no data in the table of results--no title, no author, no item information, etc.
Try a 'make update_zebra_conf' and advise if that improves the situation. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9612 --- Comment #17 from Galen Charlton <gmcharlt@gmail.com> --- (and restarting zebrasrv after perl Makefile.PL && make update_zebra_conf) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9612 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9612 --- Comment #18 from Galen Charlton <gmcharlt@gmail.com> --- Testing by Owen and Bernardo indicated that they needed to do a full index rebuild before searches would work again after applying this patch. This seems a little extreme; we need to figure out why. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9612 --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I also did a rebuild when signing-off, however, I was expecting such as this patch touches the zebra configs relatively heavily. I'm not really sure how one would overcome this, but it would certainly be sensible to flag the requirement to restart and rebuild zebra during upgrade time somehow. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9612 --- Comment #20 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Galen Charlton from comment #18)
Testing by Owen and Bernardo indicated that they needed to do a full index rebuild before searches would work again after applying this patch. This seems a little extreme; we need to figure out why.
I am looking at this now. I was not aiming for a full rebuild at upgrade time.. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9612 --- Comment #21 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Can reproduce the problem with the following test in a non-package environment (manual dev install). master back to commit 036f2a50e11dab97ef8509f2f585c4cc407ea728 [22 commits back, before 9612] installed old zebra config, full rebuild, restart zebrasrv reset head to 3.16.beta+ [commit 34e136a485c58c6911de59899f94a0543e483b0a] search again without config change: same results [with config change but no restart would be fine too..] ***restarted zebrasrv: results without details (needs a rebuild) The crux here is restarting the zebra server (as it appears, I did not restart zebrasrv every time when testing these patches..) Restoring elementSetName=marcxml in Context.pm resolves this issue. Patch forthcoming. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9612 --- Comment #22 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 28016 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28016&action=edit Bug 9612: Follow-up for elementSetName in Context.pm Restore elementSetName to marcxml for dom indexing in Zconn (Context.pm). This prevents the need of rebuilding the index after restarting Zebra server. Removes the now incorrect reference to marcxml as 'superfluous' in four dom config files. Test plan: Rebuild zebra index with the zebra config of commit 036f2a50e11dab97ef8509f2f585c4cc407ea728. Go back to master. Install new zebra config. Restart your zebra server. Without this patch, you will have results without details. Apply this patch. Search results are fine (you did not rebuild!). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9612 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9612 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9612 --- Comment #23 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Note: Will be revising the test plan little bit.. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9612 --- Comment #24 from Marc Véron <veron@veron.ch> --- Created attachment 28017 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28017&action=edit [Signed-off] Bug 9612: Follow-up for elementSetName in Context.pm Restore elementSetName to marcxml for dom indexing in Zconn (Context.pm). This prevents the need of rebuilding the index after restarting Zebra server. Removes the now incorrect reference to marcxml as 'superfluous' in four dom config files. Test plan: Rebuild zebra index with the zebra config of commit 036f2a50e11dab97ef8509f2f585c4cc407ea728. Go back to master. Install new zebra config. Restart your zebra server. Without this patch, you will have results without details. Apply this patch. Search results are fine (you did not rebuild!). I tested starting on a VM with Koha 3.15.00.019 installed. Did git pull -> Koha 3.15.00.051 Result: No details in search results. Applied patch. Result: Search results display fine. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9612 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28016|0 |1 is obsolete| | --- Comment #25 from Marc Véron <veron@veron.ch> --- Comment on attachment 28016 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28016 Bug 9612: Follow-up for elementSetName in Context.pm I do not switch status to "Signed off" because I think it would be good having some tests with other scenarios. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9612 --- Comment #26 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 28018 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28018&action=edit Bug 9612: Follow-up for elementSetName in Context.pm Restore elementSetName to marcxml for dom indexing in Zconn (Context.pm). This prevents the need of rebuilding the index after restarting Zebra server. Removes the now incorrect reference to marcxml as 'superfluous' in four dom config files. Test plan: [1] Do not yet apply this patch. [2] Rebuild zebra index with the zebra config of commit 036f2a50e11dab97ef8509f2f585c4cc407ea728. [3] (Go back to master.) Restart your zebra server (no config change). You will have results without details. Apply this patch: you see details. Reset to master: no details again. [4] Install new zebra config from master. Search again: you still see no details. Restart zebra server. Search: you see details. Apply this patch. Search: still details. Restart zebra server. Search: still details. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Tested in a non-package environment (manual dev install). The package environment should work now too (results in step 4c might differ). Progress on bug 12012 would be appropriate to sync all changes. Tested the response of the SRU server too. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9612 --- Comment #27 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Thanks, Marc. I only edited the commit message with the last patch and unintentionally removed the signoff line from Marc. Can I put your signoff under the new version, Marc? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9612 --- Comment #28 from Marc Véron <veron@veron.ch> --- (In reply to M. de Rooy from comment #27)
Thanks, Marc. I only edited the commit message with the last patch and unintentionally removed the signoff line from Marc. Can I put your signoff under the new version, Marc?
Go ahead :-) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9612 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28017|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9612 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27500|[SIGNED OFF] Bug 9612: SRU |[PUSHED] Bug 9612: SRU description|response for DOM indexing |response for DOM indexing -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9612 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27501|[SIGNED OFF] Bug 9612: |[PUSHED] Bug 9612: Zconn description|Zconn parameters and |parameters and |elementSetName in |elementSetName in |_new_Zconn |_new_Zconn -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9612 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28018|0 |1 is obsolete| | --- Comment #29 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 28019 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28019&action=edit Bug 9612: Follow-up for elementSetName in Context.pm Restore elementSetName to marcxml for dom indexing in Zconn (Context.pm). This prevents the need of rebuilding the index after restarting Zebra server. Removes the now incorrect reference to marcxml as 'superfluous' in four dom config files. Test plan: [1] Do not yet apply this patch. [2] Rebuild zebra index with the zebra config of commit 036f2a50e11dab97ef8509f2f585c4cc407ea728. [3] (Go back to master.) Restart your zebra server (no config change). You will have results without details. Apply this patch: you see details. Reset to master: no details again. [4] Install new zebra config from master. Search again: you still see no details. Restart zebra server. Search: you see details. Apply this patch. Search: still details. Restart zebra server. Search: still details. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Tested in a non-package environment (manual dev install). The package environment should work now too (results in step 4c might differ). Progress on bug 12012 would be appropriate to sync all changes. Tested the response of the SRU server too. Signed-off-by: Marc Veron <veron@veron.ch> I tested starting on a VM with Koha 3.15.00.019 installed. Did git pull -> Koha 3.15.00.051 Result: No details in search results. Applied patch. Result: Search results display fine. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9612 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28019|0 |1 is obsolete| | --- Comment #30 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28138 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28138&action=edit [SIGNED-OFF] Bug 9612: Follow-up for elementSetName in Context.pm Restore elementSetName to marcxml for dom indexing in Zconn (Context.pm). This prevents the need of rebuilding the index after restarting Zebra server. Removes the now incorrect reference to marcxml as 'superfluous' in four dom config files. Test plan: [1] Do not yet apply this patch. [2] Rebuild zebra index with the zebra config of commit 036f2a50e11dab97ef8509f2f585c4cc407ea728. [3] (Go back to master.) Restart your zebra server (no config change). You will have results without details. Apply this patch: you see details. Reset to master: no details again. [4] Install new zebra config from master. Search again: you still see no details. Restart zebra server. Search: you see details. Apply this patch. Search: still details. Restart zebra server. Search: still details. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Tested in a non-package environment (manual dev install). The package environment should work now too (results in step 4c might differ). Progress on bug 12012 would be appropriate to sync all changes. Tested the response of the SRU server too. Signed-off-by: Marc Veron <veron@veron.ch> I tested starting on a VM with Koha 3.15.00.019 installed. Did git pull -> Koha 3.15.00.051 Result: No details in search results. Applied patch. Result: Search results display fine. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9612 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9612 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |major -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9612 --- Comment #31 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 28261 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28261&action=edit [PASSED QA] Bug 9612: Follow-up for elementSetName in Context.pm Restore elementSetName to marcxml for dom indexing in Zconn (Context.pm). This prevents the need of rebuilding the index after restarting Zebra server. Removes the now incorrect reference to marcxml as 'superfluous' in four dom config files. Test plan: [1] Do not yet apply this patch. [2] Rebuild zebra index with the zebra config of commit 036f2a50e11dab97ef8509f2f585c4cc407ea728. [3] (Go back to master.) Restart your zebra server (no config change). You will have results without details. Apply this patch: you see details. Reset to master: no details again. [4] Install new zebra config from master. Search again: you still see no details. Restart zebra server. Search: you see details. Apply this patch. Search: still details. Restart zebra server. Search: still details. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Tested in a non-package environment (manual dev install). The package environment should work now too (results in step 4c might differ). Progress on bug 12012 would be appropriate to sync all changes. Tested the response of the SRU server too. Signed-off-by: Marc Veron <veron@veron.ch> I tested starting on a VM with Koha 3.15.00.019 installed. Did git pull -> Koha 3.15.00.051 Result: No details in search results. Applied patch. Result: Search results display fine. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9612 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #32 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice to have an easy one :) Passing QA on the follow up, I can confirm it prevents the need for a full-index rebuild. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9612 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28138|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9612 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28261|0 |1 is obsolete| | --- Comment #33 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 28323 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28323&action=edit [PASSED QA] Bug 9612: Follow-up for elementSetName in Context.pm Restore elementSetName to marcxml for dom indexing in Zconn (Context.pm). This prevents the need of rebuilding the index after restarting Zebra server. Removes the now incorrect reference to marcxml as 'superfluous' in four dom config files. Test plan: [1] Do not yet apply this patch. [2] Rebuild zebra index with the zebra config of commit 036f2a50e11dab97ef8509f2f585c4cc407ea728. [3] (Go back to master.) Restart your zebra server (no config change). You will have results without details. Apply this patch: you see details. Reset to master: no details again. [4] Install new zebra config from master. Search again: you still see no details. Restart zebra server. Search: you see details. Apply this patch. Search: still details. Restart zebra server. Search: still details. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Tested in a non-package environment (manual dev install). The package environment should work now too (results in step 4c might differ). Progress on bug 12012 would be appropriate to sync all changes. Tested the response of the SRU server too. Signed-off-by: Marc Veron <veron@veron.ch> I tested starting on a VM with Koha 3.15.00.019 installed. Did git pull -> Koha 3.15.00.051 Result: No details in search results. Applied patch. Result: Search results display fine. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9612 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #34 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Marcel! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org