[Bug 33100] New: Authority linking doesn't work for bib headings ending in two or more punctuation characters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33100 Bug ID: 33100 Summary: Authority linking doesn't work for bib headings ending in two or more punctuation characters Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: phil@chetcolibrary.org QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl, nick@bywatersolutions.com At the time of bug 24094 this apparently worked, but now in both my production 22.05 instance and a master sandbox, while Doe, John A. in a bib record will link to Doe, John A. in an authority record, Doe, John A., (as it will be in virtually every RDA record, since you are supposed to have a $e relator for personal names, and you are supposed to have a comma before the $e) will not link to the Doe, John A. authority record. That's a barely noticeable thing unless you actually track your unlinked authorites, but it's very noticeable if you use AutoCreateAuthorites and the first-match linker. In that case, every time you add a new Box, C. J. item, the linker strips off the comma from $aBox, C. J.,$eauthor., declares that your existing authority record for Box, C. J. doesn't match, and AutoCreateAuthorities also strips off the comma, creates a new duplicate Box, C. J. record, and then does it again the next time you save the record, and then does it again when you update the authority record for the series heading because it changed, and that triggers relinking the whole bib record, then again any time you edit the record or any authority linked to it. Two maybe-interesting exceptions, from when I started out looking at all the punctuation that _get_search_form in C4/Heading/MARC21.pm trims from the end of a bib heading to attempt to make it searchable, and the not-quite-the-same things that AutoCreateAuthorities strips before creating what it hopes will be an authority heading that will actually still match during the next linking: Doe, John A-- will autocreate an authority record which is exactly that, because autocreate's set of punctuation lack only that one character from _get_search_heading's regex, but, even though _get_search_heading will turn that into a search for Doe, John A- during a relink, that will match the -- authority form. The same is true for other characters: if you edit the authority record for Doe, John A. and make it Doe, John A., then that will match a bib record with Doe, John A., and will also match a bib record with Doe, John A.! or Doe, John A./ or Doe, John A.^ which isn't even in the set of stripped punctuation so the search should be for Doe, John A.^ and that still matches Doe, John A., Doe, John A=, will match an authority record for Doe, John A with no punctuation, though there's no similar magic for Doe, John,= where _get_search_heading has stripped off the equal sign, making me think at least that bit of magic is happening in the search engine or the query prep. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33100 --- Comment #1 from Phil Ringnalda <phil@chetcolibrary.org> --- May wind up invalid, I forgot that the fallout from bug 30280 means you can't actually test linking on master/22.11, because almost everything fails to link and thus autocreates duplicates. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33100 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24094, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24833 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33100 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33159 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33159 [Bug 33159] Thesaurus is not defined by second indicator for controlled fields outside of 6XX -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33100 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33100 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 147885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147885&action=edit Bug 33100: Unit test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33100 --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 147886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147886&action=edit Bug 33100: Remove all punctuation at end of record This could potentially be overkill - if you have two records that only differ in ending punctuation, you might get a false result - I don't know how likely that is ( as I have mentioned before '!!!' is a band ) This seems a reasonable fix To test: 1 - Set sysprefs as in bug 33159 2 - Edit a record, biblionumebr 3 is fine 3 - Add a comma to end of author subfield a 4 - Save and note relinked 5 - Apply patch, restart all 6 - Save again 7 - Linked to original record -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33100 --- Comment #4 from Phil Ringnalda <phil@chetcolibrary.org> --- Whether or not you can have collisions depends on what heading rules you catalog under, but at least for Library of Congress/NACO rules you're pretty safe: a heading has to be unique after https://www.loc.gov/aba/pcc/naco/normrule-2.html#a is applied, which removes or blanks most punctuation. While Foo&, Foo#, and Foo are validly three different names (which is fine, we don't strip & or #), Foo-, Foo., Foo:, Foo=, Foo;, Foo%, Foo/, and Foo are all the same name so only one of them can exist. Comma is a little bit fun, because normalization says that the "first comma in $a is retained" but doesn't say "only if there is something following it" so technically if there's already someone named "Foo" it would be valid to have someone else named "Foo," but at least so far people giving themselves Cher-like single names don't seem very fond of having a trailing comma as part of their actual name. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33100 Heather <heather_hernandez@nps.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |heather_hernandez@nps.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33100 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33100 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|33159 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33159 [Bug 33159] Thesaurus is not defined by second indicator for controlled fields outside of 6XX -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33100 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33159 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33159 [Bug 33159] Thesaurus is not defined by second indicator for controlled fields outside of 6XX -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33100 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147885|0 |1 is obsolete| | Attachment #147886|0 |1 is obsolete| | --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 148030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148030&action=edit Bug 33100: Unit test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33100 --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 148031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148031&action=edit Bug 33100: Remove all punctuation at end of record This could potentially be overkill - if you have two records that only differ in ending punctuation, you might get a false result - I don't know how likely that is ( as I have mentioned before '!!!' is a band ) This seems a reasonable fix To test: 1 - Set sysprefs as in bug 33159 2 - Edit a record, biblionumebr 3 is fine 3 - Add a comma to end of author subfield a 4 - Save and note relinked 5 - Apply patch, restart all 6 - Save again 7 - Linked to original record -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33100 --- Comment #7 from Phil Ringnalda <phil@chetcolibrary.org> --- I can only test locally with Zebra, because I've never gotten the instructions to make ElasticSearch work on macOS to actually work. With Zebra, 22.05.x does not exhibit this bug: after you add the comma, the heading still links to the original authority With Zebra, master @ 7a829606a46f5d3c2056ce9da5134ce293d584ad (the revision before bug 30280 broke linking names) does not exhibit this bug With Zebra, HEAD plus the patches from bug 33159 to allow linking names to work again does not exhibit this bug With ElasticSearch on a sandbox, HEAD plus the patches from bug 33159 to allow linking names does not exhibit this bug I'd like to know whether ElasticSearch on 22.05.x, ElasticSearch @ 7a829606a46f5d3c2056ce9da5134ce293d584ad, and ElasticSearch on 22.11.x exhibit this bug, but I don't have any way to find out myself. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33100 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|33159 | Depends on| |33159 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33159 [Bug 33159] Thesaurus is not defined by second indicator for controlled fields outside of 6XX -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33100 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|33159 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33159 [Bug 33159] Thesaurus is not defined by second indicator for controlled fields outside of 6XX -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33100 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33159 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33159 [Bug 33159] Thesaurus is not defined by second indicator for controlled fields outside of 6XX -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33100 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148030|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 148225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148225&action=edit Bug 33100: Unit test Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33100 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148031|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 148226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148226&action=edit Bug 33100: Remove all punctuation at end of record This could potentially be overkill - if you have two records that only differ in ending punctuation, you might get a false result - I don't know how likely that is ( as I have mentioned before '!!!' is a band ) This seems a reasonable fix To test: 1 - Set sysprefs as in bug 33159 2 - Edit a record, biblionumebr 3 is fine 3 - Add a comma to end of author subfield a 4 - Save and note relinked 5 - Apply patch, restart all 6 - Save again 7 - Linked to original record Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33100 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Needs Signoff |Signed Off --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- The code change is nice and clear here and in testing it's all working as expected for me. We're also nicely covered by unit tests. QA scripts are happy too, so I'm going to straight PQA this one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33100 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33100 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33100 --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 148337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148337&action=edit Bug 33100: (QA follow-up) Trivial QA fixes Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33100 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33100 --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33100 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.04 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33100 --- Comment #13 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33100 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |lucas@bywatersolutions.com Version(s)|23.05.00,22.11.04 |23.05.00,22.11.04,22.05.12 released in| | --- Comment #14 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33100 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki@biblibre.com Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|23.05.00,22.11.04,22.05.12 |23.05.00,22.11.04,22.05.12, released in| |21.11.20 --- Comment #15 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- applied to 21.11.x for 21.11.20 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org