[Bug 14926] New: Remove C4::Dates from members/printfeercpt.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14926 Bug ID: 14926 Summary: Remove C4::Dates from members/printfeercpt.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org This patch removes C4::Dates from members/printfeercpt.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14926 --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 42956 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42956&action=edit Bug 14926 - Remove C4::Dates from members/printfeercpt.pl This patch removes C4::Dates from members/printfeercpt.pl To test: - Go to a patron's fines (members/boraccount.pl) and make sure that he/she has made a payment - Select 'Print' in the payment's line - Verify that the payment date on the slip displays correctly -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14926 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff Assignee|gmcharlt@gmail.com |veron@veron.ch Blocks| |14870 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 [Bug 14870] Delete C4/Dates.pm from System -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14926 --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 43143 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43143&action=edit Bug 14946 - Remove C4::Dates from files acqui/*.pl This patch removes C4::Dates from: - acqui/histsearch.pl - acqui/invoice.pl - acqui/invoices.pl - acqui/orderreceive.pl - acqui/parcel.pl - acqui/parcels.pl - acqui/transferorder.pl To test: - Apply patch - Go to Home > Acquisitions > Invoices - Verify that Search filters work OK - Edit an invoice - Verify that Shipment date and Billing date display OK and edit / save is OK - Receive shipment for a vendor - Verify that Shipment date behaves OK and that you can filter list of shipents for this vendor - Transfer an item from a basket to another vendor -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14926 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43143|0 |1 is obsolete| | --- Comment #3 from Marc Véron <veron@veron.ch> --- Comment on attachment 43143 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43143 Bug 14946 - Remove C4::Dates from files acqui/*.pl Mistaked with bug number, sorry for the noise. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14926 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42956|0 |1 is obsolete| | --- Comment #4 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 43262 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43262&action=edit [SIGNED-OFF]Bug 14926 - Remove C4::Dates from members/printfeercpt.pl This patch removes C4::Dates from members/printfeercpt.pl To test: - Go to a patron's fines (members/boraccount.pl) and make sure that he/she has made a payment - Select 'Print' in the payment's line - Verify that the payment date on the slip displays correctly Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised. Date displayed 2015-10-08 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14926 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |hector.hecaxmmx@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14926 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Héctor Eduardo Castro Avalos from comment #4)
Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised. Date displayed 2015-10-08
Yes but YYYY-MM-DD is the iso format. If you change your pref to something else, it will be the iso format too. So the patch does not work. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14926 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14926 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 43290 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43290&action=edit Bug 14926: Format the date according to the dateformat syspref -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14926 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Please try again with the last patch, and don't forget to change your dateformat pref to something else than iso :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14926 --- Comment #8 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- (In reply to Jonathan Druart from comment #7)
Please try again with the last patch, and don't forget to change your dateformat pref to something else than iso :)
Okidoki -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14926 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43290|0 |1 is obsolete| | --- Comment #9 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 43301 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43301&action=edit [SIGNED-OFF]Bug 14926: Format the date according to the dateformat syspref Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised. Tested with the three values from dateformat syspref -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14926 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14926 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14926 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43262|0 |1 is obsolete| | Attachment #43301|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 43418 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43418&action=edit Bug 14926 - Remove C4::Dates from members/printfeercpt.pl This patch removes C4::Dates from members/printfeercpt.pl To test: - Go to a patron's fines (members/boraccount.pl) and make sure that he/she has made a payment - Select 'Print' in the payment's line - Verify that the payment date on the slip displays correctly Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised. Date displayed 2015-10-08 Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14926 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 43419 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43419&action=edit Bug 14926: Format the date according to the dateformat syspref Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised. Tested with the three values from dateformat syspref Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14926 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org