[Bug 14617] New: Add indexes for MARC 020$z => ISBN, 022$y, 022$z => ISSN
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14617 Bug ID: 14617 Summary: Add indexes for MARC 020$z => ISBN, 022$y, 022$z => ISSN Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt@gmail.com Reporter: barton@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Add indexes for Canceled and Invalid ISBN (020$z), Incorrect ISSN (022$y), Cancelled ISSN (022$z). Not having these indexed means that it is impossible to pick up a physical copy of a book or serial with a cancelled ISBN or ISSN and search for it by ISBN or ISSN in Koha. See http://www.loc.gov/marc/bibliographic/bd020.html http://www.loc.gov/marc/bibliographic/bd022.html -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14617 Barton Chittenden <barton@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|gmcharlt@gmail.com |barton@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14617 Barton Chittenden <barton@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11653 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14617 J Schmidt <jschmidt@switchinc.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jschmidt@switchinc.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14617 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- What index will u use? I'd suggest reusing the -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14617 --- Comment #2 from Barton Chittenden <barton@bywatersolutions.com> --- Tomas, I'm planning on re-using the existing ISBN and ISSN indexes -- I'm simply looking to extend what's there, and I don't want to mess around with the bib1 and ccl configuration. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14617 --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Yeah, I was about to discard my message (hence its incompleteness) but clicked to be cc-ed by this bug and it applied my comment :-D -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14617 --- Comment #4 from Barton Chittenden <barton@bywatersolutions.com> --- Created attachment 41429 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41429&action=edit Add fields to ISBN and ISSN indexes: 020$z, 022$y, 022$z -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14617 Barton Chittenden <barton@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14617 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14617 --- Comment #5 from Barton Chittenden <barton@bywatersolutions.com> --- Created attachment 42607 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42607&action=edit [SIGNED-OFF] Bug 14617: Add fields to ISBN and ISSN indexes: 020$z, 022$y, 022$z http://bugs.koha-community.org/show_bug.cgi?id=14617 Signed-off-by: kholten@switchinc.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14617 Barton Chittenden <barton@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41429|0 |1 is obsolete| | --- Comment #6 from Barton Chittenden <barton@bywatersolutions.com> --- Comment on attachment 41429 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41429 Add fields to ISBN and ISSN indexes: 020$z, 022$y, 022$z Obsoleted by following patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14617 Barton Chittenden <barton@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14617 --- Comment #7 from Barton Chittenden <barton@bywatersolutions.com> --- Just to be clear, this is ready for QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14617 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Barton, you should fix the author's patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14617 --- Comment #9 from Barton Chittenden <barton@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #8)
Barton, you should fix the author's patch.
Jonathan, I don't think that there's anything wrong with the patch ... I signed off on the patch for our partner library [we ran a demo for them], and I forgot to obsolete the un-signed patch when I submitted it. Test plan: 1) Import MARC21 bibs containing - ISBN in 020$z - ISSN in 022$y - ISSN in 022$z 2) Make sure that bibs are indexed 3) Search by ISBN and ISSN above -- bibs should not show in search. 4) Apply patch, re-index 5) Search again; ISBN in 020$z and ISSN in 022$y and 022$z should return results. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14617 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Barton Chittenden from comment #9)
(In reply to Jonathan Druart from comment #8)
Barton, you should fix the author's patch.
Jonathan,
I don't think that there's anything wrong with the patch ... I signed off on the patch for our partner library [we ran a demo for them], and I forgot to obsolete the un-signed patch when I submitted it.
The author's patch is "From: Koha instance bug_14617-koha <bug_14617-koha@bwsdev.bywatersolutions.com>" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14617 Barton Chittenden <barton@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42607|0 |1 is obsolete| | --- Comment #11 from Barton Chittenden <barton@bywatersolutions.com> --- Created attachment 43171 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43171&action=edit Bug 14617: Add fields to ISBN and ISSN indexes: 020$z, 022$y, 022$z http://bugs.koha-community.org/show_bug.cgi?id=14617 Signed-off-by: kholten@switchinc.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14617 --- Comment #12 from Barton Chittenden <barton@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #10)
(In reply to Barton Chittenden from comment #9)
(In reply to Jonathan Druart from comment #8)
Barton, you should fix the author's patch.
Jonathan,
I don't think that there's anything wrong with the patch ... I signed off on the patch for our partner library [we ran a demo for them], and I forgot to obsolete the un-signed patch when I submitted it.
The author's patch is "From: Koha instance bug_14617-koha <bug_14617-koha@bwsdev.bywatersolutions.com>"
Fixed author of patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14617 --- Comment #13 from Barton Chittenden <barton@bywatersolutions.com> --- (In reply to Barton Chittenden from comment #12)
(In reply to Jonathan Druart from comment #10)
The author's patch is "From: Koha instance bug_14617-koha <bug_14617-koha@bwsdev.bywatersolutions.com>"
Fixed author of patch.
Jonathan, can you take a quick look at this? I fixed the 'author' and 'email' on the patch. Thanks, --Barton -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14617 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14617 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43171|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 43422 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43422&action=edit Bug 14617: Add fields to ISBN and ISSN indexes: 020$z, 022$y, 022$z 1) Import MARC21 bibs containing - ISBN in 020$z - ISSN in 022$y - ISSN in 022$z 2) Make sure that bibs are indexed 3) Search by ISBN and ISSN above -- bibs should not show in search. 4) Apply patch, re-index 5) Search again; ISBN in 020$z and ISSN in 022$y and 022$z should return results. Signed-off-by: kholten@switchinc.org Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14617 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #15 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Barton! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org