[Bug 26838] New: Improve styling of checkin message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26838 Bug ID: 26838 Summary: Improve styling of checkin message Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org Created attachment 112596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112596&action=edit Checkin message box When an item type has a checkin message of the type "message" (rather than "alert"), the styling of the box is weird. The box is blue, but the background of the text is yellow. To replicate: 1) Go to Administration > Item types 2) Edit an item type and include a checkin message, the checkin message type should be "message" 3) Check in an item of that type I attached a screen capture of the blue/yellow message. In the manual, we can see what it used to look like : https://koha-community.org/manual/20.11/en/html/_images/itemtype-msg.png -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26838 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26838 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 112694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112694&action=edit Bug 26838: Improve styling of checkin message This patch makes some changes to the style and use of the "problem" class in the staff interface: - Remove the background color - Remove the extra line height Some changes to the template: - Remove the problem class from the checkin message. The checkin message configuration determines whether the dialog is an alert or a message-style dialog. - Add Font Awesome icons to the "problem" messages in patron details and serials collection. This is to help emphasize the message for users who might have difficulty seeing the color difference. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Go to Administration -> Item types and configure a checkin message for an item type: Add a message and select "Message" as the checkin message type. - Check in an item with that item type and confirm that you see the checkin message. It should be displayed in a message-style dialog without any additional styling. - Change the item type configuration to use "Alert" as the checkin message type. Confirm that the correct style is shown in this case as well. - Locate a patron with a NULL value in borrowers.password. View the detail page for that patron. - Under the "Library use" heading, the "Password" line should contain a link with the text "Undefined," preceded by a red-colored Font Awesome icon. - In Serials, locate a subscription which is expired. - View the details for the subscription, and then open "serial collection" from the sidebar menu. - On the serial collection page there should be a cell in the subscription summary table showing the message "Subscription expired" preceded by a red-colored Font Awesome icon. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26838 --- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 112727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112727&action=edit Text not vertically centered in alert box -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26838 --- Comment #3 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- It works! The only thing bugging me is that the text in the "alert" type box is not centered vertically... If this is me being too perfectionist, you can ignore me... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26838 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112694|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 115046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115046&action=edit Bug 26838: Improve styling of checkin message This patch makes some changes to the style and use of the "problem" class in the staff interface: - Remove the background color - Remove the extra line height Some changes to the template: - Remove the problem class from the checkin message. The checkin message configuration determines whether the dialog is an alert or a message-style dialog. - Add Font Awesome icons to the "problem" messages in patron details and serials collection. This is to help emphasize the message for users who might have difficulty seeing the color difference. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Go to Administration -> Item types and configure a checkin message for an item type: Add a message and select "Message" as the checkin message type. - Check in an item with that item type and confirm that you see the checkin message. It should be displayed in a message-style dialog without any additional styling. - Change the item type configuration to use "Alert" as the checkin message type. Confirm that the correct style is shown in this case as well. - Locate a patron with a NULL value in borrowers.password. View the detail page for that patron. - Under the "Library use" heading, the "Password" line should contain a link with the text "Undefined," preceded by a red-colored Font Awesome icon. - In Serials, locate a subscription which is expired. - View the details for the subscription, and then open "serial collection" from the sidebar menu. - On the serial collection page there should be a cell in the subscription summary table showing the message "Subscription expired" preceded by a red-colored Font Awesome icon. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26838 Salman Ali <salman.ali@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115046|0 |1 is obsolete| | --- Comment #5 from Salman Ali <salman.ali@inLibro.com> --- Created attachment 121809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121809&action=edit Bug 26838: Improve styling of checkin message This patch makes some changes to the style and use of the "problem" class in the staff interface: - Remove the background color - Remove the extra line height Some changes to the template: - Remove the problem class from the checkin message. The checkin message configuration determines whether the dialog is an alert or a message-style dialog. - Add Font Awesome icons to the "problem" messages in patron details and serials collection. This is to help emphasize the message for users who might have difficulty seeing the color difference. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Go to Administration -> Item types and configure a checkin message for an item type: Add a message and select "Message" as the checkin message type. - Check in an item with that item type and confirm that you see the checkin message. It should be displayed in a message-style dialog without any additional styling. - Change the item type configuration to use "Alert" as the checkin message type. Confirm that the correct style is shown in this case as well. - Locate a patron with a NULL value in borrowers.password. View the detail page for that patron. - Under the "Library use" heading, the "Password" line should contain a link with the text "Undefined," preceded by a red-colored Font Awesome icon. - In Serials, locate a subscription which is expired. - View the details for the subscription, and then open "serial collection" from the sidebar menu. - On the serial collection page there should be a cell in the subscription summary table showing the message "Subscription expired" preceded by a red-colored Font Awesome icon. Signed-off-by: Salman Ali <salman@outaouais> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26838 Salman Ali <salman.ali@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |salman.ali@inLibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26838 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26838 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121809|0 |1 is obsolete| | --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 122170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122170&action=edit Bug 26838: Improve styling of checkin message This patch makes some changes to the style and use of the "problem" class in the staff interface: - Remove the background color - Remove the extra line height Some changes to the template: - Remove the problem class from the checkin message. The checkin message configuration determines whether the dialog is an alert or a message-style dialog. - Add Font Awesome icons to the "problem" messages in patron details and serials collection. This is to help emphasize the message for users who might have difficulty seeing the color difference. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Go to Administration -> Item types and configure a checkin message for an item type: Add a message and select "Message" as the checkin message type. - Check in an item with that item type and confirm that you see the checkin message. It should be displayed in a message-style dialog without any additional styling. - Change the item type configuration to use "Alert" as the checkin message type. Confirm that the correct style is shown in this case as well. - Locate a patron with a NULL value in borrowers.password. View the detail page for that patron. - Under the "Library use" heading, the "Password" line should contain a link with the text "Undefined," preceded by a red-colored Font Awesome icon. - In Serials, locate a subscription which is expired. - View the details for the subscription, and then open "serial collection" from the sidebar menu. - On the serial collection page there should be a cell in the subscription summary table showing the message "Subscription expired" preceded by a red-colored Font Awesome icon. Signed-off-by: Salman Ali <salman@outaouais> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26838 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122170|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 122223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122223&action=edit Bug 26838: Improve styling of checkin message This patch makes some changes to the style and use of the "problem" class in the staff interface: - Remove the background color - Remove the extra line height Some changes to the template: - Remove the problem class from the checkin message. The checkin message configuration determines whether the dialog is an alert or a message-style dialog. - Add Font Awesome icons to the "problem" messages in patron details and serials collection. This is to help emphasize the message for users who might have difficulty seeing the color difference. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Go to Administration -> Item types and configure a checkin message for an item type: Add a message and select "Message" as the checkin message type. - Check in an item with that item type and confirm that you see the checkin message. It should be displayed in a message-style dialog without any additional styling. - Change the item type configuration to use "Alert" as the checkin message type. Confirm that the correct style is shown in this case as well. - Locate a patron with a NULL value in borrowers.password. View the detail page for that patron. - Under the "Library use" heading, the "Password" line should contain a link with the text "Undefined," preceded by a red-colored Font Awesome icon. - In Serials, locate a subscription which is expired. - View the details for the subscription, and then open "serial collection" from the sidebar menu. - On the serial collection page there should be a cell in the subscription summary table showing the message "Subscription expired" preceded by a red-colored Font Awesome icon. Signed-off-by: Salman Ali <salman.ali@inLibro.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26838 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Last patch fixes Salman's signed-off-by line (email address). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26838 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26838 --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26838 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Enhancement not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org