[Bug 8508] New: Holds to Pull : jQuery datatable dropdown not displaying correctly when an item can be pulled from multiple libraries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8508 Priority: P5 - low Change sponsored?: --- Bug ID: 8508 CC: gmcharlt@gmail.com Assignee: koha-bugs@lists.koha-community.org Summary: Holds to Pull : jQuery datatable dropdown not displaying correctly when an item can be pulled from multiple libraries Severity: minor Classification: Unclassified OS: All Reporter: dcook@prosentient.com.au Hardware: All Status: NEW Version: rel_3_8 Component: Hold requests Product: Koha When there is a hold for a "next available" item and multiple libraries/branches have that item available, each one is listed in the "Libraries" column of the "Holds to pull" page. Each library is separated by a <br> tag so that they are arranged in a vertical column. Unfortunately, the dropdown menu appears to use this column as a datasource, so it concatenates each library to produce one single string containing the codes/names of all the libraries. As a result, there is only one option when there should be 2 or more... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8508 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Holds to Pull : jQuery |Holds to Pull : Library |datatable dropdown not |dropdown options are |displaying correctly when |erroneously concatenated by |an item can be pulled from |br tags |multiple libraries | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8508 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |dcook@prosentient.com.au |ity.org | --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Created attachment 12122 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12122&action=edit Bug 8508 - Holds to Pull : Library dropdown options are erroneously concatenated by br tags While the new function I made works perfectly well, there might be a more efficient way of achieving the same outcome. I'm open to input, but it gets the job done. To Test Before Patching: 1) Create two items under the same bib record but with different home library locations. 2) Place a hold on the next available item (or two separate holds on the two separate items) *You'll notice the names of the two libraries in the field to the right of the hold's title. There is one library on each line, because they're "separated" by a linebreak <br> tag. *If you look at the drop-down menu at the bottom of the column, you will notice that the names of the two libraries have been concatenated together. If you look at the source, you will notice that there is a <br> tag that "glues" them together. 3) Apply the patch 4) Refresh your page and now you will see that the drop-down menu has separated those options, that there are no duplication of options, and that they have been sorted in alphabetical order. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8508 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12122|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 12175 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12175&action=edit [SIGNED-OFF] Bug 8508 - Holds to Pull : Library dropdown options are erroneously concatenated by br tags This patch introduces a new javascript function that breaks apart option strings that are erroneously concatenated by br tags. The split strings are then checked against non-concatenated option strings, and pushed into the option array if there is no duplication. This function is nestled into the JQuery datatable function for populating the drop-down menu. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8508 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Version|rel_3_8 |master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8508 --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 12184 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12184&action=edit Bug 8508: Followup: Simplify the separateData js function I think this patch does the same job as previously. + It replaces tabulation characters with 4 spaces -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8508 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff CC| |jonathan.druart@biblibre.co | |m --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Hi Owen and David, Could you confirmed that my proposed patch does the same job as previously ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8508 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12184|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 12227 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12227&action=edit [SIGNED-OFF] Bug 8508: Followup: Simplify the separateData js function -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8508 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8508 --- Comment #6 from David Cook <dcook@prosentient.com.au> --- Yep, Jonathan. It looks good. Sorry about the tabs! I've started using two different editors, and I hadn't switched the second from tabs to spaces. That should be remedied now :) (In reply to comment #4)
Hi Owen and David,
Could you confirmed that my proposed patch does the same job as previously ?
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8508 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |paul.poulain@biblibre.com --- Comment #7 from Paul Poulain <paul.poulain@biblibre.com> --- Sorry, but the follow-up does not apply : Applying: Bug 8508: Followup: Simplify the separateData js function fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 8508: Followup: Simplify the separateData js function When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". Patch left in /tmp/SIGNED-OFF-Bug-8508-Followup-Simplify-the-separate-TAB_O7.patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8508 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Patch doesn't apply --- Comment #8 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- It sounds like the problem is that this patch does not apply rather than that it failed QA. Owen, do you think you could rebase these two patches and reattach them to the bug? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8508 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- Paul could you retest please. Looks good to me: % git reset --hard origin/master% git bz apply 8508 Bug 8508 - Holds to Pull : Library dropdown options are erroneously concatenated by br tags [SIGNED-OFF] Bug 8508 - Holds to Pull : Library dropdown options are erroneously concatenated by br tags Apply? [yn] y Applying: Bug 8508 - Holds to Pull : Library dropdown options are erroneously concatenated by br tags [SIGNED-OFF] Bug 8508: Followup: Simplify the separateData js function Apply? [yn] y Applying: Bug 8508: Followup: Simplify the separateData js function Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8508 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #10 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Applying: Bug 8508: Followup: Simplify the separateData js function fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Does not apply -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8508 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12175|0 |1 is obsolete| | Attachment #12227|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 15358 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15358&action=edit Bug 8508 - Holds to Pull : Library dropdown options are erroneously concatenated by br tags This patch introduces a new javascript function that breaks apart option strings that are erroneously concatenated by br tags. The split strings are then checked against non-concatenated option strings, and pushed into the option array if there is no duplication. This function is nestled into the JQuery datatable function for populating the drop-down menu. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8508 --- Comment #12 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 15359 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15359&action=edit Bug 8508: Followup: Simplify the separateData js function I think this patch does the same job as previously. + It replaces tabulation characters with 4 spaces Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8508 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15358|0 |1 is obsolete| | Attachment #15359|0 |1 is obsolete| | --- Comment #13 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 16835 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16835&action=edit Bug 8508: Followup: Simplify the separateData js function I think this patch does the same job as previously. + It replaces tabulation characters with 4 spaces Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8508 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8508 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16835|0 |1 is obsolete| | --- Comment #14 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 16836 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16836&action=edit Bug 8508 - Holds to Pull : Library dropdown options are erroneously concatenated by br tags This patch introduces a new javascript function that breaks apart option strings that are erroneously concatenated by br tags. The split strings are then checked against non-concatenated option strings, and pushed into the option array if there is no duplication. This function is nestled into the JQuery datatable function for populating the drop-down menu. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8508 --- Comment #15 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 16837 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16837&action=edit Bug 8508: Followup: Simplify the separateData js function I think this patch does the same job as previously. + It replaces tabulation characters with 4 spaces Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8508 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off QA Contact| |m.de.rooy@rijksmuseum.nl --- Comment #16 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- QA Comment: Looks good to me. Works fine. Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8508 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8508 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #17 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8508 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #18 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.10.x will be in 3.10.6 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org