[Bug 31923] New: 'Ignore' tab description is misleading
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31923 Bug ID: 31923 Summary: 'Ignore' tab description is misleading Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com When you are modifying a MARC bibliographic framework, you can choose in which tab a particular subfield appears, or 'ignore' it. The description under this choice is 'Ignore means that the subfield does not display in the record editor' Which is true, but it doesn't mention that the subfield is completely removed from the record. This can cause data loss. If you're not aware of this, the 'Ignore' description is a bit misleading. I always instruct system administrators to use the 'Editor' checkbox if they do not want to see a particular subfield in the editor, and use only 'Ignore' if they really want to flush that subfield completely. I think the description could be improved to add that values will be deleted from the subfield as well. Maybe 'Ignore means that the subfield does not display in the record editor and that it's value, if any, is deleted from the record' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31923 --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- To see the Ignore tab in action, 1. Catalog a record with, for example, a value in 020$a 2. Save the record in MARCXML and view it in a text editor --> The 020$a subfield is there 3. Go to Administration > MARC bibliographic framework 4. Edit 020$a and put it in the 'Ignore' tab 5. Edit the record --> The 020$a field is not there anymore, which is normal and what the current description says 6. Don't change anything and save the record 7. Save the record in MARCXML and view it in a text editor --> The 020$a subfield is gone completely -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31923 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31923 --- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 142440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142440&action=edit Bug 31923: 'Ignore' tab description is misleading This patch modifies the description of the 'Ignore' tab in MARC bibliographic and authority framework administration to add that not only does the 'ignored' subfield not appear in the editor, but the subfield will also be deleted from the record. To test: 1. Go to Administration > MARC bibliographic framework 2. Click 'Actions' next to any framework and choose 'MARC structure' 3. Click 'Actions' next to any field and choose 'Edit subfields' 4. Check the hint/description under 'Managed in tab' and make sure it - makes sense - is written in correct english (syntax and spelling) - mentions that the subfield's value will be deleted from the record 5. Go to Administration > Authority types 6. Redo steps 2-4 for authority frameworks -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31923 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement modifies release notes| |the description of the | |'Ignore' tab in MARC | |bibliographic and authority | |framework administration to | |add that not only does the | |'ignored' subfield not | |appear in the editor, but | |the subfield will also be | |deleted from the record. | |This is the normal behavior | |of the 'Ignore' tab, it has | |not changed. Only the | |description was updated to | |reflect it's actual | |behavior. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31923 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |caroline.cyr-la-rose@inlibr |ity.org |o.com CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Hi Caroline. Everything works as per the test plan. For the grammar, "..it's.." should be "..its..". This is one of English's idiosyncrasies - would read as "..it is.." if expanded out, rather than the possessive! https://www.grammarly.com/blog/its-vs-its/ I was thinking, if possible, it may be useful to add a warning symbol before the text (the triangle icon with an exclamation mark), similar to what is on the Tools > Log viewer page. I've also changed the assignee to you. Thanks for creating the bug and fix from the IRC conversation (http://irc.koha-community.org/koha/2022-10-20#i_2457304). I think that the option "Managed in tab: ignore" is quite misleading (but I can't think of a better option name that makes sense), as: - there is no "ignore" tab, and - it removes any values if the record is saved! Testing notes (using koha-testing-docker): - Record used for testing bibliographic record: 262 (Programming Perl), has an 020$a value - Record used for testing an authority record: 1525 (Perl (Computer language)), used 040$c David -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31923 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142440|0 |1 is obsolete| | --- Comment #4 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 142444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142444&action=edit Bug 31923: 'Ignore' tab description is misleading This patch modifies the description of the 'Ignore' tab in MARC bibliographic and authority framework administration to add that not only does the 'ignored' subfield not appear in the editor, but the subfield will also be deleted from the record. To test: 1. Go to Administration > MARC bibliographic framework 2. Click 'Actions' next to any framework and choose 'MARC structure' 3. Click 'Actions' next to any field and choose 'Edit subfields' 4. Check the hint/description under 'Managed in tab' and make sure it - makes sense - is written in correct english (syntax and spelling) - mentions that the subfield's value will be deleted from the record 5. Go to Administration > Authority types 6. Redo steps 2-4 for authority frameworks -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31923 --- Comment #5 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 142445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142445&action=edit Bug 31923: 'Ignore' tab description is misleading This patch adds a small warning sign before the sentence and also puts the sentence inside a span. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31923 --- Comment #6 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Hi David! Thanks for testing! I corrected the "its". I also added a second commit with the warning sign. I wasn't sure how to put a space between the warning sign and the sentence... Maybe someone could help? Thanks! Caroline -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31923 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142445|0 |1 is obsolete| | --- Comment #7 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 142446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142446&action=edit Bug 31923: 'Ignore' tab description is misleading This patch adds a small warning sign before the sentence and also puts the sentence inside a span. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31923 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142444|0 |1 is obsolete| | Attachment #142446|0 |1 is obsolete| | --- Comment #8 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 142447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142447&action=edit Bug 31923: 'Ignore' tab description is misleading This patch modifies the description of the 'Ignore' tab in MARC bibliographic and authority framework administration to add that not only does the 'ignored' subfield not appear in the editor, but the subfield will also be deleted from the record. To test: 1. Go to Administration > MARC bibliographic framework 2. Click 'Actions' next to any framework and choose 'MARC structure' 3. Click 'Actions' next to any field and choose 'Edit subfields' 4. Check the hint/description under 'Managed in tab' and make sure it - makes sense - is written in correct english (syntax and spelling) - mentions that the subfield's value will be deleted from the record 5. Go to Administration > Authority types 6. Redo steps 2-4 for authority frameworks -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31923 --- Comment #9 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 142448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142448&action=edit Bug 31923: 'Ignore' tab description is misleading This patch adds a small warning sign before the sentence and also puts the sentence inside a span. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31923 --- Comment #10 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I think I managed the space, but I'm not sure if it is the right way to do it... Also I had to flex my (teeny tiny) git muscles quite a lot so I hope my submissions are OK! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31923 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31923 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142447|0 |1 is obsolete| | Attachment #142448|0 |1 is obsolete| | --- Comment #11 from David Nind <david@davidnind.com> --- Created attachment 142466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142466&action=edit Bug 31923: 'Ignore' tab description is misleading This patch modifies the description of the 'Ignore' tab in MARC bibliographic and authority framework administration to add that not only does the 'ignored' subfield not appear in the editor, but the subfield will also be deleted from the record. To test: 1. Go to Administration > MARC bibliographic framework 2. Click 'Actions' next to any framework and choose 'MARC structure' 3. Click 'Actions' next to any field and choose 'Edit subfields' 4. Check the hint/description under 'Managed in tab' and make sure it - makes sense - is written in correct english (syntax and spelling) - mentions that the subfield's value will be deleted from the record 5. Go to Administration > Authority types 6. Redo steps 2-4 for authority frameworks Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31923 --- Comment #12 from David Nind <david@davidnind.com> --- Created attachment 142467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142467&action=edit Bug 31923: Add warning sign and span This patch adds a small warning sign before the sentence and also puts the sentence inside a span. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31923 --- Comment #13 from David Nind <david@davidnind.com> --- (In reply to Caroline Cyr La Rose from comment #10)
I think I managed the space, but I'm not sure if it is the right way to do it... Also I had to flex my (teeny tiny) git muscles quite a lot so I hope my submissions are OK!
It looks OK to me, and the patch applied cleanly. I changed the title of the commit message for the second patch so that it is different from the main patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31923 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31923 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142466|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 142565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142565&action=edit Bug 31923: 'Ignore' tab description is misleading This patch modifies the description of the 'Ignore' tab in MARC bibliographic and authority framework administration to add that not only does the 'ignored' subfield not appear in the editor, but the subfield will also be deleted from the record. To test: 1. Go to Administration > MARC bibliographic framework 2. Click 'Actions' next to any framework and choose 'MARC structure' 3. Click 'Actions' next to any field and choose 'Edit subfields' 4. Check the hint/description under 'Managed in tab' and make sure it - makes sense - is written in correct english (syntax and spelling) - mentions that the subfield's value will be deleted from the record 5. Go to Administration > Authority types 6. Redo steps 2-4 for authority frameworks Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31923 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142467|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 142566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142566&action=edit Bug 31923: Add warning sign and span This patch adds a small warning sign before the sentence and also puts the sentence inside a span. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31923 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31923 --- Comment #16 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31923 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27730 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31923 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31923 Lauren Denny <lauren_denny@sil.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lauren_denny@sil.org -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org