[Bug 36909] New: Eliminate duplicate ID in cookie consent markup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36909 Bug ID: 36909 Summary: Eliminate duplicate ID in cookie consent markup Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 27378 The HTML validator complains about duplicate IDs in the cookie consent markup: One div#consentButtons in the header, one in the footer. These can be updated to be classes instead. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36909 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36909 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 166979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166979&action=edit Bug 36909: Eliminate duplicate ID in cookie consent markup This patch changes markup and CSS in the OPAC and staff client to eliminate HTML validator warnings about duplicate ids. To test, apply the patch and rebuild all CSS (Bug 36909: Eliminate duplicate ID in cookie consent markup). - If necessary, set the "CookieConsent" system preference to "Require." - Open the OPAC in a new private window (to prevent previous consents from hiding the consent messages). - You should see a cookie consent bar across the bottom of the page. It should look correct, and its contents should reflow well at various browser widths. - Click "Accept all cookies." - In the header you should now see a "Your cookies" link. - Click it and confirm that the contents of the modal look correct and reflow well at various browser widths. - Perform the same tests in the staff interface. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36909 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36909 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166979|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 167061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167061&action=edit Bug 36909: Eliminate duplicate ID in cookie consent markup This patch changes markup and CSS in the OPAC and staff client to eliminate HTML validator warnings about duplicate ids. To test, apply the patch and rebuild all CSS (Bug 36909: Eliminate duplicate ID in cookie consent markup). - If necessary, set the "CookieConsent" system preference to "Require." - Open the OPAC in a new private window (to prevent previous consents from hiding the consent messages). - You should see a cookie consent bar across the bottom of the page. It should look correct, and its contents should reflow well at various browser widths. - Click "Accept all cookies." - In the header you should now see a "Your cookies" link. - Click it and confirm that the contents of the modal look correct and reflow well at various browser widths. - Perform the same tests in the staff interface. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36909 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Picked from QA queue for main. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36909 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36909 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36909 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.11.00 |24.11.00,24.05.02 released in| | CC| |lucas@bywatersolutions.com Status|Pushed to main |Pushed to stable --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36909 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixes HTML validation release notes| |warnings about duplicate | |IDs in the cookie consent | |markup for the OPAC and | |staff interface. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36909 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to stable |Pushed to oldstable --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Does not apply on 23.11.x Maybe some other dependancy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36909 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36909 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36909 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36909 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org