[Bug 9680] New: cart aligned right in CCSR
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9680 Bug ID: 9680 Summary: cart aligned right in CCSR Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.10 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: nengard@gmail.com Created attachment 15576 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15576&action=edit cart in prog When you're using CCSR the cart contents have a big margin on the left that's pushing them off screen. Attached are images of the same cart in both themes - the window is the same size in both. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9680 --- Comment #1 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 15577 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15577&action=edit cart in ccsr see how i have to make the window bigger to see the contents and there is an extra large margin on the left. It should be centered to the window like in PROG -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9680 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.10 |master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9680 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9680 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9680 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 18078 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18078&action=edit Bug 9680 - cart aligned right in CCSR The CCSR theme sets a min-width of 1000px for windows which are more than 700px wide. This caused the cart popup window to be given a min-width of 1000px, resulting in a broken layout with unnecessary horizontal scrolling. This patch adds a class to the cart template and to other pop-up window templates to ensure that a large min-width is not enforced and to give consistent padding to those pages. To test, set your theme to 'CCSR' and view the following pop-up pages: - The Cart. From the cart, trigger: - The "send" window - The "download" window - From a view of a List's contents trigger: - The "send" window" - The "download" window Each of these pages should look correct with no horizontal scrolling. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9680 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18078|0 |1 is obsolete| | --- Comment #3 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 18079 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18079&action=edit [SIGNED-OFF] Bug 9680 - cart aligned right in CCSR The CCSR theme sets a min-width of 1000px for windows which are more than 700px wide. This caused the cart popup window to be given a min-width of 1000px, resulting in a broken layout with unnecessary horizontal scrolling. This patch adds a class to the cart template and to other pop-up window templates to ensure that a large min-width is not enforced and to give consistent padding to those pages. To test, set your theme to 'CCSR' and view the following pop-up pages: - The Cart. From the cart, trigger: - The "send" window - The "download" window - From a view of a List's contents trigger: - The "send" window" - The "download" window Each of these pages should look correct with no horizontal scrolling. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> All tests pass -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9680 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9680 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9680 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18079|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 18088 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18088&action=edit [PASSED QA] Bug 9680 - cart aligned right in CCSR The CCSR theme sets a min-width of 1000px for windows which are more than 700px wide. This caused the cart popup window to be given a min-width of 1000px, resulting in a broken layout with unnecessary horizontal scrolling. This patch adds a class to the cart template and to other pop-up window templates to ensure that a large min-width is not enforced and to give consistent padding to those pages. To test, set your theme to 'CCSR' and view the following pop-up pages: - The Cart. From the cart, trigger: - The "send" window - The "download" window - From a view of a List's contents trigger: - The "send" window" - The "download" window Each of these pages should look correct with no horizontal scrolling. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> All tests pass Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Template and CSS changes only, but no string changes. Save for inclusion in 3.12. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9680 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org