http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10054 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch Assignee|gmcharlt@gmail.com |kyle.m.hall@gmail.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10054 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, but shouldn't you have only one library when singlebranchmode is enabled? I am asking because we have a bug to remove this system preference altogether: bug 7314 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10054 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, we work differently. We have an administration account in each library and only use the database admin account for updating and creating this user. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10054 --- Comment #6 from Nicole C. Engard <nengard@gmail.com> --- How do you prevent the libraries from messing with your user? That's why we use the admin one. Nicole -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10054 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10054 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17453|0 |1 is obsolete| | --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 18049 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18049&action=edit [SIGNED-OFF] Bug 10054 - When SingleBranchMode is enabled, allow superlibrarians to set logged in library Currently, when SingleBranchMode is enabled, nobody can change the logged in library in Koha. To change it requires disable SingleBranchMode, switching the library, and re-enabling it. It seems reasonable to allow superlibrarians to switch the logged in library even if SingleBranchMode is enabled. Test Plan: 1) Apply this patch 3) Enable SingleBranchMode 4) Log in as a superlibrarian 5) Attempt to change the logged in branch This change should succeed 6) Log in as a non-superlibrarian account 7) Attempt to change the logged n branch This should not be allowed, as per Koha's current behavior Signed-off-by: Owen Leonard <oleonard@myacpl.org> I guess this doesn't do any harm even though the practical motivations behind it, as described in the bug, seem otherwise solvable. If SingleBranchMode is supposed to prevent librarians from switching their logged in library why can they choose their library when they first log in? Was SingleBranchMode supposed to only affect the OPAC originally? Or should the login form be modified? This seems to be a band-aid on a poorly-implemented feature. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10054 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18049|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 18093 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18093&action=edit [PASSED QA] Bug 10054 - When SingleBranchMode is enabled, allow superlibrarians to set logged in library Currently, when SingleBranchMode is enabled, nobody can change the logged in library in Koha. To change it requires disable SingleBranchMode, switching the library, and re-enabling it. It seems reasonable to allow superlibrarians to switch the logged in library even if SingleBranchMode is enabled. Test Plan: 1) Apply this patch 3) Enable SingleBranchMode 4) Log in as a superlibrarian 5) Attempt to change the logged in branch This change should succeed 6) Log in as a non-superlibrarian account 7) Attempt to change the logged n branch This should not be allowed, as per Koha's current behavior Signed-off-by: Owen Leonard <oleonard@myacpl.org> I guess this doesn't do any harm even though the practical motivations behind it, as described in the bug, seem otherwise solvable. If SingleBranchMode is supposed to prevent librarians from switching their logged in library why can they choose their library when they first log in? Was SingleBranchMode supposed to only affect the OPAC originally? Or should the login form be modified? This seems to be a band-aid on a poorly-implemented feature. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Patch works as decribed. As this only adds a check for a superlibrarian it seems safe and should not interfere with normal staff accounts. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10054 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.