[Bug 27412] New: Update intranet-tmpl/prog/en/modules/tools/overduerules.tt to adhere to ACC2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27412 Bug ID: 27412 Summary: Update intranet-tmpl/prog/en/modules/tools/overduerules.tt to adhere to ACC2 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Inputs of type="number" need updating to adhere to ACC2 on intranet-tmpl/prog/en/modules/tools/overduerules.tt -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27412 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy Blocks| |26962 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26962 [Bug 26962] Koha notice/slips/receipts should print in true black (#000000) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27412 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|26962 |26926 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26926 [Bug 26926] Update all occurrences of <input type="number"> to apply ACC2 coding guideline https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26962 [Bug 26962] Koha notice/slips/receipts should print in true black (#000000) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27412 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz --- Comment #1 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Hi Martin, I tried to find more information on this and was probably searching for the wrong thing. Can you please provide a resource for ACC2? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27412 --- Comment #2 from Aleisha Amohia <aleisha@catalyst.net.nz> --- (In reply to Aleisha Amohia from comment #1)
Hi Martin, I tried to find more information on this and was probably searching for the wrong thing. Can you please provide a resource for ACC2?
Never mind, just saw the comment on Bug 26926 :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27412 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://wiki.koha-community | |.org/wiki/Coding_Guidelines | |#ACC2:_Input_type_.22number | |.22_should_be_avoided --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Sorry, I should have linked to the Guidelines.. https://wiki.koha-community.org/wiki/Coding_Guidelines#ACC2:_Input_type_.22n... Splitting them up into lots of tiny bugs as requested by Katrin took me a little while and I didn't think to add the link to all bugs. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27412 James O'Keeffe <jamespfk@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |jamespfk@gmail.com |ity.org | CC| |jamespfk@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27412 James O'Keeffe <jamespfk@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27412 --- Comment #4 from James O'Keeffe <jamespfk@gmail.com> --- Created attachment 115380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115380&action=edit Bug 27412: Update intranet-tmpl/prog/en/modules/tools/overduerules.tt to adhere to ACC2 This patch changes the 1 occurance of an input of type="number" to input type="text" inputmode="numeric" pattern="[0-9]*" Test plan: Open the file and ensure that no other inputs of type="number were missed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27412 Catherine <catherinem2003@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27412 Catherine <catherinem2003@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115380|0 |1 is obsolete| | --- Comment #5 from Catherine <catherinem2003@gmail.com> --- Created attachment 115393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115393&action=edit Bug 27412: Update intranet-tmpl/prog/en/modules/tools/overduerules.tt to adhere to ACC2 This patch changes the 1 occurance of an input of type="number" to input type="text" inputmode="numeric" pattern="[0-9]*" Test plan: Open the file and ensure that no other inputs of type="number were missed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27412 Catherine <catherinem2003@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27412 Catherine <catherinem2003@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115393|0 |1 is obsolete| | --- Comment #6 from Catherine <catherinem2003@gmail.com> --- Created attachment 115395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115395&action=edit Bug 27412: Update intranet-tmpl/prog/en/modules/tools/overduerules.tt to adhere to ACC2 This patch changes the 1 occurance of an input of type="number" to input type="text" inputmode="numeric" pattern="[0-9]*" Test plan: Open the file and ensure that no other inputs of type="number were missed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27412 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- There is more to do when converting a "type='number'" input: If present, the "step," "max," and "min" attributes should be removed too. They are invalid if applied to a standard text input. Example errors from the w3c validator: Error: Attribute step not allowed on element input at this point. Error: Attribute min not allowed on element input at this point. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27412 James O'Keeffe <jamespfk@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27412 James O'Keeffe <jamespfk@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115395|0 |1 is obsolete| | --- Comment #8 from James O'Keeffe <jamespfk@gmail.com> --- Created attachment 115455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115455&action=edit Bug 27412: Update intranet-tmpl/prog/en/modules/tools/overduerules.tt to adhere to ACC2 This patch changes the 1 occurance of an input of type="number" to input type="text" inputmode="numeric" pattern="[0-9]*" The "min" attribute has also been removed (Thanks Owen) Test plan: Open the file and ensure that no other inputs of type="number were missed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27412 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27412 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115455|0 |1 is obsolete| | --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 115479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115479&action=edit Bug 27412: Update intranet-tmpl/prog/en/modules/tools/overduerules.tt to adhere to ACC2 This patch changes the 1 occurance of an input of type="number" to input type="text" inputmode="numeric" pattern="[0-9]*" The "min" attribute has also been removed (Thanks Owen) Test plan: Open the file and ensure that no other inputs of type="number were missed. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27412 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115479|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 115519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115519&action=edit Bug 27412: Update intranet-tmpl/prog/en/modules/tools/overduerules.tt to adhere to ACC2 This patch changes the 1 occurance of an input of type="number" to input type="text" inputmode="numeric" pattern="[0-9]*" The "min" attribute has also been removed (Thanks Owen) Test plan: Open the file and ensure that no other inputs of type="number were missed. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27412 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Great work, thank James. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27412 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115519|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 115557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115557&action=edit Bug 27412: Update tools/overduerules.tt to adhere to ACC2 This patch changes the 1 occurance of an input of type="number" to input type="text" inputmode="numeric" pattern="[0-9]*" The "min" attribute has also been removed (Thanks Owen) Test plan: Open the file and ensure that no other inputs of type="number were missed. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27412 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27412 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27412 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org