https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27409 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|26962 |26926 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26926 [Bug 26926] Update all occurrences of <input type="number"> to apply ACC2 coding guideline https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26962 [Bug 26962] Koha notice/slips/receipts should print in true black (#000000) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27409 James O'Keeffe <jamespfk@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27409 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- There is more to do when converting a "type='number'" input: If present, the "step," "max," and "min" attributes should be removed too. They are invalid if applied to a standard text input. Example errors from the w3c validator: Error: Attribute step not allowed on element input at this point. Error: Attribute min not allowed on element input at this point. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27409 James O'Keeffe <jamespfk@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115397|0 |1 is obsolete| | --- Comment #3 from James O'Keeffe <jamespfk@gmail.com> --- Created attachment 115460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115460&action=edit Bug 27409: Update intranet-tmpl/prog/en/modules/members/boraccount.tt for ACC2 This patch changes all instances of type="number" in inputs to adhere with the ACC2 guidelines In addition, all "min" and "step" attributes have been removed from these inputs (Thanks Owen). Test plan: Go through the boraccount.tt file and insure that no instances of type="number" were missed. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27409 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115460|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 115481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115481&action=edit Bug 27409: Update intranet-tmpl/prog/en/modules/members/boraccount.tt for ACC2 This patch changes all instances of type="number" in inputs to adhere with the ACC2 guidelines In addition, all "min" and "step" attributes have been removed from these inputs (Thanks Owen). Test plan: Go through the boraccount.tt file and insure that no instances of type="number" were missed. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27409 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Excellent work again, Passing QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27409 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115520|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 115555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115555&action=edit Bug 27409: Update members/boraccount.tt for ACC2 This patch changes all instances of type="number" in inputs to adhere with the ACC2 guidelines In addition, all "min" and "step" attributes have been removed from these inputs (Thanks Owen). Test plan: Go through the boraccount.tt file and insure that no instances of type="number" were missed. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27409 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27409 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.