https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30807 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 135201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135201&action=edit Bug 30807: Migrate to patron-title in pay and paycollect This patch updates the member-flags template to use the patron-title.inc include wherever patron names are referenced. Test plan 1) Navigate to a patron and click through to their accounts tab 2) Note how the patron name displays in the title, breadcrumb and headings 3) Click through to make a payment 4) Note how the patron name displays in the title, breadcrumb and headings 5) Apply the patch and reload the page 6) Confirm the patron name still appears in each location and is consistently formatted and linked as you would expect Note: This patch also removes a superflous hidden title form element that was simply passed to and from the controller but not actually used in any way. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30807 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30807 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135201|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 135285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135285&action=edit Bug 30807: Migrate to patron-title in pay and paycollect This patch updates the member-flags template to use the patron-title.inc include wherever patron names are referenced. Test plan 1) Navigate to a patron and click through to their accounts tab 2) Note how the patron name displays in the title, breadcrumb and headings 3) Click through to make a payment 4) Note how the patron name displays in the title, breadcrumb and headings 5) Apply the patch and reload the page 6) Confirm the patron name still appears in each location and is consistently formatted and linked as you would expect Note: This patch also removes a superflous hidden title form element that was simply passed to and from the controller but not actually used in any way. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30807 --- Comment #3 from David Nind <david@davidnind.com> --- The patch description needs updating - it currently says "...the member-flags template..." when it covers the patron payments pages. 8-) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30807 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Certainly a coding preference, but I personally prefer to explicitly pass the variable, even if not needed, like [% INCLUDE 'patron-title.inc' patron=patron %] instead of [% INCLUDE 'patron-title.inc' %] It prevent future cleaning to easily miss a variable that would be called from an include file. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30807 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135285|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135470&action=edit Bug 30807: Migrate to patron-title in pay and paycollect This patch updates the member-flags template to use the patron-title.inc include wherever patron names are referenced. Test plan 1) Navigate to a patron and click through to their accounts tab 2) Note how the patron name displays in the title, breadcrumb and headings 3) Click through to make a payment 4) Note how the patron name displays in the title, breadcrumb and headings 5) Apply the patch and reload the page 6) Confirm the patron name still appears in each location and is consistently formatted and linked as you would expect Note: This patch also removes a superflous hidden title form element that was simply passed to and from the controller but not actually used in any way. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30807 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30807 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|22.11.00 |22.11.00, 22.05.03 released in| | CC| |lucas@bywatersolutions.com --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for 22.05.03 -- You are receiving this mail because: You are watching all bug changes.