https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30768 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- koha-tmpl/intranet-tmpl/prog/en/modules/members/two_factor_auth.tt:61 Pin code: -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30768 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- IF this is ready for signoff (the bug doesn't say so): The changes to the template and test look great, but the .po files shouldn't be changed in the patch. They will get updated when translations are updated. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30768 Michal Urban <michalurban177@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michalurban177@gmail.com Status|NEW |Needs Signoff --- Comment #5 from Michal Urban <michalurban177@gmail.com> --- (In reply to Owen Leonard from comment #3)

IF this is ready for signoff (the bug doesn't say so): The changes to the template and test look great, but the .po files shouldn't be changed in the patch. They will get updated when translations are updated.

I wasn't sure if there needed to be changes in the .po files, but thanks for clarification. The new patch reverts the changes, and only keeps the template/test changes. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30768 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135822|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 135833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135833&action=edit Bug 30768: Capitalizing "pin" in 2FA setup Change of text from "pin" to "PIN" in the 2FA setup interface. This slight changes clarifies that "PIN" is an acronym, and increases user comprehension To test: 1) Log in as an Administrator 2) Enable TwoFactorAuthentication 3) Log in to a user with superlibrarian permissions. 4) On the user profile page, click the "More" dropdown button, click "Manage Two-Factor 5) Check that "pin" is displayed in lowercase, in both instances. 6) Apply patch. 7) Refresh the page and observe that "pin" has changed to "PIN" 8) Sign off. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30768 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30768 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135833|0 |1 is obsolete| | --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 135850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135850&action=edit Bug 30768: Capitalizing "pin" in 2FA setup Change of text from "pin" to "PIN" in the 2FA setup interface. This slight changes clarifies that "PIN" is an acronym, and increases user comprehension To test: 1) Log in as an Administrator 2) Enable TwoFactorAuthentication 3) Log in to a user with superlibrarian permissions. 4) On the user profile page, click the "More" dropdown button, click "Manage Two-Factor 5) Check that "pin" is displayed in lowercase, in both instances. 6) Apply patch. 7) Refresh the page and observe that "pin" has changed to "PIN" 8) Sign off. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30768 --- Comment #9 from Michal Urban <michalurban177@gmail.com> --- (In reply to Lucas Gass from comment #8)

Template and test changes look good, tests all still pass, QA script is happy.

Welcome aboard Michal!

Thanks Lucas! :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30768 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.