[Bug 13619] New: Add a link for pending suggestion on acqui-home.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13619 Bug ID: 13619 Summary: Add a link for pending suggestion on acqui-home.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: marjorie.barry-vila@ccsr.qc.ca QA Contact: testopia@bugs.koha-community.org Created attachment 35515 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35515&action=edit suggestion Hi, It would be nice that a link be added on text "suggestion waiting" to arrive in pending tab in suggestion.pl. Regards, Marjorie -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13619 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13619 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 39472 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39472&action=edit Bug 13619: Acq home: ensure 'manage suggestions' goes to pending suggestions The link on the start page of Koha goes to the pending suggestions tab explicitly. The link on the acquisition start page doesn't do that so when you have your own status it might show another tab first. Patch links to be the same and explicitly target the pending tab. To test: - create a new suggestion - verify link from the acq start page leads to the pending tab - verify link from the Koha start page does the same -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13619 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13619 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add a link for pending |Acq home: ensure 'manage |suggestion on acqui-home.pl |suggestions' goes to | |pending suggestions -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13619 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes@biblibre.com Status|Needs Signoff |Signed Off --- Comment #2 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Marjorie <marjorie.barry-vila@ccsr.qc.ca> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13619 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39472|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13619 --- Comment #3 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 39542 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39542&action=edit Bug 13619: Acq home: ensure 'manage suggestions' goes to pending suggestions The link on the start page of Koha goes to the pending suggestions tab explicitly. The link on the acquisition start page doesn't do that so when you have your own status it might show another tab first. Patch links to be the same and explicitly target the pending tab. To test: - create a new suggestion - verify link from the acq start page leads to the pending tab - verify link from the Koha start page does the same Signed-off-by: Marjorie <marjorie.barry-vila@ccsr.qc.ca> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13619 --- Comment #4 from Marjorie Barry-Vila <marjorie.barry-vila@ccsr.qc.ca> --- (In reply to Katrin Fischer from comment #1)
Created attachment 39472 [details] [review] Bug 13619: Acq home: ensure 'manage suggestions' goes to pending suggestions
The link on the start page of Koha goes to the pending suggestions tab explicitly. The link on the acquisition start page doesn't do that so when you have your own status it might show another tab first. Patch links to be the same and explicitly target the pending tab.
To test: - create a new suggestion - verify link from the acq start page leads to the pending tab - verify link from the Koha start page does the same
I tested the patch on sandbox and it works as expected! Thanks! Marjorie -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13619 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13619 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39542|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 39591 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39591&action=edit Bug 13619: Acq home: ensure 'manage suggestions' goes to pending suggestions The link on the start page of Koha goes to the pending suggestions tab explicitly. The link on the acquisition start page doesn't do that so when you have your own status it might show another tab first. Patch links to be the same and explicitly target the pending tab. To test: - create a new suggestion - verify link from the acq start page leads to the pending tab - verify link from the Koha start page does the same Signed-off-by: Marjorie <marjorie.barry-vila@ccsr.qc.ca> Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13619 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Katrina! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org