[Bug 14039] New: Add patron title to checkout screen
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14039 Bug ID: 14039 Summary: Add patron title to checkout screen Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: david.roberts@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com When checking out an item to a user, it sounds more professional if the patron can be addressed as Mr / Mrs / Miss etc, but this information doesn't display to the staff member, who has to click on the details tab in order to find out how the patron should be addressed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14039 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |david.roberts@ptfs-europe.c |ity.org |om -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14039 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david.roberts@ptfs-europe.c | |om --- Comment #1 from David Roberts <david.roberts@ptfs-europe.com> --- Created attachment 38314 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38314&action=edit Proposed patch To test: Install this patch. Ensure a user has a salutation (Mr, Dr, Miss etc) set, and checkout an item to this user. In the area above the barcode box, the patron's title should display, e.g: Checking out to Mr John Doe (0001). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14039 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14039 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch Status|Needs Signoff |Patch doesn't apply --- Comment #2 from Marc Véron <veron@veron.ch> --- Wanted to test, does not apply: CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/patron-title.inc Failed to merge in the changes. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14039 --- Comment #3 from David Roberts <david.roberts@ptfs-europe.com> --- Created attachment 38495 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38495&action=edit Add patron salutation to checkout screen -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14039 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38314|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14039 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #4 from David Roberts <david.roberts@ptfs-europe.com> --- Sorry, my mistake - I was tracking the wrong version! A new patch has now been submitted so hopefully it will work this time. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14039 --- Comment #5 from Marc Véron <veron@veron.ch> --- Created attachment 38498 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38498&action=edit [Signed-off] Add patron salutation to checkout screen To test: Install this patch. Ensure a user has a salutation (Mr, Dr, Miss etc) set, and checkout an item to this user. In the area above the barcode box, the patron's title should display, e.g: Checking out to Mr John Doe (0001). --- Followed test plan. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14039 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38495|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14039 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14039 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14039 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38498|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 38734 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38734&action=edit [PASSED QA] Bug 14039 - Add patron salutation to checkout screen To test: Install this patch. Ensure a user has a salutation (Mr, Dr, Miss etc) set, and checkout an item to this user. In the area above the barcode box, the patron's title should display, e.g: Checking out to Mr John Doe (0001). Followed test plan. Works as expected. Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14039 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Failed QA --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- 1) I think this patch introduces a change in much more places than expected: $ git grep patron-title.inc | wc -l 1491 I suggest that such a change should be optional, and could be done like this: - [%- borrower.firstname %] [% IF borrower.othernames %] ([% borrower.othernames %]) [% END %] [% borrower.surname %] + <span id="patron-title">[%- borrower.title %] </span>[% borrower.firstname %] [% IF borrower.othernames %] ([% borrower.othernames %]) [% END %] [% borrower.surname %] i.e. putting the title inside a span with an id, and change CSS to hide it by default. So you keep the enhancement you want, but people can opt-in instead of making it mandatory (e.g. #patron-title { display: none; } ) 2) Please make it check for borrower.title to avoid warnings? [%- IF borrower.title -%] etc -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14039 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.18 |master -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org