[Bug 43450] New: Add actions column to list of courses with more menu options
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43450 Bug ID: 43450 Summary: Add actions column to list of courses with more menu options Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Course reserves Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 42013 Target Milestone: --- I suggest we replace the "Edit" and "Delete" buttons with a menu containing "Edit," "Delete," "Add reserves," and "Batch add reserves." This replicates all the toolbar buttons on the course detail page. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42013 [Bug 42013] Confirmation dialog for "Remove all reserves" never shown on course details page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43450 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43450 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Owen Leonard from comment #0)
I suggest we replace the "Edit" and "Delete" buttons
Haha those don't exist on the page. I forgot where I was starting from! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43450 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Sponsorship status|--- |Sponsored Status|ASSIGNED |Needs Signoff Comma delimited| |Athens County Public list of Sponsors| |Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43450 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 204778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204778&action=edit Bug 43450: Add actions column to list of courses with more menu options This patch adds a new "Actions" menu to the list of courses. The menu includes "Edit," "Delete," "Add reserves," and "Batch add reserves." This selection replicates the toolbar controls on the course details page. The patch also adds a new column to the table listing course reserves showing the number of reserves for the course. To test apply the patch and restart services. - Go to Course reserves and if necessary, add a course and add reserves to it. - From the list of course reserves, confirm that there is now a "Reserves" column after the "# of students" column and that it correctly shows the number of reserves added to your course. - Confirm that the "Actions" menu looks correct and test each of the menu items. - Test the menu with a course which has reserve and with a course that doesn't. The "Remove all reserves" menu item shouldn't appear if there are no reserves. - Test "Remove all reserves" with courses which have only one reserve and with courses that have multiple. - Test the menus as a user with various levels of permissions: - Add course reserves (add_reserves) - Remove course reserves (delete_reserves) - Add, edit and delete courses (manage_courses) - With no course reserves permissions the "Actions" column should be hidden. - On the course details page test the "Remove all reserves" button. - See if the new icon for "Batch add reserves" works well. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43450 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43450 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #204778|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43450 --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 204958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204958&action=edit Bug 43450: Add actions column to list of courses with more menu options This patch adds a new "Actions" menu to the list of courses. The menu includes "Edit," "Delete," "Add reserves," and "Batch add reserves." This selection replicates the toolbar controls on the course details page. The patch also adds a new column to the table listing course reserves showing the number of reserves for the course. To test apply the patch and restart services. - Go to Course reserves and if necessary, add a course and add reserves to it. - From the list of course reserves, confirm that there is now a "Reserves" column after the "# of students" column and that it correctly shows the number of reserves added to your course. - Confirm that the "Actions" menu looks correct and test each of the menu items. - Test the menu with a course which has reserve and with a course that doesn't. The "Remove all reserves" menu item shouldn't appear if there are no reserves. - Test "Remove all reserves" with courses which have only one reserve and with courses that have multiple. - Test the menus as a user with various levels of permissions: - Add course reserves (add_reserves) - Remove course reserves (delete_reserves) - Add, edit and delete courses (manage_courses) - With no course reserves permissions the "Actions" column should be hidden. - On the course details page test the "Remove all reserves" button. - See if the new icon for "Batch add reserves" works well. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43450 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- Everything still seems to work OK and as expected. I'm just curious why we don't also add the Actions button with Edit and Remove options to the actual course reserves page (not just to the Courses page). The only other thing I'd comment on is the table width overflowing the white background colour for the section - but that is a common issues across many pages. Testing notes (using KTD): 1. Barcodes for batch adding: 39999000000559 39999000006094 39999000008036 39999000000498 39999000005134 39999000005776 39999000007077 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43450 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- (In reply to David Nind from comment #4)
I'm just curious why we don't also add the Actions button with Edit and Remove options to the actual course reserves page (not just to the Courses page).
If I understand correctly, what you mean by "the actual course reserves page" is /cgi-bin/koha/course_reserves/course-details.pl?course_id=XXX? Those actions are available on the course details page in the page's toolbar. This is the right place for them because the actions affect the whole course, whereas the "Edit" and "Delete" buttons in the table of items attached to the course affect those individual items. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43450 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 205897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205897&action=edit Bug 43450: (follow-up) Avoid jQuery for new or refactored code in Koha core -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org