[Bug 43452] New: Update header search forms to use input type "search"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43452 Bug ID: 43452 Summary: Update header search forms to use input type "search" Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Target Milestone: --- Related to Bug 33668, we can change the header search forms to use input type "search" and browsers which support it will display an icon to clear the search field. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43452 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Sponsorship status|--- |Sponsored Status|NEW |Needs Signoff Comma delimited| |Athens County Public list of Sponsors| |Libraries Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43452 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 204845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204845&action=edit Bug 43452: Update header search forms to use input type "search" This patch updates header search forms in the staff interface so that the input tag uses type "search." This reflects its purpose and will show, in supported browsers, an icon to clear the search field. The patch also wraps each header search form in the <search> tag. https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/search To test apply the patch and rebuild the staff interface CSS. - Test search forms to confirm that they look correct. There should be no change in functionality. - Test in a Chromium-based browser to confirm that the clear search icon appears when text has been typed into the input. - The following cases have been modified: - Acquisitions - Acquisitions -> Add to basket -> From a suggestion - Authorities - Cataloging - Catalog - Cities administration - Contracts administration - Currencies administration - Desks administration - ERM search - Notices - Patrons - OAI administration - Patrons categories administration - System preferences - Preservation - Z39.50 administration Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43452 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #204845|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43452 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 205388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205388&action=edit Bug 43452: Update header search forms to use input type "search" This patch updates header search forms in the staff interface so that the input tag uses type "search." This reflects its purpose and will show, in supported browsers, an icon to clear the search field. The patch also wraps each header search form in the <search> tag. https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/search To test apply the patch and rebuild the staff interface CSS. - Test search forms to confirm that they look correct. There should be no change in functionality. - Test in a Chromium-based browser to confirm that the clear search icon appears when text has been typed into the input. - The following cases have been modified: - Acquisitions - Acquisitions -> Add to basket -> From a suggestion - Authorities - Cataloging - Catalog - Cities administration - Contracts administration - Currencies administration - Desks administration - ERM search - Notices - Patrons - OAI administration - Patrons categories administration - System preferences - Preservation - Z39.50 administration Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43452 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #205388|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43452 --- Comment #3 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 205391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205391&action=edit Bug 43452: Update header search forms to use input type "search" This patch updates header search forms in the staff interface so that the input tag uses type "search." This reflects its purpose and will show, in supported browsers, an icon to clear the search field. The patch also wraps each header search form in the <search> tag. https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/search To test apply the patch and rebuild the staff interface CSS. - Test search forms to confirm that they look correct. There should be no change in functionality. - Test in a Chromium-based browser to confirm that the clear search icon appears when text has been typed into the input. - The following cases have been modified: - Acquisitions - Acquisitions -> Add to basket -> From a suggestion - Authorities - Cataloging - Catalog - Cities administration - Contracts administration - Currencies administration - Desks administration - ERM search - Notices - Patrons - OAI administration - Patrons categories administration - System preferences - Preservation - Z39.50 administration Sponsored-by: Athens County Public Libraries Signed-off-by: Gretchen Maxeiner <maxeinergl@gcc.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43452 Gretchen Maxeiner <maxeinergl@gcc.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |maxeinergl@gcc.edu --- Comment #4 from Gretchen Maxeiner <maxeinergl@gcc.edu> --- Everything looks good. In a sandbox I tested all of the listed searches in Chrome (Version 152.0.7977.83 (Official Build) (64-bit)). Search results were identical before and after the patch ; and after patch I can confirm all offered the X icon to clear the search field (which is great!). I also tested a sample after patch in Edge (Version 152.0.4191.66 (Official build) (64-bit)) with the same good results; search results were correct, clearing icon was present. For comparison I also tested a sample in Firefox (Version 155.0.1 (64-bit)), which is a non-Chromium browser. The patch did not hinder anything here. Search results were still correct but the browser does not offer the clearing icon, as expected. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org