[Bug 11328] New: local cover images in staff
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11328 Bug ID: 11328 Summary: local cover images in staff Change sponsored?: --- Product: Koha Version: 3.12 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: nengard@gmail.com QA Contact: testopia@bugs.koha-community.org The local cover images don't show on the staff results. This is what was reported to me: It looks like the staff client search results is using the same localcovers.js that the OPAC search results does however it doesn't work because the two pages are formatted differently. Here is a jquery that solves it for now: $("#searchresults").ready(function(){ $("#searchresults table td").each(function(i){ td = $(this); var tdv = td.find("input[class^='selection']"); var linkv = tdv.attr("value"); var a = $("<a />").attr('href', '/cgi-bin/koha/catalogue/imageviewer.pl?biblionumber=' + $(tdv).attr("value")); var img = $("<img />").attr('src', '/cgi-bin/koha/catalogue/image.pl?thumbnail=1&biblionumber=' + $(tdv).attr("value")) if(linkv){ $(td).append(a); $(a).append(img); } }); }); -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11328 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Version|3.12 |master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11328 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|local cover images in staff |Local cover images not | |appearing in staff client | |search results Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11328 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11328 Marjorie Barry-Vila <marjorie.barry-vila@ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11328 --- Comment #1 from Marjorie Barry-Vila <marjorie.barry-vila@ccsr.qc.ca> --- Created attachment 25459 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25459&action=edit local cover -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11328 --- Comment #2 from Marjorie Barry-Vila <marjorie.barry-vila@ccsr.qc.ca> --- Hi, It's the same for a staff detail biblio (see attachment). Jquery code you proposed is just for a results list? is there a jquery code for detail biblio? Regards, Marjorie -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11328 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Local cover images not |Show local cover images in |appearing in staff client |staff client search results |search results | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11328 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11328 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 25521 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25521&action=edit Bug 11328 - Show local cover images in staff client search results Local cover images do not appear in staff client search results. This patch adds them. To test, enable the LocalCoverImages system preference and add at least one cover image to a title. Perform a search which will return results that include your title. Confirm that the local cover image is displayed. Search results should also display correctly with and without AmazonCoverImages enabled as well as with LocalCoverImages disabled. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11328 wajasu <matted-34813@mypacks.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25521|0 |1 is obsolete| | CC| |matted-34813@mypacks.net --- Comment #4 from wajasu <matted-34813@mypacks.net> --- Created attachment 25681 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25681&action=edit [SIGNED-OFF] Bug 11328 - Show local cover images in staff client search results Local images appear now in results when available with the syspref on. But also other images from Amazon, which is fine. Bug 9991, should handle multiples, or no image avail at the same time. At least this allows local cover images to be shown. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11328 wajasu <matted-34813@mypacks.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11328 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11328 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25681|0 |1 is obsolete| | --- Comment #5 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 26012 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26012&action=edit [PASSED-QA] Bug 11328 - Show local cover images in staff client search results Local cover images do not appear in staff client search results. This patch adds them. To test, enable the LocalCoverImages system preference and add at least one cover image to a title. Perform a search which will return results that include your title. Confirm that the local cover image is displayed. Search results should also display correctly with and without AmazonCoverImages enabled as well as with LocalCoverImages disabled. Signed-off-by: wajasu <matted-34813@mypacks.net> Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11328 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #6 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11328 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #7 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.07 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org