[Bug 11794] New: opacSerialDefaultTab being ignored
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11794 Bug ID: 11794 Summary: opacSerialDefaultTab being ignored Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: nengard@gmail.com QA Contact: testopia@bugs.koha-community.org This is true in master and 3.14. If you have opacSerialDefaultTab set to show the subscription tab it still shows the holdings tab as default in ccsr and bootstrap. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11794 Jacek Ablewicz <abl@biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl@biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11794 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11794 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.14 |master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11794 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11794 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 25515 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25515&action=edit Bug 11794 - opacSerialDefaultTab being ignored The opacSerialDefaultTab system preference should control whether to show the holdings or subscriptions tab by default on the detail page for a serial. This behavior was broken when we last updated jQueryUI because of a change in the jQueryUI active tab class name. This patch corrects the class on the detail page and removes the old class from the authorities detail page (where it was unnecessary anyway). To test, view a serial record in the OPAC under various settings of the opacSerialDefaultTab preference. The default tab should correctly follow the preference. Test in prog and Bootstrap themes. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11794 Marjorie Barry-Vila <marjorie.barry-vila@ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11794 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Why did you remove it in the auth ones? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11794 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25515|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 25843 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25843&action=edit Bug 11794 - opacSerialDefaultTab being ignored The opacSerialDefaultTab system preference should control whether to show the holdings or subscriptions tab by default on the detail page for a serial. This behavior was broken when we last updated jQueryUI because of a change in the jQueryUI active tab class name. This patch corrects the class on the detail page and removes the old class from the authorities detail page (where it was unnecessary anyway). To test, view a serial record in the OPAC under various settings of the opacSerialDefaultTab preference. The default tab should correctly follow the preference. Test in prog and Bootstrap themes. Edit: Rebased on current master. Note that the change to opac-auth-detail.tt is because the page never has more than one tab, hence doesn't need the "active" designation. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11794 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11794 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25843|0 |1 is obsolete| | --- Comment #4 from Jesse Maseto <jesse@bywatersolutions.com> --- Created attachment 25976 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25976&action=edit [SIGNED-OFF] Bug 11794 - opacSerialDefaultTab being ignored The opacSerialDefaultTab system preference should control whether to show the holdings or subscriptions tab by default on the detail page for a serial. This behavior was broken when we last updated jQueryUI because of a change in the jQueryUI active tab class name. This patch corrects the class on the detail page and removes the old class from the authorities detail page (where it was unnecessary anyway). To test, view a serial record in the OPAC under various settings of the opacSerialDefaultTab preference. The default tab should correctly follow the preference. Test in prog and Bootstrap themes. Edit: Rebased on current master. Note that the change to opac-auth-detail.tt is because the page never has more than one tab, hence doesn't need the "active" designation. Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11794 --- Comment #5 from Jesse Maseto <jesse@bywatersolutions.com> --- Created attachment 25977 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25977&action=edit Bug 11794 - opacSerialDefaultTab being ignored The opacSerialDefaultTab system preference should control whether to show the holdings or subscriptions tab by default on the detail page for a serial. This behavior was broken when we last updated jQueryUI because of a change in the jQueryUI active tab class name. This patch corrects the class on the detail page and removes the old class from the authorities detail page (where it was unnecessary anyway). To test, view a serial record in the OPAC under various settings of the opacSerialDefaultTab preference. The default tab should correctly follow the preference. Test in prog and Bootstrap themes. Edit: Rebased on current master. Note that the change to opac-auth-detail.tt is because the page never has more than one tab, hence doesn't need the "active" designation. Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11794 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25977|0 |1 is obsolete| | CC| |jesse@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11794 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11794 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25976|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 25982 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25982&action=edit [PASSED QA] Bug 11794 - opacSerialDefaultTab being ignored The opacSerialDefaultTab system preference should control whether to show the holdings or subscriptions tab by default on the detail page for a serial. This behavior was broken when we last updated jQueryUI because of a change in the jQueryUI active tab class name. This patch corrects the class on the detail page and removes the old class from the authorities detail page (where it was unnecessary anyway). To test, view a serial record in the OPAC under various settings of the opacSerialDefaultTab preference. The default tab should correctly follow the preference. Test in prog and Bootstrap themes. Edit: Rebased on current master. Note that the change to opac-auth-detail.tt is because the page never has more than one tab, hence doesn't need the "active" designation. Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Tested in prog and bootstrap. All tests and QA script pass. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11794 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #7 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11794 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #8 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.07 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org